Skip to content

Commit 305825d

Browse files
inochisaKAGA-KOKO
authored andcommitted
irqchip/sg2042-msi: Add missing chip flags
The sg2042-msi driver uses the fallback callbacks set by msi_lib_init_dev_msi_info(). commit 1c000dc ("irqchip/irq-msi-lib: Optionally set default irq_eoi()/irq_ack()") changed the behavior of the fallback mechanism by making it opt-in. The sg2042-msi was not fixed up for this, which causes a NULL pointer dereference due to the missing irq_ack() callback. Add the missing chip flag to msi_parent_ops. Fixes: c667415 ("irqchip: Add the Sophgo SG2042 MSI interrupt controller") Signed-off-by: Inochi Amaoto <[email protected]> Signed-off-by: Thomas Gleixner <[email protected]> Link: https://lore.kernel.org/all/[email protected] Link: https://lore.kernel.org/all/[email protected]
1 parent 75f8c87 commit 305825d

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/irqchip/irq-sg2042-msi.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,7 @@ static const struct irq_domain_ops sg2042_msi_middle_domain_ops = {
151151
static const struct msi_parent_ops sg2042_msi_parent_ops = {
152152
.required_flags = SG2042_MSI_FLAGS_REQUIRED,
153153
.supported_flags = SG2042_MSI_FLAGS_SUPPORTED,
154+
.chip_flags = MSI_CHIP_FLAG_SET_ACK,
154155
.bus_select_mask = MATCH_PCI_MSI,
155156
.bus_select_token = DOMAIN_BUS_NEXUS,
156157
.prefix = "SG2042-",

0 commit comments

Comments
 (0)