Skip to content

Commit 3dc0ec4

Browse files
hcodinawsakernel
authored andcommitted
i2c: muxes: i2c-mux-gpmux: Use of_get_i2c_adapter_by_node()
i2c-mux-gpmux uses the pair of_find_i2c_adapter_by_node() / i2c_put_adapter(). These pair alone is not correct to properly lock the I2C parent adapter. Indeed, i2c_put_adapter() decrements the module refcount while of_find_i2c_adapter_by_node() does not increment it. This leads to an underflow of the parent module refcount. Use the dedicated function, of_get_i2c_adapter_by_node(), to handle correctly the module refcount. Fixes: ac8498f ("i2c: i2c-mux-gpmux: new driver") Signed-off-by: Herve Codina <[email protected]> Cc: [email protected] Acked-by: Peter Rosin <[email protected]> Reviewed-by: Jonathan Cameron <[email protected]> Signed-off-by: Wolfram Sang <[email protected]>
1 parent 0fb118d commit 3dc0ec4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/i2c/muxes/i2c-mux-gpmux.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ static struct i2c_adapter *mux_parent_adapter(struct device *dev)
5252
dev_err(dev, "Cannot parse i2c-parent\n");
5353
return ERR_PTR(-ENODEV);
5454
}
55-
parent = of_find_i2c_adapter_by_node(parent_np);
55+
parent = of_get_i2c_adapter_by_node(parent_np);
5656
of_node_put(parent_np);
5757
if (!parent)
5858
return ERR_PTR(-EPROBE_DEFER);

0 commit comments

Comments
 (0)