Skip to content

Commit 8593b6f

Browse files
committed
Merge branch 'for-usb-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/sarah/xhci into usb-linus
* 'for-usb-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/sarah/xhci: Revert "xHCI: reset-on-resume quirk for NEC uPD720200" xHCI: fix bug in xhci_clear_command_ring()
2 parents 307369b + 0de1350 commit 8593b6f

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

drivers/usb/host/xhci-pci.c

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,6 @@
3333
#define PCI_VENDOR_ID_ETRON 0x1b6f
3434
#define PCI_DEVICE_ID_ASROCK_P67 0x7023
3535

36-
#define PCI_DEVICE_ID_NEC_uPD720200 0x0194
37-
3836
static const char hcd_name[] = "xhci_hcd";
3937

4038
/* called after powerup, by probe or system-pm "wakeup" */
@@ -76,11 +74,8 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
7674
pdev->revision);
7775
}
7876

79-
if (pdev->vendor == PCI_VENDOR_ID_NEC) {
77+
if (pdev->vendor == PCI_VENDOR_ID_NEC)
8078
xhci->quirks |= XHCI_NEC_HOST;
81-
if (pdev->device == PCI_DEVICE_ID_NEC_uPD720200)
82-
xhci->quirks |= XHCI_RESET_ON_RESUME;
83-
}
8479

8580
if (pdev->vendor == PCI_VENDOR_ID_AMD && xhci->hci_version == 0x96)
8681
xhci->quirks |= XHCI_AMD_0x96_HOST;

drivers/usb/host/xhci.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -711,7 +711,10 @@ static void xhci_clear_command_ring(struct xhci_hcd *xhci)
711711
ring = xhci->cmd_ring;
712712
seg = ring->deq_seg;
713713
do {
714-
memset(seg->trbs, 0, SEGMENT_SIZE);
714+
memset(seg->trbs, 0,
715+
sizeof(union xhci_trb) * (TRBS_PER_SEGMENT - 1));
716+
seg->trbs[TRBS_PER_SEGMENT - 1].link.control &=
717+
cpu_to_le32(~TRB_CYCLE);
715718
seg = seg->next;
716719
} while (seg != ring->deq_seg);
717720

0 commit comments

Comments
 (0)