Skip to content

Commit a4a45a9

Browse files
committed
fsdax: Remove unused trace events for dax insert mapping
When the dax_fault_actor() helper was factored out, it removed the calls to the dax_pmd_insert_mapping and dax_insert_mapping events but never removed the events themselves. As each event created takes up memory (roughly 5K each), this is a waste as it is never used. Remove the unused dax_pmd_insert_mapping and dax_insert_mapping trace events. Link: https://lore.kernel.org/all/[email protected]/ Cc: Shiyang Ruan <[email protected]> Cc: "Darrick J. Wong" <[email protected]> Cc: Ross Zwisler <[email protected]> Cc: Andrew Morton <[email protected]> Link: https://lore.kernel.org/[email protected] Fixes: c243619 ("fsdax: factor out a dax_fault_actor() helper") Acked-by: Dan Williams <[email protected]> Reviewed-by: Alison Schofield <[email protected]> Signed-off-by: Steven Rostedt (Google) <[email protected]>
1 parent 167d7ed commit a4a45a9

File tree

1 file changed

+0
-78
lines changed

1 file changed

+0
-78
lines changed

include/trace/events/fs_dax.h

Lines changed: 0 additions & 78 deletions
Original file line numberDiff line numberDiff line change
@@ -102,54 +102,6 @@ DEFINE_EVENT(dax_pmd_load_hole_class, name, \
102102
DEFINE_PMD_LOAD_HOLE_EVENT(dax_pmd_load_hole);
103103
DEFINE_PMD_LOAD_HOLE_EVENT(dax_pmd_load_hole_fallback);
104104

105-
DECLARE_EVENT_CLASS(dax_pmd_insert_mapping_class,
106-
TP_PROTO(struct inode *inode, struct vm_fault *vmf,
107-
long length, pfn_t pfn, void *radix_entry),
108-
TP_ARGS(inode, vmf, length, pfn, radix_entry),
109-
TP_STRUCT__entry(
110-
__field(unsigned long, ino)
111-
__field(unsigned long, vm_flags)
112-
__field(unsigned long, address)
113-
__field(long, length)
114-
__field(u64, pfn_val)
115-
__field(void *, radix_entry)
116-
__field(dev_t, dev)
117-
__field(int, write)
118-
),
119-
TP_fast_assign(
120-
__entry->dev = inode->i_sb->s_dev;
121-
__entry->ino = inode->i_ino;
122-
__entry->vm_flags = vmf->vma->vm_flags;
123-
__entry->address = vmf->address;
124-
__entry->write = vmf->flags & FAULT_FLAG_WRITE;
125-
__entry->length = length;
126-
__entry->pfn_val = pfn.val;
127-
__entry->radix_entry = radix_entry;
128-
),
129-
TP_printk("dev %d:%d ino %#lx %s %s address %#lx length %#lx "
130-
"pfn %#llx %s radix_entry %#lx",
131-
MAJOR(__entry->dev),
132-
MINOR(__entry->dev),
133-
__entry->ino,
134-
__entry->vm_flags & VM_SHARED ? "shared" : "private",
135-
__entry->write ? "write" : "read",
136-
__entry->address,
137-
__entry->length,
138-
__entry->pfn_val & ~PFN_FLAGS_MASK,
139-
__print_flags_u64(__entry->pfn_val & PFN_FLAGS_MASK, "|",
140-
PFN_FLAGS_TRACE),
141-
(unsigned long)__entry->radix_entry
142-
)
143-
)
144-
145-
#define DEFINE_PMD_INSERT_MAPPING_EVENT(name) \
146-
DEFINE_EVENT(dax_pmd_insert_mapping_class, name, \
147-
TP_PROTO(struct inode *inode, struct vm_fault *vmf, \
148-
long length, pfn_t pfn, void *radix_entry), \
149-
TP_ARGS(inode, vmf, length, pfn, radix_entry))
150-
151-
DEFINE_PMD_INSERT_MAPPING_EVENT(dax_pmd_insert_mapping);
152-
153105
DECLARE_EVENT_CLASS(dax_pte_fault_class,
154106
TP_PROTO(struct inode *inode, struct vm_fault *vmf, int result),
155107
TP_ARGS(inode, vmf, result),
@@ -194,36 +146,6 @@ DEFINE_PTE_FAULT_EVENT(dax_load_hole);
194146
DEFINE_PTE_FAULT_EVENT(dax_insert_pfn_mkwrite_no_entry);
195147
DEFINE_PTE_FAULT_EVENT(dax_insert_pfn_mkwrite);
196148

197-
TRACE_EVENT(dax_insert_mapping,
198-
TP_PROTO(struct inode *inode, struct vm_fault *vmf, void *radix_entry),
199-
TP_ARGS(inode, vmf, radix_entry),
200-
TP_STRUCT__entry(
201-
__field(unsigned long, ino)
202-
__field(unsigned long, vm_flags)
203-
__field(unsigned long, address)
204-
__field(void *, radix_entry)
205-
__field(dev_t, dev)
206-
__field(int, write)
207-
),
208-
TP_fast_assign(
209-
__entry->dev = inode->i_sb->s_dev;
210-
__entry->ino = inode->i_ino;
211-
__entry->vm_flags = vmf->vma->vm_flags;
212-
__entry->address = vmf->address;
213-
__entry->write = vmf->flags & FAULT_FLAG_WRITE;
214-
__entry->radix_entry = radix_entry;
215-
),
216-
TP_printk("dev %d:%d ino %#lx %s %s address %#lx radix_entry %#lx",
217-
MAJOR(__entry->dev),
218-
MINOR(__entry->dev),
219-
__entry->ino,
220-
__entry->vm_flags & VM_SHARED ? "shared" : "private",
221-
__entry->write ? "write" : "read",
222-
__entry->address,
223-
(unsigned long)__entry->radix_entry
224-
)
225-
)
226-
227149
DECLARE_EVENT_CLASS(dax_writeback_range_class,
228150
TP_PROTO(struct inode *inode, pgoff_t start_index, pgoff_t end_index),
229151
TP_ARGS(inode, start_index, end_index),

0 commit comments

Comments
 (0)