Skip to content

Commit 883daa7

Browse files
committed
[ValueTracking] Add logic for isKnownNonZero(umax X, Y)
`(umax X, Y) != 0` -> `X != 0 || Y != 0` Alive2 Link: https://alive2.llvm.org/ce/z/_Z9AUT Reviewed By: nikic Differential Revision: https://reviews.llvm.org/D149415
1 parent 167ecda commit 883daa7

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed

llvm/lib/Analysis/ValueTracking.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2936,6 +2936,7 @@ bool isKnownNonZero(const Value *V, const APInt &DemandedElts, unsigned Depth,
29362936
return isNonZeroAdd(DemandedElts, Depth, Q, BitWidth,
29372937
II->getArgOperand(0), II->getArgOperand(1),
29382938
/*NSW*/ true);
2939+
case Intrinsic::umax:
29392940
case Intrinsic::uadd_sat:
29402941
if (isKnownNonZero(II->getArgOperand(0), DemandedElts, Depth, Q) ||
29412942
isKnownNonZero(II->getArgOperand(1), DemandedElts, Depth, Q))

llvm/test/Analysis/ValueTracking/known-non-zero.ll

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -961,10 +961,7 @@ define i1 @umax_nonzero(i8 %xx, i8 %yy, i8 %ind) {
961961
; CHECK-LABEL: @umax_nonzero(
962962
; CHECK-NEXT: [[X_NZ:%.*]] = icmp ne i8 [[XX:%.*]], 0
963963
; CHECK-NEXT: call void @llvm.assume(i1 [[X_NZ]])
964-
; CHECK-NEXT: [[X:%.*]] = call i8 @llvm.umax.i8(i8 [[XX]], i8 [[YY:%.*]])
965-
; CHECK-NEXT: [[Z:%.*]] = or i8 [[X]], [[IND:%.*]]
966-
; CHECK-NEXT: [[R:%.*]] = icmp eq i8 [[Z]], 0
967-
; CHECK-NEXT: ret i1 [[R]]
964+
; CHECK-NEXT: ret i1 false
968965
;
969966
%x_nz = icmp ne i8 %xx, 0
970967
call void @llvm.assume(i1 %x_nz)

llvm/test/Transforms/LoopVectorize/interleaved-accesses.ll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -483,10 +483,10 @@ define void @even_load_dynamic_tc(ptr noalias nocapture readonly %A, ptr noalias
483483
; CHECK-LABEL: @even_load_dynamic_tc(
484484
; CHECK-NEXT: entry:
485485
; CHECK-NEXT: [[UMAX:%.*]] = call i64 @llvm.umax.i64(i64 [[N:%.*]], i64 2)
486-
; CHECK-NEXT: [[TMP0:%.*]] = add i64 [[UMAX]], -1
487-
; CHECK-NEXT: [[MIN_ITERS_CHECK:%.*]] = icmp ult i64 [[TMP0]], 8
486+
; CHECK-NEXT: [[MIN_ITERS_CHECK:%.*]] = icmp ult i64 [[UMAX]], 9
488487
; CHECK-NEXT: br i1 [[MIN_ITERS_CHECK]], label [[SCALAR_PH:%.*]], label [[VECTOR_PH:%.*]]
489488
; CHECK: vector.ph:
489+
; CHECK-NEXT: [[TMP0:%.*]] = add i64 [[UMAX]], -1
490490
; CHECK-NEXT: [[TMP1:%.*]] = lshr i64 [[TMP0]], 1
491491
; CHECK-NEXT: [[TMP2:%.*]] = add nuw i64 [[TMP1]], 1
492492
; CHECK-NEXT: [[N_MOD_VF:%.*]] = and i64 [[TMP2]], 3

0 commit comments

Comments
 (0)