Skip to content

Commit 909f3c5

Browse files
geertuglaubitz
authored andcommitted
sh: boards: Use imply to enable hardware with complex dependencies
If CONFIG_I2C=n: WARNING: unmet direct dependencies detected for SND_SOC_AK4642 Depends on [n]: SOUND [=y] && SND [=y] && SND_SOC [=y] && I2C [=n] Selected by [y]: - SH_7724_SOLUTION_ENGINE [=y] && CPU_SUBTYPE_SH7724 [=y] && SND_SIMPLE_CARD [=y] WARNING: unmet direct dependencies detected for SND_SOC_DA7210 Depends on [n]: SOUND [=y] && SND [=y] && SND_SOC [=y] && SND_SOC_I2C_AND_SPI [=n] Selected by [y]: - SH_ECOVEC [=y] && CPU_SUBTYPE_SH7724 [=y] && SND_SIMPLE_CARD [=y] Fix this by replacing select by imply, instead of adding a dependency on I2C. Reported-by: kernel test robot <[email protected]> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/ Signed-off-by: Geert Uytterhoeven <[email protected]> Reviewed-by: John Paul Adrian Glaubitz <[email protected]> Signed-off-by: John Paul Adrian Glaubitz <[email protected]>
1 parent 21bcc49 commit 909f3c5

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

arch/sh/boards/Kconfig

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,8 @@ config SH_7724_SOLUTION_ENGINE
8080
select SOLUTION_ENGINE
8181
depends on CPU_SUBTYPE_SH7724
8282
select GPIOLIB
83-
select SND_SOC_AK4642 if SND_SIMPLE_CARD
8483
select REGULATOR_FIXED_VOLTAGE if REGULATOR
84+
imply SND_SOC_AK4642 if SND_SIMPLE_CARD
8585
help
8686
Select 7724 SolutionEngine if configuring for a Hitachi SH7724
8787
evaluation board.
@@ -259,8 +259,8 @@ config SH_ECOVEC
259259
bool "EcoVec"
260260
depends on CPU_SUBTYPE_SH7724
261261
select GPIOLIB
262-
select SND_SOC_DA7210 if SND_SIMPLE_CARD
263262
select REGULATOR_FIXED_VOLTAGE if REGULATOR
263+
imply SND_SOC_DA7210 if SND_SIMPLE_CARD
264264
help
265265
Renesas "R0P7724LC0011/21RL (EcoVec)" support.
266266

0 commit comments

Comments
 (0)