_get_firmware_ok() fixed to return boolean as it is expected to

Veijo Pesonen · Veijo Pesonen · commit 9c5dd4b673f7 · 2018-03-19T14:27:52.000+02:00
diff --git a/ESP8266Interface.cpp b/ESP8266Interface.cpp
@@ -244,10 +244,10 @@ bool ESP8266Interface::_get_firmware_ok()
     if (_esp.get_firmware_version() != ESP8266_VERSION) {
         debug("ESP8266: ERROR: Firmware incompatible with this driver.\
                \r\nUpdate to v%d - https://developer.mbed.org/teams/ESP8266/wiki/Firmware-Update\r\n",ESP8266_VERSION);
-        return NSAPI_ERROR_DEVICE_ERROR;
+        return false;
     }
 
-    return NSAPI_ERROR_OK;
+    return true;
 }
 
 bool ESP8266Interface::_disable_default_softap()
@@ -274,7 +274,7 @@ nsapi_error_t ESP8266Interface::_init(void)
         if (!_esp.reset()) {
             return NSAPI_ERROR_DEVICE_ERROR;
         }
-        if (_get_firmware_ok() != NSAPI_ERROR_OK) {
+        if (!_get_firmware_ok()) {
             return NSAPI_ERROR_DEVICE_ERROR;
         }
         if (_disable_default_softap() == false) {

Original file line number	Diff line number	Diff line change
`@@ -244,10 +244,10 @@ bool ESP8266Interface::_get_firmware_ok()`
`244`	`244`	`if (_esp.get_firmware_version() != ESP8266_VERSION) {`
`245`	`245`	`debug("ESP8266: ERROR: Firmware incompatible with this driver.\`
`246`	`246`	`\r\nUpdate to v%d - https://developer.mbed.org/teams/ESP8266/wiki/Firmware-Update\r\n",ESP8266_VERSION);`
`247`		`- return NSAPI_ERROR_DEVICE_ERROR;`
	`247`	`+ return false;`
`248`	`248`	`}`
`249`	`249`
`250`		`- return NSAPI_ERROR_OK;`
	`250`	`+ return true;`
`251`	`251`	`}`
`252`	`252`
`253`	`253`	`bool ESP8266Interface::_disable_default_softap()`
`@@ -274,7 +274,7 @@ nsapi_error_t ESP8266Interface::_init(void)`
`274`	`274`	`if (!_esp.reset()) {`
`275`	`275`	`return NSAPI_ERROR_DEVICE_ERROR;`
`276`	`276`	`}`
`277`		`- if (_get_firmware_ok() != NSAPI_ERROR_OK) {`
	`277`	`+ if (!_get_firmware_ok()) {`
`278`	`278`	`return NSAPI_ERROR_DEVICE_ERROR;`
`279`	`279`	`}`
`280`	`280`	`if (_disable_default_softap() == false) {`