Skip to content

Port esp2866 driver to new WiFiInterface API #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2016

Conversation

bulislaw
Copy link
Member

@0xc0170 Don't merge before mbed/feature_wifi branch is merged to master.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 26, 2016

cc @geky please review

Copy link
Contributor

@geky geky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good, but this pr must wait for the mbed/feature_wifi branch to be merged.

@@ -79,7 +79,7 @@ bool ESP8266::disconnect(void)
const char *ESP8266::getIPAddress(void)
{
if (!(_parser.send("AT+CIFSR")
&& _parser.recv("+CIFSR:STAIP,\"%[^\"]\"", _ip_buffer)
&& _parser.recv("+CIFSR:STAIP,\"%15[^\"]\"", _ip_buffer)
Copy link
Contributor

@geky geky Sep 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for this 👍

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 5, 2016

@bulislaw We shall update this on top of latest master (rc1 in this case) to reflect changes we did to the wifi

@bulislaw bulislaw force-pushed the feature_wifi branch 2 times, most recently from 7ef7aff to eb312b7 Compare October 6, 2016 13:57
@c1728p9
Copy link
Contributor

c1728p9 commented Oct 7, 2016

I rebased to master and solved merge conflicts.

@c1728p9 c1728p9 merged commit dc37b65 into ARMmbed:master Oct 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants