Cleanup AT cmd timeouts. Free corrupted packages in package handler. #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeppoTakalo
approved these changes
Mar 21, 2018
kjbracey
reviewed
Mar 21, 2018
| @@ -21,6 +21,20 @@ | |||
| #include "nsapi_types.h" | |||
| #include "rtos.h" | |||
|
|
|||
| // Various timeouts for different ESP8266 operations | |||
| #ifndef ESP8266_CONNECT_TIMEOUT | |||
| #define ESP8266_CONNECT_TIMEOUT 15000 | |||
There was a problem hiding this comment.
From what we've seen, TCP connections are an issue. This should be long enough to cover the longest TCP connection timeout in the chip. May be that you need a separate one for TCP and UDP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.