Fix tests

Author: Juho Hovila

test/non_hardware/test_flash.py

@@ -20,8 +20,10 @@
 # pylint:disable=unused-argument
 
 import logging
-import unittest
 import os
+import platform
+import unittest
+
 import mock
 
 from mbed_flasher.common import FlashError
@@ -115,44 +117,42 @@ def test_raises_with_bad_file_extension(self):
         self.assertEqual(cm.exception.return_code, EXIT_CODE_DAPLINK_USER_ERROR)
 
     # pylint: disable=no-self-use
-    def test_copy_file_with_spaces(self):
-        try:
-            flasher = FlasherMbed()
-            flasher.copy_file(__file__, "tar get")
-        finally:
-            os.remove("tar get")
+    @unittest.skipIf(platform.system() != 'Windows', 'require windows')
+    @mock.patch('subprocess.check_call')
+    def test_copy_file_with_spaces(self, mock_check_call):
+        flasher = FlasherMbed()
+        flasher.copy_file(__file__, "tar get")
+        should_be = ["cmd", "/c", "copy", __file__, "tar get"]
+        mock_check_call.assert_called_with(should_be)
 
     def test_copy_file_unable_to_read(self):
         flasher = FlasherMbed()
         with self.assertRaises(FlashError):
             flasher.copy_file("not-existing-file", "target")
 
     # pylint: disable=no-self-use
-    def test_copy_empty_file(self):
+    @unittest.skipIf(platform.system() != 'Windows', 'require windows')
+    @mock.patch('subprocess.check_call')
+    def test_copy_empty_file_windows(self, mock_system):
+        flasher = FlasherMbed()
+        file_path = os.path.join(os.getcwd(), "empty_file")
+        with open(file_path, 'a'):
+            os.utime(file_path, None)
+        flasher.copy_file(file_path, "target")
+        os.remove(file_path)
+        should_be = ["cmd", "/c", "copy", file_path, "target"]
+        mock_system.assert_called_once_with(should_be)
+
+    @unittest.skipIf(platform.system() != 'Linux', 'require linux')
+    @mock.patch('mbed_flasher.flashers.FlasherMbed.FlasherMbed._copy_file')
+    def test_copy_empty_file_linux(self, mock_copy_file):
         flasher = FlasherMbed()
         with open("empty_file", 'a'):
-            os.utime("empty_file", None)
+            pass
+
         flasher.copy_file("empty_file", "target")
         os.remove("empty_file")
-        os.remove("target")
-
-    # pylint: disable=no-self-use
-    def test_copy_file_write_success(self):
-        flasher = FlasherMbed()
-        with open("source_file", 'wb') as source_file:
-            source_file.write(b"test data")
-
-        flasher.copy_file("source_file", "destination")
-
-        with open("destination", "rb") as destination:
-            result = destination.read()
-
-        # remove file before assert to clean environment
-        os.remove("source_file")
-        os.remove("destination")
-
-        # make sure file.write() really worked
-        self.assertEqual(result, b"test data", "copy file failed")
+        mock_copy_file.assert_called_once_with(b"", "target")
 
 
 class FlasherMbedRetry(unittest.TestCase):