Skip to content

Commit 22be61d

Browse files
committed
Adding tests for new filter function
1 parent b3e345f commit 22be61d

File tree

1 file changed

+33
-12
lines changed

1 file changed

+33
-12
lines changed

test/mbedls_toolsbase.py

Lines changed: 33 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -156,14 +156,19 @@ def test_fs_never(self):
156156
'serial_port': 'invalid_serial_port'
157157
}
158158
with patch("mbed_lstools.lstools_base.MbedLsToolsBase._update_device_from_htm") as _up_htm:
159-
filter = re.compile("")
160-
ret = self.base._fs_never(device, filter)
159+
filter = None
160+
ret = self.base._fs_never(deepcopy(device), filter)
161161
self.assertIsNotNone(ret)
162162
self.assertEqual(ret['target_id'], ret['target_id_usb_id'])
163163
_up_htm.assert_not_called()
164164

165-
filter_out = re.compile("NOT-K64F")
166-
ret = self.base._fs_never(device, filter_out)
165+
filter_in = lambda m: m['platform_name'] == 'K64F'
166+
ret = self.base._fs_never(deepcopy(device), filter_in)
167+
self.assertIsNotNone(ret)
168+
_up_htm.assert_not_called()
169+
170+
filter_out = lambda m: m['platform_name'] != 'K64F'
171+
ret = self.base._fs_never(deepcopy(device), filter_out)
167172
self.assertIsNone(ret)
168173
_up_htm.assert_not_called()
169174

@@ -176,16 +181,24 @@ def test_fs_after(self):
176181
with patch("mbed_lstools.lstools_base.MbedLsToolsBase._read_htm_ids") as _read_htm:
177182
new_device_id = "00017531642046"
178183
_read_htm.return_value = (new_device_id, {})
179-
filter = re.compile("")
180-
ret = self.base._fs_after_id_check(device, filter)
184+
filter = None
185+
ret = self.base._fs_after_id_check(deepcopy(device), filter)
181186
self.assertIsNotNone(ret)
182187
self.assertEqual(ret['target_id'], new_device_id)
183188
_read_htm.assert_called_with(device['mount_point'])
184189

185190
_read_htm.reset_mock()
186191

187-
filter_out = re.compile("NOT-K64F")
188-
ret = self.base._fs_after_id_check(device, filter_out)
192+
filter_in = lambda m: m['target_id'] == device['target_id_usb_id']
193+
ret = self.base._fs_after_id_check(deepcopy(device), filter_in)
194+
self.assertIsNotNone(ret)
195+
self.assertEqual(ret['target_id'], new_device_id)
196+
_read_htm.assert_called_with(device['mount_point'])
197+
198+
_read_htm.reset_mock()
199+
200+
filter_out = lambda m: m['target_id'] == new_device_id
201+
ret = self.base._fs_after_id_check(deepcopy(device), filter_out)
189202
self.assertIsNone(ret)
190203
_read_htm.assert_not_called()
191204

@@ -198,16 +211,24 @@ def test_fs_before(self):
198211
with patch("mbed_lstools.lstools_base.MbedLsToolsBase._read_htm_ids") as _read_htm:
199212
new_device_id = u'00017575430420'
200213
_read_htm.return_value = (new_device_id, {})
201-
filter = re.compile(u'')
202-
ret = self.base._fs_before_id_check(device, filter)
214+
filter = None
215+
ret = self.base._fs_before_id_check(deepcopy(device), filter)
216+
self.assertIsNotNone(ret)
217+
self.assertEqual(ret['target_id'], new_device_id)
218+
_read_htm.assert_called_with(device['mount_point'])
219+
220+
_read_htm.reset_mock()
221+
222+
filter_in = lambda m: m['target_id'] == '00017575430420'
223+
ret = self.base._fs_before_id_check(deepcopy(device), filter_in)
203224
self.assertIsNotNone(ret)
204225
self.assertEqual(ret['target_id'], new_device_id)
205226
_read_htm.assert_called_with(device['mount_point'])
206227

207228
_read_htm.reset_mock()
208229

209-
filter_out = re.compile("NOT-LPC2368")
210-
ret = self.base._fs_before_id_check(device, filter_out)
230+
filter_out = lambda m: m['target_id'] == '024075309420ABCE'
231+
ret = self.base._fs_before_id_check(deepcopy(device), filter_out)
211232
self.assertIsNone(ret)
212233
_read_htm.assert_called_with(device['mount_point'])
213234

0 commit comments

Comments
 (0)