Skip to content

Commit 2e80e28

Browse files
committed
Patching test cases
1 parent 9f111b9 commit 2e80e28

File tree

1 file changed

+19
-8
lines changed

1 file changed

+19
-8
lines changed

test/mbedls_toolsbase.py

Lines changed: 19 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -289,12 +289,21 @@ def test_update_device_from_fs_unknown(self):
289289
self.assertEqual(device['device_type'], 'unknown')
290290

291291
def test_detect_device_test(self):
292-
device_type = self.base._detect_device_type(['Segger.html'])
293-
self.assertEqual(device_type, 'jlink')
294-
295-
device_type = self.base._detect_device_type(['MBED.HTM', 'DETAILS.TXT'])
292+
device_type = self.base._detect_device_type({
293+
'vendor_id': '0483'
294+
})
295+
self.assertEqual(device_type, 'stlink')
296+
297+
device_type = self.base._detect_device_type({
298+
'vendor_id': '0d28'
299+
})
296300
self.assertEqual(device_type, 'daplink')
297301

302+
device_type = self.base._detect_device_type({
303+
'vendor_id': '1366'
304+
})
305+
self.assertEqual(device_type, 'jlink')
306+
298307
def test_update_device_details_jlink(self):
299308
jlink_html_contents = ('<html><head><meta http-equiv="refresh" '
300309
'content="0; url=http://www.nxp.com/FRDM-KL27Z"/>'
@@ -307,24 +316,26 @@ def test_update_device_details_jlink(self):
307316

308317
with patch('mbed_lstools.lstools_base.open', _open, create=True):
309318
device = deepcopy(base_device)
310-
self.base._update_device_details_jlink(device, False, ['Board.html', 'User Guide.html'])
319+
device['directory_entries'] = ['Board.html', 'User Guide.html']
320+
self.base._update_device_details_jlink(device, False)
311321
self.assertEqual(device['url'], 'http://www.nxp.com/FRDM-KL27Z')
312322
self.assertEqual(device['platform_name'], 'KL27Z')
313323
_open.assert_called_once_with(os.path.join(dummy_mount_point, 'Board.html'), 'r')
314324

315325
_open.reset_mock()
316326

317327
device = deepcopy(base_device)
318-
self.base._update_device_details_jlink(device, False, ['User Guide.html'])
328+
device['directory_entries'] = ['User Guide.html']
329+
self.base._update_device_details_jlink(device, False)
319330
self.assertEqual(device['url'], 'http://www.nxp.com/FRDM-KL27Z')
320331
self.assertEqual(device['platform_name'], 'KL27Z')
321332
_open.assert_called_once_with(os.path.join(dummy_mount_point, 'User Guide.html'), 'r')
322333

323334
_open.reset_mock()
324335

325336
device = deepcopy(base_device)
326-
self.base._update_device_details_jlink(device, False, ['unhelpful_file.html'])
327-
self.assertEqual(device, base_device)
337+
device['directory_entries'] = ['unhelpful_file.html']
338+
self.base._update_device_details_jlink(device, False)
328339
_open.assert_not_called()
329340

330341
def test_fs_never(self):

0 commit comments

Comments
 (0)