Changing temp file strategy so the can be reopened on Windows

Author: bridadan

test/platform_database.py

@@ -38,10 +38,11 @@ class EmptyPlatformDatabaseTests(unittest.TestCase):
     """
 
     def setUp(self):
-        self.base_db = tempfile.NamedTemporaryFile(prefix='base')
+        self.base_db_path = os.path.join(tempfile.mkdtemp(), 'base')
+        self.base_db = open(self.base_db_path, 'w+')
         self.base_db.write(b'{}')
         self.base_db.seek(0)
-        self.pdb = PlatformDatabase([self.base_db.name])
+        self.pdb = PlatformDatabase([self.base_db_path])
 
     def tearDown(self):
         pass
@@ -52,7 +53,7 @@ def test_broken_database_io(self):
         """
         with patch("mbed_lstools.platform_database.open") as _open:
             _open.side_effect = IOError("Bogus")
-            self.pdb = PlatformDatabase([self.base_db.name])
+            self.pdb = PlatformDatabase([self.base_db_path])
             self.pdb.add("1234", "MYTARGET")
             self.assertEqual(self.pdb.get("1234"), "MYTARGET")
 
@@ -62,7 +63,7 @@ def test_broken_database_bad_json(self):
         """
         self.base_db.write(b'{{}')
         self.base_db.seek(0)
-        self.pdb = PlatformDatabase([self.base_db.name])
+        self.pdb = PlatformDatabase([self.base_db_path])
         self.pdb.add("1234", "MYTARGET")
         self.assertEqual(self.pdb.get("1234"), "MYTARGET")
 
@@ -119,15 +120,18 @@ class OverriddenPlatformDatabaseTests(unittest.TestCase):
     """
 
     def setUp(self):
-        self.base_db = tempfile.NamedTemporaryFile(prefix='base')
+        self.temp_dir = tempfile.mkdtemp()
+        self.base_db_path = os.path.join(self.temp_dir, 'base')
+        self.base_db = open(self.base_db_path, 'w+')
         self.base_db.write(json.dumps(dict([('0123', 'Base_Platform')])).
                            encode('utf-8'))
         self.base_db.seek(0)
-        self.overriding_db = tempfile.NamedTemporaryFile(prefix='overriding')
+        self.overriding_db_path = os.path.join(self.temp_dir, 'overriding')
+        self.overriding_db = open(self.overriding_db_path, 'w+')
         self.overriding_db.write(b'{}')
         self.overriding_db.seek(0)
-        self.pdb = PlatformDatabase([self.overriding_db.name, self.base_db.name],
-                                    primary_database=self.overriding_db.name)
+        self.pdb = PlatformDatabase([self.overriding_db_path, self.base_db_path],
+                                    primary_database=self.overriding_db_path)
         self.base_db.seek(0)
         self.overriding_db.seek(0)
 
@@ -170,8 +174,8 @@ def test_load_override(self):
         self.overriding_db.write(json.dumps(dict([('0123', 'Overriding_Platform')])).
                                  encode('utf-8'))
         self.overriding_db.seek(0)
-        self.pdb = PlatformDatabase([self.overriding_db.name, self.base_db.name],
-                                    primary_database=self.overriding_db.name)
+        self.pdb = PlatformDatabase([self.overriding_db_path, self.base_db_path],
+                                    primary_database=self.overriding_db_path)
         self.assertIn(('0123', 'Overriding_Platform'), list(self.pdb.items()))
         self.assertEqual(set(self.pdb.all_ids()), set(['0123']))
         self.assertEqual(self.pdb.get('0123'), 'Overriding_Platform')
@@ -231,10 +235,12 @@ def setUp(self):
         self.mocked_lock = patch('mbed_lstools.platform_database.InterProcessLock', spec=True).start()
         self.acquire = self.mocked_lock.return_value.acquire
         self.release = self.mocked_lock.return_value.release
-        self.base_db = tempfile.NamedTemporaryFile(prefix='base')
+
+        self.base_db_path = os.path.join(tempfile.mkdtemp(), 'base')
+        self.base_db = open(self.base_db_path, 'w+')
         self.base_db.write(b'{}')
         self.base_db.seek(0)
-        self.pdb = PlatformDatabase([self.base_db.name])
+        self.pdb = PlatformDatabase([self.base_db_path])
         self.addCleanup(patch.stopall)
 
     def tearDown(self):