Skip to content

Commit c4db6bc

Browse files
Merge pull request #377 from bridadan/linux_vid_pid_detection_fix
Linux vid pid detection fix
2 parents 9501283 + 07597b3 commit c4db6bc

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

mbed_lstools/linux.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ def __init__(self, **kwargs):
4747
r'(pci|usb)-[0-9a-zA-Z_-]*_(?P<usbid>[0-9a-zA-Z]*)-.*$')
4848
self.mmp = re.compile(
4949
r'(?P<dev>(/[^/ ]*)+) on (?P<dir>(/[^/ ]*)+) ')
50-
self.udp = re.compile(r'[0-9]+-[0-9]+')
50+
self.udp = re.compile(r'^[0-9]+-[0-9]+[^:\s]*$')
5151

5252
def find_candidates(self):
5353
disk_ids = self._dev_by_id('disk')
@@ -126,7 +126,6 @@ def _sysfs_block_devices(self, block_devices):
126126
for index, part in enumerate(path_parts):
127127
if self.udp.search(part):
128128
end_index = index
129-
break
130129

131130
if end_index == None:
132131
logger.debug('Did not find suitable usb folder for usb info: %s', full_sysfs_path)

test/os_linux_generic.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ def do_abspath(dir):
142142
'sdf',
143143
'sdg'
144144
],
145-
'/sys/class/block/../../devices/pci0000:00/0000:00:06.0/usb1/1-2': [
145+
'/sys/class/block/../../devices/pci0000:00/0000:00:06.0/usb1/1-1/1-1.2/1-1.2.6': [
146146
'idVendor',
147147
'idProduct'
148148
],
@@ -169,8 +169,8 @@ def do_abspath(dir):
169169
}
170170

171171
open_dict_rpi = {
172-
'/sys/class/block/../../devices/pci0000:00/0000:00:06.0/usb1/1-2/idVendor': '0d28\n',
173-
'/sys/class/block/../../devices/pci0000:00/0000:00:06.0/usb1/1-2/idProduct': '0204\n',
172+
'/sys/class/block/../../devices/pci0000:00/0000:00:06.0/usb1/1-1/1-1.2/1-1.2.6/idVendor': '0d28\n',
173+
'/sys/class/block/../../devices/pci0000:00/0000:00:06.0/usb1/1-1/1-1.2/1-1.2.6/idProduct': '0204\n',
174174
'/sys/class/block/../../devices/pci0000:00/0000:00:06.0/usb1/1-3/idVendor': '0d28\n',
175175
'/sys/class/block/../../devices/pci0000:00/0000:00:06.0/usb1/1-3/idProduct': '0204\n',
176176
'/sys/class/block/../../devices/pci0000:00/0000:00:06.0/usb1/1-4/idVendor': '0d28\n',
@@ -194,7 +194,7 @@ def do_abspath(dir):
194194
'/dev/serial/by-id/usb-ARM_DAPLink_CMSIS-DAP_0240000028884e450018700f6bf000338021000097969900-if01': '../../ttyACM1',
195195
'/dev/serial/by-id/usb-ARM_DAPLink_CMSIS-DAP_0240000028884e450036700f6bf000118021000097969900-if01': '../../ttyACM3',
196196
'/dev/serial/by-id/usb-ARM_DAPLink_CMSIS-DAP_0240000029164e45001b0012706e000df301000097969900-if01': '../../ttyACM2',
197-
'/sys/class/block/sdb': '../../devices/pci0000:00/0000:00:06.0/usb1/1-2/1-2:1.0/host3/target3:0:0/3:0:0:0/block/sdb',
197+
'/sys/class/block/sdb': '../../devices/pci0000:00/0000:00:06.0/usb1/1-1/1-1.2/1-1.2.6/1-1.2.6:1.0/host8568/target8568:0:0/8568:0:0:0/block/sdb',
198198
'/sys/class/block/sdc': '../../devices/pci0000:00/0000:00:06.0/usb1/1-3/1-3:1.0/host4/target4:0:0/4:0:0:0/block/sdc',
199199
'/sys/class/block/sdd': '../../devices/pci0000:00/0000:00:06.0/usb1/1-4/1-4:1.0/host5/target5:0:0/5:0:0:0/block/sdd',
200200
'/sys/class/block/sde': '../../devices/pci0000:00/0000:00:06.0/usb1/1-5/1-5:1.0/host6/target6:0:0/6:0:0:0/block/sde',

0 commit comments

Comments
 (0)