Add ARM_MUSCA_A1 target #404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds ARM_MUSCA_A1 Cortex-M33 based target with 5006 ID. Signed-off-by: Gabor Kertesz <[email protected]>
|
@bridadan , @theotherjimmy , @deepikabhavnani : Could you please review? Thanks. |
bridadan
suggested changes
Nov 26, 2018
|
@bridadan : This should be fixed now. Could you please re-check? Also, there is an identical A1 and A2 ..so just to differentiate, we kept the slug and name identical but changed the target name for the compiler.. hope this helps? |
bridadan
approved these changes
Nov 26, 2018
There was a problem hiding this comment.
Also, there is an identical A1 and A2 ..so just to differentiate, we kept the slug and name identical but changed the target name for the compiler.
Ok, it's really up to you. I find that a little confusing but I'm not that familiar with the Musca board. The main thing is the name needs to match with the target name inside of Mbed OS.
deepikabhavnani
approved these changes
Nov 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds ARM_MUSCA_A1 Cortex-M33 based target with 5006 ID.
mbed-os pull request adding this new platform:
ARMmbed/mbed-os#8845