You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: docs/reference/contributing/guidelines/workflow.md
+3-4Lines changed: 3 additions & 4 deletions
Original file line number
Diff line number
Diff line change
@@ -48,7 +48,7 @@ Pull requests on GitHub have to meet the following requirements to keep the code
48
48
- Commits should always contain a proper description of their content. Start with a concise and sensible one-line description. Then, elaborate on reasoning of the choices made, descriptions for reviewers and other information that might otherwise be lost.
49
49
- You should always write commits to allow publication, so they can never contain confidential information, reference private documents, links to intranet locations or rude language.
50
50
- Each commit should be the minimum self-contained commit for a change. A commit should always result in a new state that is again in a compilable state. You should (if possible) split large changes into logical smaller commits that help reviewers follow the reasoning behind the full change.
51
-
- Commits and pull request title should follow [Chris Beam’s seven rules of great commit messages](http://chris.beams.io/posts/git-commit#seven-rules):
51
+
- Commits and pull request titles should follow [Chris Beam’s seven rules of great commit messages](http://chris.beams.io/posts/git-commit#seven-rules):
52
52
1. Separate subject from body with a blank line.
53
53
1. Limit the subject line to 72 characters (note that this is a deviation from Beam's standard).
54
54
1. Capitalize the subject line.
@@ -93,8 +93,7 @@ Each pull request goes through the following workflow:
93
93
94
94
The Mbed OS maintainers add labels to a pull request that represent the pull request workflow states. The Mbed OS maintainers are responsible for moving pull requests through the workflow states.
95
95
96
-
Each state is time boxed. In most cases, this is sufficient time to move to an another state. The pull request can be closed if no update
97
-
is provided within the time frame.
96
+
Each state is time boxed. In most cases, this is sufficient time to move to an another state. The pull request can be closed if no update is provided within the time frame.
98
97
99
98
##### Reviews
100
99
@@ -116,7 +115,7 @@ Time: 3 days for the pull request author to respond to the review comments.
116
115
117
116
##### Releases
118
117
119
-
When we merge a pull request that will be published in a patch release, we tag the pull request with specific patch release version. This is the release in which we first publish this pull request. For patch releases, we allow only bug fixes, new targets and enhancements to existing functionality. New features only go to feature releases.
118
+
When we merge a pull request that we will publish in a patch release, we tag the pull request with specific patch release version. This is the release in which we first publish this pull request. For patch releases, we allow only bug fixes, new targets and enhancements to existing functionality. New features only go to feature releases.
0 commit comments