Skip to content

Commit 5e3ce2e

Browse files
committed
Workflow: language fixes
1 parent 2d2e4eb commit 5e3ce2e

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

docs/reference/contributing/guidelines/workflow.md

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,7 @@
22

33
All code changes and additions to Mbed OS are handled through GitHub. If you want to contribute, either by adding features or by fixing bugs, please follow the guidelines for [new features](#features) and [bugs](#reporting-bugs). In both cases, please follow the [code style guide and GitHub pull request guidelines](/docs/v5.7/reference/guidelines.html#style). Please also read the [Contributor License Agreement (CLA)](/docs/v5.7/reference/guidelines.html#cla) guidelines because we will immediately close pull requests submitted without a CLA.
44

5-
#### Gatekeepers
6-
7-
##### Mbed OS maintainers
5+
#### Mbed OS maintainers
86

97
The maintainers are a small group of Mbed OS engineers who are responsible for the Mbed OS codebase. Their primary role is to progress contributions, both internal and external, from the initial pull request state through to released code.
108

@@ -93,7 +91,7 @@ Each pull request goes through the following workflow:
9391

9492
The Mbed OS maintainers add labels to a pull request that represent the pull request workflow states. The Mbed OS maintainers are responsible for moving pull requests through the workflow states.
9593

96-
Each state is time boxed. In most cases, this is sufficient time to move to an another state. The pull request can be closed if no update is provided within the time frame.
94+
Each state is time boxed. In most cases, this is sufficient time to move to another state. The pull request can be closed if no update is provided within the time frame.
9795

9896
##### Reviews
9997

@@ -109,13 +107,13 @@ Time: 1 day for CI to complete and report back results.
109107

110108
##### Work needed
111109

112-
A pull request in the work needed state requires additional work due to failed tests. If a pull request is in this state, our maintainers request changes from the pull request author.
110+
A pull request in the work needed state requires additional work due to failed tests or rework as a result of the review. If a pull request is in this state, our maintainers request changes from the pull request author.
113111

114-
Time: 3 days for the pull request author to respond to the review comments.
112+
Time: 3 days for the pull request author to action to the review comments.
115113

116114
##### Releases
117115

118-
When we merge a pull request that we will publish in a patch release, we tag the pull request with specific patch release version. This is the release in which we first publish this pull request. For patch releases, we allow only bug fixes, new targets and enhancements to existing functionality. New features only go to feature releases.
116+
When we merge a pull request that we will publish in a patch release, we tag the pull request with the specific patch release version. This is the release in which we first publish this pull request. For patch releases, we allow only bug fixes, new targets and enhancements to existing functionality. New features only go to feature releases.
119117

120118
The release tag has the following format:
121119

0 commit comments

Comments
 (0)