Skip to content

Commit 648ba0a

Browse files
author
Amanda Butler
authored
Edit Reviews section of workflow.md
Edit section for active voice, branding and consistent spelling out of symbols.
1 parent f8c2114 commit 648ba0a

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

docs/reference/contributing/guidelines/workflow.md

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -170,12 +170,9 @@ If a pull request is idle for more than two weeks, it will be closed. The author
170170

171171
#### Reviews
172172

173-
All pull requests must be reviewed. The Arm Mbed CI bot determines the most suitable person to review the pull request (based on the files changed) and tags that person accordingly. Specific reviewers can be requested by the author by @ tagging those people/teams in the 'Reviewers' section of the pull request template.
174-
E.g.
175-
Reviewers
176-
@personA @TeamB
173+
All pull requests must be reviewed. The Arm Mbed CI bot determines the most suitable person to review the pull request (based on the files changed) and tags that person accordingly. Specific, a PR creator can request reviewers by @ tagging people or teams in the *Reviewers* section of the pull request template. For example, @personA @TeamB.
177174

178-
Github dismisses a reviewer's status after any change to the pull request commit history (such as adding a new commit or rebasing). Smaller changes, such as documentation edits or rebases on top of latest master, only require additional review by maintainers. Their approval is sufficient because a team assigned as a reviewer already approved the pull request.
175+
GitHub dismisses a reviewer's status after any change to the pull request commit history (such as adding a new commit or rebasing). Smaller changes, such as documentation edits or rebases on top of latest master, only require additional review by maintainers. Their approval is sufficient because a team assigned as a reviewer already approved the pull request.
179176

180177
Label: `needs: review`
181178
Time: 3 days for reviewers to leave feedback after the maintainers add the "needs: review" label.

0 commit comments

Comments
 (0)