Skip to content

Commit 90c5be2

Browse files
author
Amanda Butler
authored
Merge pull request #743 from 0xc0170/fix_labels
Add labels to PR stages
2 parents 7f050b3 + 2871d7f commit 90c5be2

File tree

1 file changed

+11
-1
lines changed

1 file changed

+11
-1
lines changed

docs/reference/contributing/guidelines/workflow.md

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,20 +167,30 @@ All pull requests must be reviewed. The Arm Mbed CI bot determines the most suit
167167

168168
Github dismisses a reviewer's status after any change to the pull request commit history (such as adding a new commit or rebasing). Smaller changes, such as documentation edits or rebases on top of latest master, only require additional review by maintainers. Their approval is sufficient because a team assigned as a reviewer already approved the pull request.
169169

170+
Label: `needs: CI`
170171
Time: 3 days for reviewers to leave feedback after the maintainers add the "needs: review" label.
171172

172173
#### The CI (Continuous Integration) testing
173174

174175
There are many CI systems available. Which CI tests we run against a particular pull request depends on the effect that pull request has on the code base. Irrespective of which CI tests run, Mbed OS has an all green policy, meaning that all the CI jobs that are triggered must pass before we merge the pull request.
175176

177+
Label: `needs: review`
176178
Time: 1 day for CI to complete and report back results.
177179

178180
#### Work needed
179181

180182
A pull request in the work needed state requires additional work due to failed tests, or rework as a result of the review. If a pull request is in this state, then our maintainers request changes from the pull request author.
181183

184+
Label: `needs: work`
182185
Time: 3 days for the pull request author to action the review comments.
183186

187+
#### Ready for integration
188+
189+
Maintainers merge pull requests during the internal gatekeeping meetings that occur three times a week. They can merge straightforward pull requests immediately.
190+
191+
Label: `Ready for merge`
192+
Time: 2 days
193+
184194
#### Releases
185195

186196
When we merge a pull request that we will publish in a patch release, we tag the pull request with the specific patch release version. This is the release in which we first publish this pull request. For patch releases, we allow only bug fixes, new targets and enhancements to existing functionality. New features only go in feature releases.
@@ -196,7 +206,7 @@ We use many other labels to summarize the scope and effect of the changes.
196206
- *needs: preceding PR* - This pull request cannot yet be merged because it has a dependency on another pull request that needs to merge first.
197207
- *DO NOT MERGE* - This pull request contains changes that may be in a draft state and submitted purely for review, or may contain breaking changes that have not been considered.
198208
- *devices: 'name'* - The pull request specifically affects the named device(s).
199-
- *component: 'name'* - The pull request specifically affects the named component.
209+
- *component: 'name'* - The pull request specifically affects the named component. Component names follow the structure of Mbed OS (`ble`, `storage`, `tls` and so on).
200210

201211
The following labels summarize the scope of the pull request.
202212

0 commit comments

Comments
 (0)