Skip to content

Commit d9580c4

Browse files
author
Janne Kiiskilä
committed
PR template additions
Board PRs require a few more checks. + Changes from review comments (see original PR). - Add link to TESTS-folder - Mbed Enabled in capitals + link - Add line changes. - GitHub shows the content otherwise very strangely. - Re-order, line also after board enablements. - PR review changes per feedback from Pekka Niskanen - Add notes on issues to Mbed OS & Client - Maintainers update the hashes, but in order to get the issues fixed in the 1st place -> issues need to get reported.
1 parent d339ea2 commit d9580c4

File tree

1 file changed

+21
-9
lines changed

1 file changed

+21
-9
lines changed

.github/pull_request_template.md

Lines changed: 21 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,3 @@
1-
<!--
2-
3-
For more information on the requirements for pull requests, please see [the CONTRIBUTING.md](CONTRIBUTING.md).
4-
5-
-->
6-
7-
[] I confirm this contribution is my own and I agree to license it with Apache 2.0.
8-
[] I confirm the moderators may change the PR before merging it in.
9-
101
### Summary of changes <!-- Required -->
112

123
<!--
@@ -21,3 +12,24 @@ For more information on the requirements for pull requests, please see [the CONT
2112
Write good, descriptive Git commit messages.
2213
2314
-->
15+
16+
<!--
17+
18+
For more information on the requirements for pull requests, please see [the CONTRIBUTING.md](CONTRIBUTING.md).
19+
20+
-->
21+
22+
[] I confirm this contribution is my own and I agree to license it with Apache 2.0.
23+
24+
[] I confirm the moderators may change the PR before merging it in.
25+
26+
For new board enablements only:
27+
28+
[] I confirm the board is [Mbed Enabled](https://www.mbed.com/en/about-mbed/mbed-enabled/introduction/) and passes the Mbed Enabled test set.
29+
30+
[] I confirm the contribution has been tested properly and the tests results for [TESTS](https://github.com/ARMmbed/mbed-os-example-pelion/tree/master/TESTS) are attached.
31+
32+
[] I confirm `mbed-os.lib` and `mbed-cloud-client.lib` hashes or the content in folders `mbed-os` and `mbed-cloud-client` were not modified in order to pass the tests.
33+
34+
- Maintainers of this repository update the Mbed OS and Client hashes.
35+
- Please report any issues through issues in relevant repositories.

0 commit comments

Comments
 (0)