Skip to content

Add Cypress kits to platform database #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2019
Merged

Add Cypress kits to platform database #110

merged 2 commits into from
Jan 23, 2019

Conversation

vmedcy
Copy link
Contributor

@vmedcy vmedcy commented Jan 22, 2019

Description

Add Cypress PSoC6 kits to the platform database. The Board IDs are as assigned by @maclobdell

The corresponding change to mbed-os targets is ongoing (functional testing in progress).

Pull request type

[ ] Fix
[ ] Refactor
[X] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@maclobdell

u'1903': u'CY8CPROTO_062_43012',
u'1904': u'CY8CPROTO_063_BLE',
u'1905': u'CY8CKIT_062_4343W',
u'1906': u'CYW943012P6EVB_01',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ids all accounted for! One little oddity: I noticed the following platforms have slightly different names in the database, just wondering if that was intentional:

  • CY8CPROTO_062_43012 - CYPROTO-062-43012 (does not have the 8C part after CY)
  • CY8CPROTO_063_BLE - CYPROTO-063-BLE (does not have the 8C part after CY)
  • CY8CKIT_062_4343W - CY8CKIT-062-WiFi-BT-F (quite a different suffix)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bridadan: the names in this PR are correct, the update was sent to Mac today.

@maclobdell: can you confirm once the internal board database is updated?

All Cypress boards follow the consistent naming convention:

CY8CKIT - Pioneer Kit (with Arduino headers)
CY8CPROTO - Prototyping Kit (low-cost baseboard with connectivity module)
CY8CMOD - Connectivity module

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying. Once the database is updated we can get this merged! It's mostly just for our own record keeping, but I'd like to keep them consistent.

Copy link
Contributor

@bridadan bridadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ids updated in the database, thanks!

@bridadan bridadan merged commit f622535 into ARMmbed:master Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants