Rename M2351 platform name to 'NU_PFM_M2351' from 'NUMAKER_PFM_M2351' #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally its name is 'NUMAKER_PFM_M2351'. After adding suffix to distinguish PSA/non-PSA targets, it will have pattern below which exceeds max 20 chars limited by online database: 'NUMAKER_PFM_M2351'+'_'+['PSA', 'NOPSA']+'_'+['S', 'NS'] To fix the issue, the M2351 platform name is changed to 'NU_PFM_M2351'. Then it will have pattern below for PSA/non-PSA targets, which fit in max 20 chars limit: 'NU_PFM_M2351'+'_'+['P', 'NP']+'_'+['S', 'NS']
|
@ccli8 Assuming the related PR gets in 5.14.0, this should be integrated with it (asap) ? |
Yes. |
|
@mark-edgeworth I agree and I'll make the changes once we release 5.14.0, if that's ok? |
mark-edgeworth
approved these changes
Sep 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Originally its name is NUMAKER_PFM_M2351. After adding suffix to distinguish PSA/non-PSA targets, it will have pattern below which exceeds max 20 chars limited by online database:
To fix the issue, the M2351 platform name is changed to NU_PFM_M2351. Then it will have pattern below for PSA/non-PSA targets, which fit in max 20 chars limit:
Related PR
ARMmbed/mbed-os#11288
Pull request type
Reviewers
@MarceloSalazar @mark-edgeworth