TF-M patch: Fix wrong check in tfm_spm_check_client_version (TF-M issue #236)

Michael Schwarcz · Michael Schwarcz · commit 008bf1b2d176 · 2019-02-19T15:19:00.000+02:00
- Link to bug tracking: https://developer.trustedfirmware.org/T236
diff --git a/components/TARGET_PSA/TARGET_TFM/COMPONENT_SPE/secure_fw/core/ipc/tfm_spm.c b/components/TARGET_PSA/TARGET_TFM/COMPONENT_SPE/secure_fw/core/ipc/tfm_spm.c
@@ -272,7 +272,7 @@ int32_t tfm_spm_check_client_version(struct tfm_spm_service_t *service,
 
     switch (service->service_db->minor_policy) {
     case TFM_VERSION_POLICY_RELAXED:
-        if (minor_version < service->service_db->minor_version) {
+        if (minor_version > service->service_db->minor_version) {
             return IPC_ERROR_VERSION;
         }
         break;

Original file line number	Diff line number	Diff line change
`@@ -272,7 +272,7 @@ int32_t tfm_spm_check_client_version(struct tfm_spm_service_t *service,`
`272`	`272`
`273`	`273`	`switch (service->service_db->minor_policy) {`
`274`	`274`	`case TFM_VERSION_POLICY_RELAXED:`
`275`		`- if (minor_version < service->service_db->minor_version) {`
	`275`	`+ if (minor_version > service->service_db->minor_version) {`
`276`	`276`	`return IPC_ERROR_VERSION;`
`277`	`277`	`}`
`278`	`278`	`break;`