Coverity fixes

Author: Oren Cohen

TESTS/spm/client_tests/server.c

@@ -35,10 +35,9 @@ void server_main(void *ptr)
                 case PSA_IPC_MSG_TYPE_CALL: {
                     memset(data, 0, sizeof(data));
                     if (msg.in_size[0] + msg.in_size[1] + msg.in_size[2] > 1) {
-                        size_t offset = 0;
-                        offset += psa_read(msg.handle, 0, (void*)data, msg.in_size[0]);
+                        size_t offset = psa_read(msg.handle, 0, (void*)data, msg.in_size[0]);
                         offset += psa_read(msg.handle, 1, (void*)(data + offset), msg.in_size[1]);
-                        offset += psa_read(msg.handle, 2, (void*)(data + offset), msg.in_size[2]);
+                        psa_read(msg.handle, 2, (void*)(data + offset), msg.in_size[2]);
                     }
                     if (msg.out_size[0] > 0) {
                         uint8_t resp_size = data[0];

TESTS/spm/server/partition2.c

@@ -73,11 +73,9 @@ void part2_main(void *ptr)
             psa_get(SF_DB_TST_MSK, &msg);
 
             switch (msg.type) {
-
-                int32_t caller_part_id = 0;
-
                 case PSA_IPC_MSG_TYPE_CALL:
-                    caller_part_id = psa_identity(msg.handle);
+                {
+                    int32_t caller_part_id = psa_identity(msg.handle);
                     // Doorbell contract is valid only between secure partitions
                     if (PSA_NSPE_IDENTIFIER == caller_part_id) {
                         SPM_PANIC("Caller partition is non secure\n");
@@ -89,6 +87,7 @@ void part2_main(void *ptr)
                     // After work is done, ring the doorbell
                     psa_notify(caller_part_id);
                     break;
+                }
 
                 case PSA_IPC_MSG_TYPE_DISCONNECT:
                 case PSA_IPC_MSG_TYPE_CONNECT:

TESTS/spm/server/tests.c

@@ -236,10 +236,14 @@ PSA_TEST_SERVER(msg_size_assertion)
     size_t read_size = 0;
 
     char *buff = malloc(sizeof(char) * 11);
+    if (NULL == buff) {
+        SPM_PANIC("memory allocation failure\n");
+    }
     memset(buff, 0, 11);
 
     test_status = proccess_connect_request();
     if (test_status != PSA_SUCCESS) {
+        free(buff);
         return test_status;
     }
 
@@ -335,10 +339,14 @@ PSA_TEST_SERVER(msg_read_truncation)
     uint32_t signals = 0;
     size_t read_size = 0;
     char *buff = malloc(sizeof(char) * 11);
+    if (NULL == buff) {
+        SPM_PANIC("memory allocation failure\n");
+    }
     memset(buff, 0, 11);
 
     test_status = proccess_connect_request();
     if (test_status != PSA_SUCCESS) {
+        free(buff);
         return test_status;
     }
 
@@ -378,9 +386,13 @@ PSA_TEST_SERVER(skip_zero)
     size_t read_size = 0;
     size_t skip_size = 0;
     char *buff = malloc(sizeof(char) * 11);
+    if (NULL == buff) {
+        SPM_PANIC("memory allocation failure\n");
+    }
 
     test_status = proccess_connect_request();
     if (test_status != PSA_SUCCESS) {
+        free(buff);
         return test_status;
     }
 
@@ -421,9 +433,13 @@ PSA_TEST_SERVER(skip_some)
     size_t read_size2 = 0;
     size_t skip_size = 0;
     char *buff = malloc(sizeof(char) * 11);
+    if (NULL == buff) {
+        SPM_PANIC("memory allocation failure\n");
+    }
 
     test_status = proccess_connect_request();
     if (test_status != PSA_SUCCESS) {
+        free(buff);
         return test_status;
     }
 
@@ -466,9 +482,13 @@ PSA_TEST_SERVER(skip_more_than_left)
     size_t read_size2 = 0;
     size_t skip_size = 0;
     char *buff = malloc(sizeof(char) * 8);
+    if (NULL == buff) {
+        SPM_PANIC("memory allocation failure\n");
+    }
 
     test_status = proccess_connect_request();
     if (test_status != PSA_SUCCESS) {
+        free(buff);
         return test_status;
     }
 
@@ -596,12 +616,18 @@ PSA_TEST_SERVER(cross_partition_call)
     psa_error_t disconnect_status = PSA_SUCCESS;
     psa_error_t partition_call_status = PSA_SUCCESS;
     uint32_t data_read = 0;
-    char *buff = malloc(sizeof(char) * 60);
     uint32_t str_len = 0;
+    char *buff = malloc(sizeof(char) * 60);
+
+    if (NULL == buff) {
+        SPM_PANIC("memory allocation failure\n");
+    }
+
     memset(buff, 0, 60);
 
     test_status = proccess_connect_request();
     if (test_status != PSA_SUCCESS) {
+        free(buff);
         return test_status;
     }
 

TESTS/spm/smoke/partition1.c

@@ -49,6 +49,9 @@ void part1_main(void *ptr)
                 MBED_ASSERT(msg.out_size[0] == SERVER_RSP_BUF_SIZE);
                 uint32_t bytes_read = 0;
                 char *read_msg_buf = malloc(sizeof(char) * SERVER_READ_MSG_BUF_SIZE);
+                if (NULL == read_msg_buf) {
+                    error("Failed to allocate Memory");
+                }
                 memset(read_msg_buf, 0, SERVER_READ_MSG_BUF_SIZE);
                 char *read_ptr = read_msg_buf;