Skip to content

Commit 0874ccc

Browse files
committed
kwargs check in iar and comments
1 parent afa4b33 commit 0874ccc

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

tools/build_test.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,13 @@
1313

1414
class BuildTest():
1515
def __init__(self, desired_ides, tests, targets):
16+
#map of targets and the ides that can build programs for them
1617
self.target_ides = {}
1718
for target in targets:
1819
self.target_ides[target] =[]
1920
for ide in desired_ides:
2021
if target in EXPORTERS[ide].TARGETS:
22+
#target is supported by ide
2123
self.target_ides[target].append(ide)
2224
if len(self.target_ides[target]) == 0:
2325
del self.target_ides[target]
@@ -27,6 +29,7 @@ def __init__(self, desired_ides, tests, targets):
2729

2830
@staticmethod
2931
def get_pgen_targets(ides):
32+
#targets supported by pgen and desired ides for tests
3033
targs = []
3134
for ide in ides:
3235
for target in TARGET_NAMES:
@@ -36,10 +39,12 @@ def get_pgen_targets(ides):
3639
return targs
3740

3841
def _generate_and_build(self, tests):
42+
#build results
3943
successes = []
4044
failures = []
4145
for mcu, ides in self.target_ides.items():
4246
for test in tests:
47+
#resolve name alias
4348
test = get_test_from_name(test)
4449
for ide in ides:
4550
project_dir, project_name, project_temp = setup_project(mcu, ide, test)
@@ -78,8 +83,8 @@ def _generate_and_build(self, tests):
7883
options = parser.parse_args()
7984

8085
tests = options.tests
81-
ides = options.ides
82-
targets = options.targets
86+
ides = [ide.lower() for ide in options.ides]
87+
targets = [target.upper() for target in options.targets]
8388

8489
if any(get_test_from_name(test) is None for test in tests):
8590
args_error(parser, "[ERROR] test name not recognized")

tools/export/iar.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ def generate(self, **kwargs):
7575
# VLA is enabled via template IccAllowVLA
7676
project_data['tool_specific']['iar']['misc']['c_flags'].remove("--vla")
7777
project_data['common']['build_dir'] = os.path.join(project_data['common']['build_dir'], 'iar_arm')
78-
if 'progen_build' in kwargs:
78+
if 'progen_build' in kwargs and kwargs.get('progen_build') == True:
7979
self.progen_gen_file('iar_arm', project_data, True)
8080
else:
8181
self.progen_gen_file('iar_arm', project_data)

0 commit comments

Comments
 (0)