Fixing coverity findings

Hasnain Virk · Hasnain Virk · commit 0a9417299b5d · 2018-10-16T12:23:21.000+03:00
A couple of the coverity analysis findings are being treated here. For
the rest there will be a separate PR.
diff --git a/features/lorawan/lorastack/mac/LoRaMac.cpp b/features/lorawan/lorastack/mac/LoRaMac.cpp
@@ -1856,7 +1856,6 @@ uint8_t LoRaMac::get_max_possible_tx_size(uint8_t fopts_len)
         max_possible_payload_size = allowed_frm_payload_size - fopts_len;
     } else {
         max_possible_payload_size = allowed_frm_payload_size;
-        fopts_len = 0;
         _mac_commands.clear_command_buffer();
         _mac_commands.clear_repeat_buffer();
     }
diff --git a/features/lorawan/lorastack/phy/LoRaPHY.cpp b/features/lorawan/lorastack/phy/LoRaPHY.cpp
@@ -36,7 +36,8 @@ SPDX-License-Identifier: BSD-3-Clause
 #define CHANNELS_IN_MASK  16
 
 LoRaPHY::LoRaPHY()
-    : _radio(NULL)
+    : _radio(NULL),
+      _lora_time(NULL)
 {
     memset(&phy_params, 0, sizeof(phy_params));
 }

Original file line number	Diff line number	Diff line change
`@@ -1856,7 +1856,6 @@ uint8_t LoRaMac::get_max_possible_tx_size(uint8_t fopts_len)`
`1856`	`1856`	`max_possible_payload_size = allowed_frm_payload_size - fopts_len;`
`1857`	`1857`	`} else {`
`1858`	`1858`	`max_possible_payload_size = allowed_frm_payload_size;`
`1859`		`- fopts_len = 0;`
`1860`	`1859`	`_mac_commands.clear_command_buffer();`
`1861`	`1860`	`_mac_commands.clear_repeat_buffer();`
`1862`	`1861`	`}`
Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,8 @@ SPDX-License-Identifier: BSD-3-Clause`
`36`	`36`	`#define CHANNELS_IN_MASK 16`
`37`	`37`
`38`	`38`	`LoRaPHY::LoRaPHY()`
`39`		`- : _radio(NULL)`
	`39`	`+ : _radio(NULL),`
	`40`	`+ _lora_time(NULL)`
`40`	`41`	`{`
`41`	`42`	`memset(&phy_params, 0, sizeof(phy_params));`
`42`	`43`	`}`