Skip to content

Commit 1bfc809

Browse files
committed
Refactor to remove setdefault calls
1 parent 18cf143 commit 1bfc809

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

tools/memap.py

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -554,7 +554,7 @@ def _move_up_tree(tree, next_module):
554554
if child["name"] == next_module:
555555
return child
556556
else:
557-
new_module = {"name": next_module}
557+
new_module = {"name": next_module, "value": 0}
558558
tree["children"].append(new_module)
559559
return new_module
560560

@@ -564,18 +564,15 @@ def generate_html(self, file_desc):
564564
Positional arguments:
565565
file_desc - the file to write out the final report to
566566
"""
567-
tree_text = {"name": ".text"}
568-
tree_bss = {"name": ".bss"}
569-
tree_data = {"name": ".data"}
567+
tree_text = {"name": ".text", "value": 0}
568+
tree_bss = {"name": ".bss", "value": 0}
569+
tree_data = {"name": ".data", "value": 0}
570570
for name, dct in self.modules.items():
571571
cur_text = tree_text
572572
cur_bss = tree_bss
573573
cur_data = tree_data
574574
modules = name.split(sep)
575575
while True:
576-
cur_text.setdefault("value", 0)
577-
cur_data.setdefault("value", 0)
578-
cur_bss.setdefault("value", 0)
579576
try:
580577
cur_text["value"] += dct['.text']
581578
except KeyError:

0 commit comments

Comments
 (0)