[Nuvoton] Fix IP initialization sequence

Better IP initialization sequence:
1. Configure IP pins
2. Select IP clock source and then enable it
3. Reset the IP (SYS_ResetModule)

NOTE1: IP reset takes effect regardless of IP clock. So it doesn't matter if
       IP clock enable is before IP reset.
NOTE2: Non-configured pins may disturb IP's state, so IP pinout first and then
       IP reset.
NOTE3: IP reset at the end of IP initialization sequence can cover unexpected
       situation.

Author: ccli8

targets/TARGET_NUVOTON/TARGET_M2351/analogin_api.c

@@ -53,37 +53,37 @@ void analogin_init(analogin_t *obj, PinName pin)
     MBED_ASSERT(modinit != NULL);
     MBED_ASSERT(modinit->modname == (int) obj->adc);
 
+    // Wire pinout
+    pinmap_pinout(pin, PinMap_ADC);
+
     EADC_T *eadc_base = (EADC_T *) NU_MODBASE(obj->adc);
 
     // NOTE: All channels (identified by ADCName) share a ADC module. This reset will also affect other channels of the same ADC module.
     if (! eadc_modinit_mask) {
-        /* Reset module
-         *
-         * NOTE: We must call secure version (from non-secure domain) because SYS/CLK regions are secure.
-         */
-        SYS_ResetModule_S(modinit->rsetidx);
-
         /* Select IP clock source
          *
          * NOTE: We must call secure version (from non-secure domain) because SYS/CLK regions are secure.
          */
         CLK_SetModuleClock_S(modinit->clkidx, modinit->clksrc, modinit->clkdiv);
-        
+
         /* Enable IP clock
          *
          * NOTE: We must call secure version (from non-secure domain) because SYS/CLK regions are secure.
          */
         CLK_EnableModuleClock_S(modinit->clkidx);
 
+        /* Reset module
+         *
+         * NOTE: We must call secure version (from non-secure domain) because SYS/CLK regions are secure.
+         */
+        SYS_ResetModule_S(modinit->rsetidx);
+
         // Set the ADC internal sampling time, input mode as single-end and enable the A/D converter
         EADC_Open(eadc_base, EADC_CTL_DIFFEN_SINGLE_END);
     }
 
     uint32_t chn =  NU_MODSUBINDEX(obj->adc);
 
-    // Wire pinout
-    pinmap_pinout(pin, PinMap_ADC);
-
     // Configure the sample module Nmod for analog input channel Nch and software trigger source
     EADC_ConfigSampleModule(eadc_base, chn, EADC_SOFTWARE_TRIGGER, chn);
 

targets/TARGET_NUVOTON/TARGET_M2351/analogout_api.c

@@ -53,6 +53,9 @@ void analogout_init(dac_t *obj, PinName pin)
     uint32_t chn =  NU_MODSUBINDEX(obj->dac);
     MBED_ASSERT(chn < NU_DACCHN_MAXNUM);
 
+    /* Wire pinout */
+    pinmap_pinout(pin, PinMap_DAC);
+
     DAC_T *dac_base = (DAC_T *) NU_MODBASE(obj->dac);
 
     /* Module-level setup from here */
@@ -66,12 +69,6 @@ void analogout_init(dac_t *obj, PinName pin)
      *    channels are deactivated.
      */
     if ((! dac_modinit_mask[0]) && (! dac_modinit_mask[1])) {
-        /* Reset IP
-         *
-         * NOTE: We must call secure version (from non-secure domain) because SYS/CLK regions are secure.
-         */
-        SYS_ResetModule_S(modinit->rsetidx);
-        
         /* Select IP clock source and clock divider
          *
          * NOTE: We must call secure version (from non-secure domain) because SYS/CLK regions are secure.
@@ -83,7 +80,13 @@ void analogout_init(dac_t *obj, PinName pin)
          * NOTE: We must call secure version (from non-secure domain) because SYS/CLK regions are secure.
          */
         CLK_EnableModuleClock_S(modinit->clkidx);
-        
+
+        /* Reset IP
+         *
+         * NOTE: We must call secure version (from non-secure domain) because SYS/CLK regions are secure.
+         */
+        SYS_ResetModule_S(modinit->rsetidx);
+
         /* The conversion settling time is 8us when 12-bit input code transition from
          * lowest code (0x000) to highest code (0xFFF). */
         DAC_SetDelayTime(dac_base, 8);
@@ -98,8 +101,7 @@ void analogout_init(dac_t *obj, PinName pin)
     /* Set the software trigger, enable DAC event trigger mode and enable D/A converter */
     DAC_Open(dac_base, chn, DAC_SOFTWARE_TRIGGER);
 
-    /* Wire pinout */
-    pinmap_pinout(pin, PinMap_DAC);
+    
 
     /* Mark channel allocated */
     dac_modinit_mask[modidx] |= 1 << chn;

targets/TARGET_NUVOTON/TARGET_M2351/dma_api.c

@@ -69,17 +69,17 @@ void dma_init(void)
     dma_chn_mask = ~NU_PDMA_CH_Msk;
     memset(dma_chn_arr, 0x00, sizeof (dma_chn_arr));
 
-    /* Reset module
+    /* Enable IP clock
      *
      * NOTE: We must call secure version (from non-secure domain) because SYS/CLK regions are secure.
      */
-    SYS_ResetModule_S(dma_modinit.rsetidx);
+    CLK_EnableModuleClock_S(dma_modinit.clkidx);
 
-    /* Enable IP clock
+    /* Reset module
      *
      * NOTE: We must call secure version (from non-secure domain) because SYS/CLK regions are secure.
      */
-    CLK_EnableModuleClock_S(dma_modinit.clkidx);
+    SYS_ResetModule_S(dma_modinit.rsetidx);
 
     /* Check security state of PDMA0/1 match the partition policy above. */
     PDMA_T *pdma_base = dma_modbase();

targets/TARGET_NUVOTON/TARGET_M2351/i2c_api.c

@@ -102,20 +102,20 @@ void i2c_init(i2c_t *obj, PinName sda, PinName scl)
     MBED_ASSERT(modinit != NULL);
     MBED_ASSERT(modinit->modname == (int) obj->i2c.i2c);
 
-    /* Reset module
-     *
-     * NOTE: We must call secure version (from non-secure domain) because SYS/CLK regions are secure.
-     */
-    SYS_ResetModule_S(modinit->rsetidx);
+    pinmap_pinout(sda, PinMap_I2C_SDA);
+    pinmap_pinout(scl, PinMap_I2C_SCL);
 
     /* Select IP clock source
      *
      * NOTE: We must call secure version (from non-secure domain) because SYS/CLK regions are secure.
      */
     CLK_EnableModuleClock_S(modinit->clkidx);
 
-    pinmap_pinout(sda, PinMap_I2C_SDA);
-    pinmap_pinout(scl, PinMap_I2C_SCL);
+    /* Reset module
+     *
+     * NOTE: We must call secure version (from non-secure domain) because SYS/CLK regions are secure.
+     */
+    SYS_ResetModule_S(modinit->rsetidx);
 
 #if DEVICE_I2C_ASYNCH
     obj->i2c.dma_usage = DMA_USAGE_NEVER;

targets/TARGET_NUVOTON/TARGET_M2351/lp_ticker.c

@@ -105,12 +105,6 @@ void lp_ticker_init(void)
     }
     ticker_inited = 1;
 
-    /* Reset module
-     *
-     * NOTE: We must call secure version (from non-secure domain) because SYS/CLK regions are secure.
-     */
-    SYS_ResetModule_S(TIMER_MODINIT.rsetidx);
-
     /* Select IP clock source
      *
      * NOTE: We must call secure version (from non-secure domain) because SYS/CLK regions are secure.
@@ -123,6 +117,12 @@ void lp_ticker_init(void)
      */
     CLK_EnableModuleClock_S(TIMER_MODINIT.clkidx);
 
+    /* Reset module
+     *
+     * NOTE: We must call secure version (from non-secure domain) because SYS/CLK regions are secure.
+     */
+    SYS_ResetModule_S(TIMER_MODINIT.rsetidx);
+
     TIMER_T *timer_base = (TIMER_T *) NU_MODBASE(TIMER_MODINIT.modname);
 
     // Configure clock

targets/TARGET_NUVOTON/TARGET_M2351/pwmout_api.c

@@ -68,16 +68,8 @@ void pwmout_init(pwmout_t* obj, PinName pin)
     MBED_ASSERT(modinit != NULL);
     MBED_ASSERT(modinit->modname == (int) obj->pwm);
 
-    // NOTE: All channels (identified by PWMName) share a PWM module. This reset will also affect other channels of the same PWM module.
-    if (! ((struct nu_pwm_var *) modinit->var)->en_msk) {
-        /* Reset module
-         *
-         * NOTE: We must call secure version (from non-secure domain) because SYS/CLK regions are secure.
-         */
-        SYS_ResetModule_S(modinit->rsetidx);
-    }
-
-    uint32_t chn =  NU_MODSUBINDEX(obj->pwm);
+    // Wire pinout
+    pinmap_pinout(pin, PinMap_PWM);
 
     // NOTE: Channels 0/1/2/3/4/5 share a clock source.
     if ((((struct nu_pwm_var *) modinit->var)->en_msk & 0x3F) == 0) {
@@ -94,8 +86,16 @@ void pwmout_init(pwmout_t* obj, PinName pin)
         CLK_EnableModuleClock_S(modinit->clkidx);
     }
 
-    // Wire pinout
-    pinmap_pinout(pin, PinMap_PWM);
+    // NOTE: All channels (identified by PWMName) share a PWM module. This reset will also affect other channels of the same PWM module.
+    if (! ((struct nu_pwm_var *) modinit->var)->en_msk) {
+        /* Reset module
+         *
+         * NOTE: We must call secure version (from non-secure domain) because SYS/CLK regions are secure.
+         */
+        SYS_ResetModule_S(modinit->rsetidx);
+    }
+
+    uint32_t chn =  NU_MODSUBINDEX(obj->pwm);
 
     // Default: period = 10 ms, pulse width = 0 ms
     obj->period_us = 1000 * 10;

targets/TARGET_NUVOTON/TARGET_M2351/serial_api.c

@@ -200,11 +200,8 @@ void serial_init(serial_t *obj, PinName tx, PinName rx)
     struct nu_uart_var *var = (struct nu_uart_var *) modinit->var;
 
     if (! var->ref_cnt) {
-        /* Reset module
-         *
-         * NOTE: We must call secure version (from non-secure domain) because SYS/CLK regions are secure.
-         */
-        SYS_ResetModule_S(modinit->rsetidx);
+        pinmap_pinout(tx, PinMap_UART_TX);
+        pinmap_pinout(rx, PinMap_UART_RX);
 
         /* Select IP clock source
          *
@@ -218,8 +215,11 @@ void serial_init(serial_t *obj, PinName tx, PinName rx)
          */
         CLK_EnableModuleClock_S(modinit->clkidx);
 
-        pinmap_pinout(tx, PinMap_UART_TX);
-        pinmap_pinout(rx, PinMap_UART_RX);
+        /* Reset module
+         *
+         * NOTE: We must call secure version (from non-secure domain) because SYS/CLK regions are secure.
+         */
+        SYS_ResetModule_S(modinit->rsetidx);
 
         // Configure baudrate
         int baudrate = 9600;

targets/TARGET_NUVOTON/TARGET_M2351/spi_api.c

@@ -147,11 +147,10 @@ void spi_init(spi_t *obj, PinName mosi, PinName miso, PinName sclk, PinName ssel
     MBED_ASSERT(modinit != NULL);
     MBED_ASSERT(modinit->modname == (int) obj->spi.spi);
 
-    /* Reset module
-     *
-     * NOTE: We must call secure version (from non-secure domain) because SYS/CLK regions are secure.
-     */
-    SYS_ResetModule_S(modinit->rsetidx);
+    pinmap_pinout(mosi, PinMap_SPI_MOSI);
+    pinmap_pinout(miso, PinMap_SPI_MISO);
+    pinmap_pinout(sclk, PinMap_SPI_SCLK);
+    pinmap_pinout(ssel, PinMap_SPI_SSEL);
 
     /* Select IP clock source
      *
@@ -165,10 +164,11 @@ void spi_init(spi_t *obj, PinName mosi, PinName miso, PinName sclk, PinName ssel
      */
     CLK_EnableModuleClock_S(modinit->clkidx);
 
-    pinmap_pinout(mosi, PinMap_SPI_MOSI);
-    pinmap_pinout(miso, PinMap_SPI_MISO);
-    pinmap_pinout(sclk, PinMap_SPI_SCLK);
-    pinmap_pinout(ssel, PinMap_SPI_SSEL);
+    /* Reset module
+     *
+     * NOTE: We must call secure version (from non-secure domain) because SYS/CLK regions are secure.
+     */
+    SYS_ResetModule_S(modinit->rsetidx);
 
     obj->spi.pin_mosi = mosi;
     obj->spi.pin_miso = miso;

targets/TARGET_NUVOTON/TARGET_M2351/us_ticker.c

@@ -79,12 +79,6 @@ void us_ticker_init(void)
     }
     ticker_inited = 1;
 
-    /* Reset module
-     *
-     * NOTE: We must call secure version (from non-secure domain) because SYS/CLK regions are secure.
-     */
-    SYS_ResetModule_S(TIMER_MODINIT.rsetidx);
-
     /* Select IP clock source
      *
      * NOTE: We must call secure version (from non-secure domain) because SYS/CLK regions are secure.
@@ -97,6 +91,12 @@ void us_ticker_init(void)
      */
     CLK_EnableModuleClock_S(TIMER_MODINIT.clkidx);
 
+    /* Reset module
+     *
+     * NOTE: We must call secure version (from non-secure domain) because SYS/CLK regions are secure.
+     */
+    SYS_ResetModule_S(TIMER_MODINIT.rsetidx);
+
     TIMER_T *timer_base = (TIMER_T *) NU_MODBASE(TIMER_MODINIT.modname);
 
     // Timer for normal counter

targets/TARGET_NUVOTON/TARGET_M451/analogin_api.c

@@ -52,29 +52,30 @@ void analogin_init(analogin_t *obj, PinName pin)
     const struct nu_modinit_s *modinit = get_modinit(obj->adc, adc_modinit_tab);
     MBED_ASSERT(modinit != NULL);
     MBED_ASSERT(modinit->modname == obj->adc);
-    
+
+    // Wire pinout
+    pinmap_pinout(pin, PinMap_ADC);
+
     EADC_T *eadc_base = (EADC_T *) NU_MODBASE(obj->adc);
-    
+
     // NOTE: All channels (identified by ADCName) share a ADC module. This reset will also affect other channels of the same ADC module.
     if (! eadc_modinit_mask) {
-        // Reset this module if no channel enabled
-        SYS_ResetModule(modinit->rsetidx);
-        
         // Select clock source of paired channels
         CLK_SetModuleClock(modinit->clkidx, modinit->clksrc, modinit->clkdiv);
+
         // Enable clock of paired channels
         CLK_EnableModuleClock(modinit->clkidx);
-        
+
+        // Reset this module if no channel enabled
+        SYS_ResetModule(modinit->rsetidx);
+
         // Set the ADC internal sampling time, input mode as single-end and enable the A/D converter
         EADC_Open(eadc_base, EADC_CTL_DIFFEN_SINGLE_END);
         EADC_SetInternalSampleTime(eadc_base, 6);
     }
-    
+
     uint32_t chn =  NU_MODSUBINDEX(obj->adc);
-    
-    // Wire pinout
-    pinmap_pinout(pin, PinMap_ADC);
-    
+
     // Configure the sample module Nmod for analog input channel Nch and software trigger source
     EADC_ConfigSampleModule(eadc_base, chn, EADC_SOFTWARE_TRIGGER, chn);
 

targets/TARGET_NUVOTON/TARGET_M451/analogout_api.c

@@ -52,20 +52,22 @@ void analogout_init(dac_t *obj, PinName pin)
     uint32_t chn =  NU_MODSUBINDEX(obj->dac);
     MBED_ASSERT(chn < NU_DACCHN_MAXNUM);
 
+    /* Wire pinout */
+    pinmap_pinout(pin, PinMap_DAC);
+
     DAC_T *dac_base = (DAC_T *) NU_MODBASE(obj->dac);
 
     /* Module-level setup from here */
-
     if (! dac_modinit_mask[modidx]) {
-        /* Reset IP */
-        SYS_ResetModule(modinit->rsetidx);
-        
         /* Select IP clock source and clock divider */
         CLK_SetModuleClock(modinit->clkidx, modinit->clksrc, modinit->clkdiv);
 
         /* Enable IP clock */
         CLK_EnableModuleClock(modinit->clkidx);
-        
+
+        /* Reset IP */
+        SYS_ResetModule(modinit->rsetidx);
+
         /* The conversion settling time is 8us when 12-bit input code transition from
          * lowest code (0x000) to highest code (0xFFF). */
         DAC_SetDelayTime(dac_base, 8);
@@ -79,9 +81,6 @@ void analogout_init(dac_t *obj, PinName pin)
 
     /* Set the software trigger, enable DAC event trigger mode and enable D/A converter */
     DAC_Open(dac_base, chn, DAC_SOFTWARE_TRIGGER);
-        
-    /* Wire pinout */
-    pinmap_pinout(pin, PinMap_DAC);
 
     /* Mark channel allocated */
     dac_modinit_mask[modidx] |= 1 << chn;