Skip to content

Commit 3ad3a9f

Browse files
committed
Adding fatal error detection to toolchians.
Before the toolchains would ignore error messages that contained the string "Fatal error". This would lead to a silent failure unless the compile command was ran with verbose options. This is now fixed.
1 parent 15cd3da commit 3ad3a9f

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

tools/toolchains/arm.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ class ARM(mbedToolchain):
2626
LIBRARY_EXT = '.ar'
2727

2828
STD_LIB_NAME = "%s.ar"
29-
DIAGNOSTIC_PATTERN = re.compile('"(?P<file>[^"]+)", line (?P<line>\d+)( \(column (?P<column>\d+)\)|): (?P<severity>Warning|Error): (?P<message>.+)')
29+
DIAGNOSTIC_PATTERN = re.compile('"(?P<file>[^"]+)", line (?P<line>\d+)( \(column (?P<column>\d+)\)|): (?P<severity>Warning|Error|Fatal error): (?P<message>.+)')
3030
INDEX_PATTERN = re.compile('(?P<col>\s*)\^')
3131
DEP_PATTERN = re.compile('\S+:\s(?P<file>.+)\n')
3232

tools/toolchains/gcc.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ class GCC(mbedToolchain):
2525
LIBRARY_EXT = '.a'
2626

2727
STD_LIB_NAME = "lib%s.a"
28-
DIAGNOSTIC_PATTERN = re.compile('((?P<file>[^:]+):(?P<line>\d+):)(\d+:)? (?P<severity>warning|error): (?P<message>.+)')
28+
DIAGNOSTIC_PATTERN = re.compile('((?P<file>[^:]+):(?P<line>\d+):)(\d+:)? (?P<severity>warning|error|fatal error): (?P<message>.+)')
2929
INDEX_PATTERN = re.compile('(?P<col>\s*)\^')
3030

3131
def __init__(self, target, notify=None, macros=None,

tools/toolchains/iar.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ class IAR(mbedToolchain):
2626
LINKER_EXT = '.icf'
2727
STD_LIB_NAME = "%s.a"
2828

29-
DIAGNOSTIC_PATTERN = re.compile('"(?P<file>[^"]+)",(?P<line>[\d]+)\s+(?P<severity>Warning|Error)(?P<message>.+)')
29+
DIAGNOSTIC_PATTERN = re.compile('"(?P<file>[^"]+)",(?P<line>[\d]+)\s+(?P<severity>Warning|Error|Fatal error)(?P<message>.+)')
3030
INDEX_PATTERN = re.compile('(?P<col>\s*)\^')
3131

3232
@staticmethod

0 commit comments

Comments
 (0)