Skip to content

Commit 3db1a8a

Browse files
committed
Avoid constructing a FileRef when we don't use it
1 parent 6e63aca commit 3db1a8a

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

tools/resources/__init__.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -250,12 +250,10 @@ def _not_current_label(self, dirname, label_type):
250250
dirname[len(label_type) + 1:] not in self._labels[label_type])
251251

252252
def add_file_ref(self, file_type, file_name, file_path):
253-
if sep != self._sep:
254-
ref = FileRef(file_name.replace(sep, self._sep), file_path)
255-
else:
256-
ref = FileRef(file_name, file_path)
257253
if file_type:
258-
self._file_refs[file_type].add(ref)
254+
if sep != self._sep:
255+
file_name = file_name.replace(sep, self._sep)
256+
self._file_refs[file_type].add(FileRef(file_name, file_path))
259257

260258
def get_file_refs(self, file_type):
261259
"""Return a list of FileRef for every file of the given type"""

0 commit comments

Comments
 (0)