Skip to content

Commit 3dc28ce

Browse files
author
Amanda Butler
authored
Copy edit GattCharacteristic.h
Copy edit file.
1 parent bdf0cbb commit 3dc28ce

File tree

1 file changed

+22
-23
lines changed

1 file changed

+22
-23
lines changed

features/FEATURE_BLE/ble/GattCharacteristic.h

Lines changed: 22 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -300,14 +300,14 @@ class GattCharacteristic {
300300

301301
/**
302302
* @brief Creates a new GattCharacteristic using the specified 16-bit
303-
* UUID, value length, and properties.
303+
* UUID, value length and properties.
304304
*
305305
* @param[in] uuid
306306
* The UUID to use for this characteristic.
307307
* @param[in] valuePtr
308308
* The memory holding the initial value. The value is copied
309309
* into the stack when the enclosing service is added, and
310-
* is thereafter maintained internally by the stack.
310+
* the stack thereafter maintained it internally.
311311
* @param[in] len
312312
* The length in bytes of this characteristic's value.
313313
* @param[in] maxLen
@@ -316,8 +316,8 @@ class GattCharacteristic {
316316
* The 8-bit field containing the characteristic's properties.
317317
* @param[in] descriptors
318318
* A pointer to an array of descriptors to be included within
319-
* this characteristic. The memory for the descriptor array is
320-
* owned by the caller, and should remain valid at least until
319+
* this characteristic. The caller owns the memory for the descriptor
320+
* array, which remains valid at least until
321321
* the enclosing service is added to the GATT table.
322322
* @param[in] numDescriptors
323323
* The number of descriptors in the previous array.
@@ -332,7 +332,7 @@ class GattCharacteristic {
332332
* instantiating the service with the underlying BLE stack.
333333
*
334334
* @note A CCCD should not be allocated if either the notify or indicate
335-
* flag is set, as it is handled by the underlying BLE stack. In such
335+
* flag is set because the underlying BLE stack handles it. In such
336336
* a case, the param descriptors could be empty and the param
337337
* numDescriptors equal to zero.
338338
*/
@@ -372,7 +372,7 @@ class GattCharacteristic {
372372
public:
373373
/**
374374
* Set up callback that will be triggered before the GATT Client is allowed
375-
* to write this characteristic. The handler will determine the
375+
* to write this characteristic. The handler determines the
376376
* authorization reply for the write.
377377
*
378378
* @param[in] callback
@@ -384,7 +384,7 @@ class GattCharacteristic {
384384
}
385385

386386
/**
387-
* Same as GattCharacrteristic::setWriteAuthorizationCallback(), but allows
387+
* Same as GattCharacrteristic::setWriteAuthorizationCallback(), but it allows
388388
* the possibility to add an object reference and member function as
389389
* handler for connection event callbacks.
390390
*
@@ -403,7 +403,7 @@ class GattCharacteristic {
403403

404404
/**
405405
* Set up callback that will be triggered before the GATT Client is allowed
406-
* to read this characteristic. The handler will determine the
406+
* to read this characteristic. The handler determines the
407407
* authorization reply for the read.
408408
*
409409
* @param[in] callback
@@ -415,7 +415,7 @@ class GattCharacteristic {
415415
}
416416

417417
/**
418-
* Same as GattCharacrteristic::setReadAuthorizationCallback(), but allows
418+
* Same as GattCharacrteristic::setReadAuthorizationCallback(), but it allows
419419
* the possibility to add an object reference and member function as
420420
* handler for connection event callbacks.
421421
*
@@ -465,12 +465,12 @@ class GattCharacteristic {
465465
* @return A GattAuthCallbackReply_t value indicating whether authorization
466466
* is granted.
467467
*
468-
* @note To authorize or deny the read the params->authorizationReply field
468+
* @note To authorize or deny the read, the params->authorizationReply field
469469
* should be set to AUTH_CALLBACK_REPLY_SUCCESS (authorize) or any
470470
* of the AUTH_CALLBACK_REPLY_ATTERR_* values (deny).
471471
*
472472
* @note If the read is approved and params->data is unchanged (NULL),
473-
* the current characteristic value will be used.
473+
* the current characteristic value is used.
474474
*
475475
* @note If the read is approved, a new value can be provided by setting
476476
* the params->data pointer and params->len fields.
@@ -509,8 +509,7 @@ class GattCharacteristic {
509509
*
510510
* @return The value attribute handle.
511511
*
512-
* @note The attribute handle is typically assigned by the underlying BLE
513-
* stack.
512+
* @note The underlying BLE stack typically assigns the attribute handle.
514513
*/
515514
GattAttribute::Handle_t getValueHandle(void) const {
516515
return getValueAttribute().getHandle();
@@ -545,7 +544,7 @@ class GattCharacteristic {
545544
}
546545

547546
/**
548-
* Check whether read authorization is enabled i.e. check whether a
547+
* Check whether read authorization is enabled. In other words, check whether a
549548
* read authorization callback was previously registered. Refer to
550549
* GattCharacteristic::setReadAuthorizationCallback().
551550
*
@@ -556,7 +555,7 @@ class GattCharacteristic {
556555
}
557556

558557
/**
559-
* Check whether write authorization is enabled i.e. check whether a
558+
* Check whether write authorization is enabled. In other words, check whether a
560559
* write authorization callback was previously registered. Refer to
561560
* GattCharacteristic::setWriteAuthorizationCallback().
562561
*
@@ -600,7 +599,7 @@ class GattCharacteristic {
600599
/**
601600
* The characteristic's descriptor attributes.
602601
* This contains only CCCDs that has neither the notify nor the indicate
603-
* flag set, as those are handled by the underlying BLE stack.
602+
* flag set, as the underlying BLE stack handles those.
604603
*/
605604
GattAttribute **_descriptors;
606605
/**
@@ -609,12 +608,12 @@ class GattCharacteristic {
609608
uint8_t _descriptorCount;
610609

611610
/**
612-
* Whether read authorization is enabled i.e. whether there is a registered
611+
* Whether read authorization is enabled - in other words, whether there is a registered
613612
* callback to determine read authorization reply.
614613
*/
615614
bool enabledReadAuthorization;
616615
/**
617-
* Whether write authorization is enabled i.e. whether there is a registered
616+
* Whether write authorization is enabled - in other words, whether there is a registered
618617
* callback to determine write authorization reply.
619618
*/
620619
bool enabledWriteAuthorization;
@@ -696,7 +695,7 @@ class WriteOnlyGattCharacteristic : public GattCharacteristic {
696695
*
697696
* @note Instances of WriteOnlyGattCharacteristic have variable length
698697
* attribute value with maximum size equal to sizeof(T). For a fixed length
699-
* alternative use GattCharacteristic directly.
698+
* alternative, use GattCharacteristic directly.
700699
*/
701700
WriteOnlyGattCharacteristic<T>(const UUID &uuid,
702701
T *valuePtr,
@@ -735,7 +734,7 @@ class ReadWriteGattCharacteristic : public GattCharacteristic {
735734
*
736735
* @note Instances of ReadWriteGattCharacteristic have variable length
737736
* attribute value with maximum size equal to sizeof(T). For a fixed length
738-
* alternative use GattCharacteristic directly.
737+
* alternative, use GattCharacteristic directly.
739738
*/
740739
ReadWriteGattCharacteristic<T>(const UUID &uuid,
741740
T *valuePtr,
@@ -775,7 +774,7 @@ class WriteOnlyArrayGattCharacteristic : public GattCharacteristic {
775774
*
776775
* @note Instances of WriteOnlyGattCharacteristic have variable length
777776
* attribute value with maximum size equal to sizeof(T) * NUM_ELEMENTS.
778-
* For a fixed length alternative use GattCharacteristic directly.
777+
* For a fixed length alternative, use GattCharacteristic directly.
779778
*/
780779
WriteOnlyArrayGattCharacteristic<T, NUM_ELEMENTS>(const UUID &uuid,
781780
T valuePtr[NUM_ELEMENTS],
@@ -815,7 +814,7 @@ class ReadOnlyArrayGattCharacteristic : public GattCharacteristic {
815814
*
816815
* @note Instances of ReadOnlyGattCharacteristic have fixed length
817816
* attribute value that equals sizeof(T) * NUM_ELEMENTS.
818-
* For a variable length alternative use GattCharacteristic directly.
817+
* For a variable length alternative, use GattCharacteristic directly.
819818
*/
820819
ReadOnlyArrayGattCharacteristic<T, NUM_ELEMENTS>(const UUID &uuid,
821820
T valuePtr[NUM_ELEMENTS],
@@ -856,7 +855,7 @@ class ReadWriteArrayGattCharacteristic : public GattCharacteristic {
856855
*
857856
* @note Instances of ReadWriteGattCharacteristic have variable length
858857
* attribute value with maximum size equal to sizeof(T) * NUM_ELEMENTS.
859-
* For a fixed length alternative use GattCharacteristic directly.
858+
* For a fixed length alternative, use GattCharacteristic directly.
860859
*/
861860
ReadWriteArrayGattCharacteristic<T, NUM_ELEMENTS>(const UUID &uuid,
862861
T valuePtr[NUM_ELEMENTS],

0 commit comments

Comments
 (0)