Skip to content

Commit 41c1901

Browse files
committed
lwipstack: fix astyle coding style
1 parent e54ce88 commit 41c1901

File tree

7 files changed

+119
-108
lines changed

7 files changed

+119
-108
lines changed

features/lwipstack/LWIPInterface.cpp

Lines changed: 33 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -59,10 +59,10 @@ static void add_dns_addr_to_dns_list_index(const u8_t addr_type, const u8_t inde
5959
if (addr_type == IPADDR_TYPE_V6) {
6060
/* 2001:4860:4860::8888 google */
6161
ip_addr_t ipv6_dns_addr = IPADDR6_INIT(
62-
PP_HTONL(0x20014860UL),
63-
PP_HTONL(0x48600000UL),
64-
PP_HTONL(0x00000000UL),
65-
PP_HTONL(0x00008888UL));
62+
PP_HTONL(0x20014860UL),
63+
PP_HTONL(0x48600000UL),
64+
PP_HTONL(0x00000000UL),
65+
PP_HTONL(0x00008888UL));
6666
dns_setserver(index, &ipv6_dns_addr);
6767
}
6868
#endif
@@ -186,7 +186,7 @@ void LWIP::Interface::netif_link_irq(struct netif *netif)
186186

187187
if (interface->client_callback && connectedStatusPrev != interface->connected
188188
&& interface->connected != NSAPI_STATUS_GLOBAL_UP /* advertised by netif_status_irq */
189-
&& interface->connected != NSAPI_STATUS_DISCONNECTED) /* advertised by bring_down */ {
189+
&& interface->connected != NSAPI_STATUS_DISCONNECTED) { /* advertised by bring_down */
190190
interface->client_callback(NSAPI_EVENT_CONNECTION_STATUS_CHANGE, interface->connected);
191191
}
192192
}
@@ -235,7 +235,7 @@ void LWIP::Interface::netif_status_irq(struct netif *netif)
235235
}
236236

237237
if (interface->client_callback && (connectedStatusPrev != interface->connected)
238-
&& interface->connected != NSAPI_STATUS_DISCONNECTED) /* advertised by bring_down */ {
238+
&& interface->connected != NSAPI_STATUS_DISCONNECTED) { /* advertised by bring_down */
239239
interface->client_callback(NSAPI_EVENT_CONNECTION_STATUS_CHANGE, interface->connected);
240240
}
241241
}
@@ -262,8 +262,8 @@ static void mbed_lwip_clear_ipv6_addresses(struct netif *netif)
262262
char *LWIP::Interface::get_mac_address(char *buf, nsapi_size_t buflen)
263263
{
264264
(void) snprintf(buf, buflen, "%02x:%02x:%02x:%02x:%02x:%02x",
265-
netif.hwaddr[0], netif.hwaddr[1], netif.hwaddr[2],
266-
netif.hwaddr[3], netif.hwaddr[4], netif.hwaddr[5]);
265+
netif.hwaddr[0], netif.hwaddr[1], netif.hwaddr[2],
266+
netif.hwaddr[3], netif.hwaddr[4], netif.hwaddr[5]);
267267
return buf;
268268
}
269269

@@ -317,9 +317,9 @@ char *LWIP::Interface::get_gateway(char *buf, nsapi_size_t buflen)
317317
}
318318

319319
LWIP::Interface::Interface() :
320-
hw(NULL), has_addr_state(0),
321-
connected(NSAPI_STATUS_DISCONNECTED),
322-
dhcp_started(false), dhcp_has_to_be_set(false), blocking(true), ppp(false)
320+
hw(NULL), has_addr_state(0),
321+
connected(NSAPI_STATUS_DISCONNECTED),
322+
dhcp_started(false), dhcp_has_to_be_set(false), blocking(true), ppp(false)
323323
{
324324
memset(&netif, 0, sizeof netif);
325325

@@ -379,9 +379,9 @@ nsapi_error_t LWIP::add_ethernet_interface(EMAC &emac, bool default_if, OnboardN
379379

380380
if (!netif_add(&interface->netif,
381381
#if LWIP_IPV4
382-
0, 0, 0,
382+
0, 0, 0,
383383
#endif
384-
interface, &LWIP::Interface::emac_if_init, tcpip_input)) {
384+
interface, &LWIP::Interface::emac_if_init, tcpip_input)) {
385385
return NSAPI_ERROR_DEVICE_ERROR;
386386
}
387387

@@ -497,8 +497,8 @@ nsapi_error_t LWIP::Interface::bringup(bool dhcp, const char *ip, const char *ne
497497
ip4_addr_t gw_addr;
498498

499499
if (!inet_aton(ip, &ip_addr) ||
500-
!inet_aton(netmask, &netmask_addr) ||
501-
!inet_aton(gw, &gw_addr)) {
500+
!inet_aton(netmask, &netmask_addr) ||
501+
!inet_aton(gw, &gw_addr)) {
502502
return NSAPI_ERROR_PARAMETER;
503503
}
504504

@@ -512,14 +512,14 @@ nsapi_error_t LWIP::Interface::bringup(bool dhcp, const char *ip, const char *ne
512512
}
513513

514514
if (ppp) {
515-
err_t err = ppp_lwip_connect(hw);
516-
if (err) {
517-
connected = NSAPI_STATUS_DISCONNECTED;
518-
if (client_callback) {
519-
client_callback(NSAPI_EVENT_CONNECTION_STATUS_CHANGE, NSAPI_STATUS_DISCONNECTED);
520-
}
521-
return err_remap(err);
522-
}
515+
err_t err = ppp_lwip_connect(hw);
516+
if (err) {
517+
connected = NSAPI_STATUS_DISCONNECTED;
518+
if (client_callback) {
519+
client_callback(NSAPI_EVENT_CONNECTION_STATUS_CHANGE, NSAPI_STATUS_DISCONNECTED);
520+
}
521+
return err_remap(err);
522+
}
523523
}
524524

525525
if (!netif_is_link_up(&netif)) {
@@ -598,16 +598,16 @@ nsapi_error_t LWIP::Interface::bringdown()
598598

599599
if (ppp) {
600600
/* this is a blocking call, returns when PPP is properly closed */
601-
err_t err = ppp_lwip_disconnect(hw);
602-
if (err) {
603-
return err_remap(err);
604-
}
605-
MBED_ASSERT(!netif_is_link_up(&netif));
606-
/*if (netif_is_link_up(&netif)) {
607-
if (sys_arch_sem_wait(&unlinked, 15000) == SYS_ARCH_TIMEOUT) {
608-
return NSAPI_ERROR_DEVICE_ERROR;
609-
}
610-
}*/
601+
err_t err = ppp_lwip_disconnect(hw);
602+
if (err) {
603+
return err_remap(err);
604+
}
605+
MBED_ASSERT(!netif_is_link_up(&netif));
606+
/*if (netif_is_link_up(&netif)) {
607+
if (sys_arch_sem_wait(&unlinked, 15000) == SYS_ARCH_TIMEOUT) {
608+
return NSAPI_ERROR_DEVICE_ERROR;
609+
}
610+
}*/
611611
} else {
612612
netif_set_down(&netif);
613613
}

features/lwipstack/LWIPInterfaceEMAC.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,7 @@ err_t LWIP::Interface::emac_igmp_mac_filter(struct netif *netif, const ip4_addr_
7474
LWIP::Interface *mbed_if = static_cast<LWIP::Interface *>(netif->state);
7575

7676
switch (action) {
77-
case NETIF_ADD_MAC_FILTER:
78-
{
77+
case NETIF_ADD_MAC_FILTER: {
7978
uint32_t group23 = ntohl(group->addr) & 0x007FFFFF;
8079
uint8_t addr[6];
8180
addr[0] = LL_IP4_MULTICAST_ADDR_0;
@@ -112,8 +111,7 @@ err_t LWIP::Interface::emac_mld_mac_filter(struct netif *netif, const ip6_addr_t
112111
LWIP::Interface *mbed_if = static_cast<LWIP::Interface *>(netif->state);
113112

114113
switch (action) {
115-
case NETIF_ADD_MAC_FILTER:
116-
{
114+
case NETIF_ADD_MAC_FILTER: {
117115
uint32_t group32 = ntohl(group->addr[3]);
118116
uint8_t addr[6];
119117
addr[0] = LL_IP6_MULTICAST_ADDR_0;

features/lwipstack/LWIPStack.cpp

Lines changed: 32 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
#include "LWIPStack.h"
3939

4040
#ifndef LWIP_SOCKET_MAX_MEMBERSHIPS
41-
#define LWIP_SOCKET_MAX_MEMBERSHIPS 4
41+
#define LWIP_SOCKET_MAX_MEMBERSHIPS 4
4242
#endif
4343

4444
void LWIP::socket_callback(struct netconn *nc, enum netconn_evt eh, u16_t len)
@@ -54,8 +54,8 @@ void LWIP::socket_callback(struct netconn *nc, enum netconn_evt eh, u16_t len)
5454

5555
for (int i = 0; i < MEMP_NUM_NETCONN; i++) {
5656
if (lwip.arena[i].in_use
57-
&& lwip.arena[i].conn == nc
58-
&& lwip.arena[i].cb) {
57+
&& lwip.arena[i].conn == nc
58+
&& lwip.arena[i].cb) {
5959
lwip.arena[i].cb(lwip.arena[i].data);
6060
}
6161
}
@@ -101,15 +101,15 @@ static bool convert_mbed_addr_to_lwip(ip_addr_t *out, const nsapi_addr_t *in)
101101
{
102102
#if LWIP_IPV6
103103
if (in->version == NSAPI_IPv6) {
104-
IP_SET_TYPE(out, IPADDR_TYPE_V6);
105-
SMEMCPY(ip_2_ip6(out), in->bytes, sizeof(ip6_addr_t));
106-
return true;
104+
IP_SET_TYPE(out, IPADDR_TYPE_V6);
105+
SMEMCPY(ip_2_ip6(out), in->bytes, sizeof(ip6_addr_t));
106+
return true;
107107
}
108108
#if !LWIP_IPV4
109109
/* For bind() and other purposes, need to accept "null" of other type */
110110
/* (People use IPv4 0.0.0.0 as a general null) */
111111
if (in->version == NSAPI_UNSPEC ||
112-
(in->version == NSAPI_IPv4 && all_zeros(in->bytes, 4))) {
112+
(in->version == NSAPI_IPv4 && all_zeros(in->bytes, 4))) {
113113
ip_addr_set_zero_ip6(out);
114114
return true;
115115
}
@@ -118,14 +118,14 @@ static bool convert_mbed_addr_to_lwip(ip_addr_t *out, const nsapi_addr_t *in)
118118

119119
#if LWIP_IPV4
120120
if (in->version == NSAPI_IPv4) {
121-
IP_SET_TYPE(out, IPADDR_TYPE_V4);
122-
SMEMCPY(ip_2_ip4(out), in->bytes, sizeof(ip4_addr_t));
123-
return true;
121+
IP_SET_TYPE(out, IPADDR_TYPE_V4);
122+
SMEMCPY(ip_2_ip4(out), in->bytes, sizeof(ip4_addr_t));
123+
return true;
124124
}
125125
#if !LWIP_IPV6
126126
/* For symmetry with above, accept IPv6 :: as a general null */
127127
if (in->version == NSAPI_UNSPEC ||
128-
(in->version == NSAPI_IPv6 && all_zeros(in->bytes, 16))) {
128+
(in->version == NSAPI_IPv6 && all_zeros(in->bytes, 16))) {
129129
ip_addr_set_zero_ip4(out);
130130
return true;
131131
}
@@ -273,7 +273,7 @@ nsapi_error_t LWIP::socket_open(nsapi_socket_t *handle, nsapi_protocol_t proto)
273273

274274
#if LWIP_IPV6
275275
// Enable IPv6 (or dual-stack)
276-
lwip_proto = (enum netconn_type) (lwip_proto | NETCONN_TYPE_IPV6);
276+
lwip_proto = (enum netconn_type)(lwip_proto | NETCONN_TYPE_IPV6);
277277
#endif
278278

279279
s->conn = netconn_new_with_callback(lwip_proto, &LWIP::socket_callback);
@@ -485,15 +485,16 @@ nsapi_size_or_error_t LWIP::socket_recvfrom(nsapi_socket_t handle, SocketAddress
485485
return recv;
486486
}
487487

488-
int32_t LWIP::find_multicast_member(const struct mbed_lwip_socket *s, const nsapi_ip_mreq_t *imr) {
488+
int32_t LWIP::find_multicast_member(const struct mbed_lwip_socket *s, const nsapi_ip_mreq_t *imr)
489+
{
489490
uint32_t count = 0;
490491
uint32_t index = 0;
491492
// Set upper limit on while loop, should break out when the membership pair is found
492493
while (count < s->multicast_memberships_count) {
493494
index = next_registered_multicast_member(s, index);
494495

495496
if (memcmp(&s->multicast_memberships[index].imr_multiaddr, &imr->imr_multiaddr, sizeof(nsapi_addr_t)) == 0 &&
496-
memcmp(&s->multicast_memberships[index].imr_interface, &imr->imr_interface, sizeof(nsapi_addr_t)) == 0) {
497+
memcmp(&s->multicast_memberships[index].imr_interface, &imr->imr_interface, sizeof(nsapi_addr_t)) == 0) {
497498
return index;
498499
}
499500
count++;
@@ -522,15 +523,15 @@ nsapi_error_t LWIP::setsockopt(nsapi_socket_t handle, int level, int optname, co
522523
return NSAPI_ERROR_UNSUPPORTED;
523524
}
524525

525-
s->conn->pcb.tcp->keep_idle = *(int*)optval;
526+
s->conn->pcb.tcp->keep_idle = *(int *)optval;
526527
return 0;
527528

528529
case NSAPI_KEEPINTVL:
529530
if (optlen != sizeof(int) || NETCONNTYPE_GROUP(s->conn->type) != NETCONN_TCP) {
530531
return NSAPI_ERROR_UNSUPPORTED;
531532
}
532533

533-
s->conn->pcb.tcp->keep_intvl = *(int*)optval;
534+
s->conn->pcb.tcp->keep_intvl = *(int *)optval;
534535
return 0;
535536
#endif
536537

@@ -582,11 +583,11 @@ nsapi_error_t LWIP::setsockopt(nsapi_socket_t handle, int level, int optname, co
582583
if (optname == NSAPI_ADD_MEMBERSHIP) {
583584
if (!s->multicast_memberships) {
584585
// First multicast join on this socket, allocate space for membership tracking
585-
s->multicast_memberships = (nsapi_ip_mreq_t*)malloc(sizeof(nsapi_ip_mreq_t) * LWIP_SOCKET_MAX_MEMBERSHIPS);
586+
s->multicast_memberships = (nsapi_ip_mreq_t *)malloc(sizeof(nsapi_ip_mreq_t) * LWIP_SOCKET_MAX_MEMBERSHIPS);
586587
if (!s->multicast_memberships) {
587588
return NSAPI_ERROR_NO_MEMORY;
588589
}
589-
} else if(s->multicast_memberships_count == LWIP_SOCKET_MAX_MEMBERSHIPS) {
590+
} else if (s->multicast_memberships_count == LWIP_SOCKET_MAX_MEMBERSHIPS) {
590591
return NSAPI_ERROR_NO_MEMORY;
591592
}
592593

@@ -598,16 +599,16 @@ nsapi_error_t LWIP::setsockopt(nsapi_socket_t handle, int level, int optname, co
598599

599600
adaptation.lock();
600601

601-
#if LWIP_IPV4
602+
#if LWIP_IPV4
602603
if (IP_IS_V4(&if_addr)) {
603604
igmp_err = igmp_joingroup(ip_2_ip4(&if_addr), ip_2_ip4(&multi_addr));
604605
}
605-
#endif
606-
#if LWIP_IPV6
606+
#endif
607+
#if LWIP_IPV6
607608
if (IP_IS_V6(&if_addr)) {
608609
igmp_err = mld6_joingroup(ip_2_ip6(&if_addr), ip_2_ip6(&multi_addr));
609610
}
610-
#endif
611+
#endif
611612

612613
adaptation.unlock();
613614

@@ -626,22 +627,22 @@ nsapi_error_t LWIP::setsockopt(nsapi_socket_t handle, int level, int optname, co
626627

627628
adaptation.lock();
628629

629-
#if LWIP_IPV4
630+
#if LWIP_IPV4
630631
if (IP_IS_V4(&if_addr)) {
631632
igmp_err = igmp_leavegroup(ip_2_ip4(&if_addr), ip_2_ip4(&multi_addr));
632633
}
633-
#endif
634-
#if LWIP_IPV6
634+
#endif
635+
#if LWIP_IPV6
635636
if (IP_IS_V6(&if_addr)) {
636637
igmp_err = mld6_leavegroup(ip_2_ip6(&if_addr), ip_2_ip6(&multi_addr));
637638
}
638-
#endif
639+
#endif
639640

640641
adaptation.unlock();
641642
}
642643

643644
return err_remap(igmp_err);
644-
}
645+
}
645646

646647
default:
647648
return NSAPI_ERROR_UNSUPPORTED;
@@ -662,7 +663,8 @@ void LWIP::socket_attach(nsapi_socket_t handle, void (*callback)(void *), void *
662663
s->data = data;
663664
}
664665

665-
LWIP &LWIP::get_instance() {
666+
LWIP &LWIP::get_instance()
667+
{
666668
static LWIP lwip;
667669
return lwip;
668670
}
@@ -672,7 +674,8 @@ LWIP &LWIP::get_instance() {
672674
#define LWIP 0x11991199
673675
#if MBED_CONF_NSAPI_DEFAULT_STACK == LWIP
674676
#undef LWIP
675-
OnboardNetworkStack &OnboardNetworkStack::get_default_instance() {
677+
OnboardNetworkStack &OnboardNetworkStack::get_default_instance()
678+
{
676679
return LWIP::get_instance();
677680
}
678681
#endif

0 commit comments

Comments
 (0)