Fix memory leak if user does not calls abort. call abort when connection is closed

Netanel Gonen · Netanel Gonen · commit 448780519166 · 2018-11-25T15:55:31.000+02:00
diff --git a/components/TARGET_PSA/services/crypto/COMPONENT_SPE/psa_crypto_partition.c b/components/TARGET_PSA/services/crypto/COMPONENT_SPE/psa_crypto_partition.c
@@ -229,6 +229,7 @@ static void psa_mac_operation( void )
         }
         case PSA_IPC_DISCONNECT:
         {
+            psa_mac_abort( msg.rhandle );
             if( msg.rhandle != NULL )
                 mbedtls_free( msg.rhandle );
             break;
@@ -383,6 +384,7 @@ static void psa_hash_operation( void )
         }
         case PSA_IPC_DISCONNECT:
         {
+            psa_hash_abort( msg.rhandle );
             if( msg.rhandle != NULL )
                 mbedtls_free( msg.rhandle );
             break;
@@ -868,6 +870,7 @@ static void psa_symmetric_operation( void )
         }
         case PSA_IPC_DISCONNECT:
         {
+            psa_cipher_abort( msg.rhandle );
             if( msg.rhandle != NULL )
                 mbedtls_free( msg.rhandle );
             break;
@@ -1365,6 +1368,7 @@ void psa_crypto_generator_operations( void )
         }
         case PSA_IPC_DISCONNECT:
         {
+            psa_generator_abort( msg.rhandle );
             if( msg.rhandle != NULL )
                 mbedtls_free( msg.rhandle );
             break;

Original file line number	Diff line number	Diff line change
`@@ -229,6 +229,7 @@ static void psa_mac_operation( void )`
`229`	`229`	`}`
`230`	`230`	`case PSA_IPC_DISCONNECT:`
`231`	`231`	`{`
	`232`	`+ psa_mac_abort( msg.rhandle );`
`232`	`233`	`if( msg.rhandle != NULL )`
`233`	`234`	`mbedtls_free( msg.rhandle );`
`234`	`235`	`break;`
`@@ -383,6 +384,7 @@ static void psa_hash_operation( void )`
`383`	`384`	`}`
`384`	`385`	`case PSA_IPC_DISCONNECT:`
`385`	`386`	`{`
	`387`	`+ psa_hash_abort( msg.rhandle );`
`386`	`388`	`if( msg.rhandle != NULL )`
`387`	`389`	`mbedtls_free( msg.rhandle );`
`388`	`390`	`break;`
`@@ -868,6 +870,7 @@ static void psa_symmetric_operation( void )`
`868`	`870`	`}`
`869`	`871`	`case PSA_IPC_DISCONNECT:`
`870`	`872`	`{`
	`873`	`+ psa_cipher_abort( msg.rhandle );`
`871`	`874`	`if( msg.rhandle != NULL )`
`872`	`875`	`mbedtls_free( msg.rhandle );`
`873`	`876`	`break;`
`@@ -1365,6 +1368,7 @@ void psa_crypto_generator_operations( void )`
`1365`	`1368`	`}`
`1366`	`1369`	`case PSA_IPC_DISCONNECT:`
`1367`	`1370`	`{`
	`1371`	`+ psa_generator_abort( msg.rhandle );`
`1368`	`1372`	`if( msg.rhandle != NULL )`
`1369`	`1373`	`mbedtls_free( msg.rhandle );`
`1370`	`1374`	`break;`