Nordic BLE: Fix return value verification

pan- · pan- · commit 4b8fb0be7824 · 2018-06-22T09:36:06.000+01:00
diff --git a/features/FEATURE_BLE/targets/TARGET_NORDIC/TARGET_NRF51/source/nRF5xPalSecurityManager.cpp b/features/FEATURE_BLE/targets/TARGET_NORDIC/TARGET_NRF51/source/nRF5xPalSecurityManager.cpp
@@ -354,7 +354,7 @@ ble_error_t nRF5xSecurityManager::cancel_pairing(
     // a pairing feature exchange from a central.
     if (!pairing_cb) {
         ::Gap::Role_t current_role;
-        if (!nRF5xn::Instance().getGap().get_role(connection, current_role)) {
+        if (nRF5xn::Instance().getGap().get_role(connection, current_role) != BLE_ERROR_NONE) {
             return BLE_ERROR_INVALID_PARAM;
         }
 
diff --git a/features/FEATURE_BLE/targets/TARGET_NORDIC/TARGET_NRF52/source/nRF5xPalSecurityManager.cpp b/features/FEATURE_BLE/targets/TARGET_NORDIC/TARGET_NRF52/source/nRF5xPalSecurityManager.cpp
@@ -331,7 +331,7 @@ ble_error_t nRF5xSecurityManager::cancel_pairing(
     // a pairing feature exchange from a central.
     if (!pairing_cb) {
         ::Gap::Role_t current_role;
-        if (!nRF5xn::Instance().getGap().get_role(connection, current_role)) {
+        if (nRF5xn::Instance().getGap().get_role(connection, current_role) != BLE_ERROR_NONE) {
             return BLE_ERROR_INVALID_PARAM;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -354,7 +354,7 @@ ble_error_t nRF5xSecurityManager::cancel_pairing(`
`354`	`354`	`// a pairing feature exchange from a central.`
`355`	`355`	`if (!pairing_cb) {`
`356`	`356`	`::Gap::Role_t current_role;`
`357`		`- if (!nRF5xn::Instance().getGap().get_role(connection, current_role)) {`
	`357`	`+ if (nRF5xn::Instance().getGap().get_role(connection, current_role) != BLE_ERROR_NONE) {`
`358`	`358`	`return BLE_ERROR_INVALID_PARAM;`
`359`	`359`	`}`
`360`	`360`
Original file line number	Diff line number	Diff line change
`@@ -331,7 +331,7 @@ ble_error_t nRF5xSecurityManager::cancel_pairing(`
`331`	`331`	`// a pairing feature exchange from a central.`
`332`	`332`	`if (!pairing_cb) {`
`333`	`333`	`::Gap::Role_t current_role;`
`334`		`- if (!nRF5xn::Instance().getGap().get_role(connection, current_role)) {`
	`334`	`+ if (nRF5xn::Instance().getGap().get_role(connection, current_role) != BLE_ERROR_NONE) {`
`335`	`335`	`return BLE_ERROR_INVALID_PARAM;`
`336`	`336`	`}`
`337`	`337`