nsapi_dns: use delete[] for array alloc'd with new[]

Author: michalpasztamobica

UNITTESTS/features/netsocket/nsapi_dns/test_nsapi_dns.cpp

@@ -331,7 +331,9 @@ TEST_F(Test_nsapi_dns, single_query)
     .WillOnce(DoAll(SetArgPointee<0>((void **)&NetworkStackMock::get_instance()), Return(NSAPI_ERROR_OK)));
 
     // Returning UNSUPPORTED will cause the nsapi_dns addresses to be used.
-    EXPECT_CALL(*((NetworkStackMock *)iface->get_stack()), get_dns_server(_, _, _)).Times(1).WillOnce(Return(NSAPI_ERROR_OK));
+    EXPECT_CALL(*((NetworkStackMock *)iface->get_stack()), get_dns_server(_, _, _))
+    .Times(1)
+    .WillOnce(DoAll(SetArgPointee<1>(SocketAddress("1.2.3.4", 53)), Return(NSAPI_ERROR_OK)));
 
     EXPECT_CALL(*((NetworkStackMock *)iface->get_stack()), socket_sendto(_, _, _, _)).Times(1).WillOnce(Return(NSAPI_ERROR_OK));
 
@@ -419,6 +421,7 @@ TEST_F(Test_nsapi_dns, multiple_queries)
     EXPECT_FALSE(strncmp(addr[1].get_ip_address(), "222.173.190.239", sizeof("222.173.190.239")));
     EXPECT_EQ(addr[2].get_ip_version(), NSAPI_IPv4);
     EXPECT_FALSE(strncmp(addr[2].get_ip_address(), "1.2.3.4", sizeof("1.2.3.4")));
+    delete[] addr;
 
     SocketAddress *addr_cache;
     // Cache will only raturn one address.
@@ -427,6 +430,7 @@ TEST_F(Test_nsapi_dns, multiple_queries)
     // This is a bug which will be fixed in
     EXPECT_EQ(addr_cache[0].get_ip_version(), NSAPI_IPv4);
     EXPECT_FALSE(strncmp(addr_cache[0].get_ip_address(), "216.58.207.238", sizeof("216.58.207.238")));
+    delete[] addr_cache;
 }
 
 TEST_F(Test_nsapi_dns, single_query_errors)

UNITTESTS/features/netsocket/nsapi_dns/unittest.cmake

@@ -26,15 +26,15 @@ set(unittest-test-sources
   stubs/NetworkInterfaceDefaults_stub.cpp
   stubs/mbed_atomic_stub.c
   stubs/mbed_critical_stub.c
+  stubs/mbed_rtos_rtx_stub.c
   stubs/Kernel_stub.cpp
-  #stubs/mbed_error.c
-  #stubs/mbed_shared_queues_stub.cpp
-#InternetSocket.cpp:
   stubs/EventFlags_stub.cpp
+  stubs/rtx_mutex_stub.c
   stubs/SocketStats_Stub.cpp
   features/netsocket/nsapi_dns/test_nsapi_dns.cpp
   ../features/netsocket/NetworkInterface.cpp
   ../features/netsocket/InternetSocket.cpp
+  ../features/netsocket/InternetDatagramSocket.cpp
   ../features/netsocket/UDPSocket.cpp
 )
 

features/netsocket/nsapi_dns.cpp

@@ -411,7 +411,7 @@ static void nsapi_dns_cache_reset()
     dns_cache_mutex->lock();
     for (int i = 0; i < MBED_CONF_NSAPI_DNS_CACHE_SIZE; i++) {
         if (dns_cache[i]) {
-            delete dns_cache[i]->host;
+            delete[] dns_cache[i]->host;
             dns_cache[i]->host = NULL;
             delete dns_cache[i];
             dns_cache[i] = NULL;
@@ -984,7 +984,7 @@ static nsapi_error_t nsapi_dns_query_async_delete(intptr_t unique_id)
         delete[] query->addrs;
     }
 
-    delete query->host;
+    delete[] query->host;
     delete query;
     dns_query_queue[index] = NULL;