CircularBuffer::push() is critical section

komori-t · komori-t · commit 50e79a45f8c3 · 2016-04-25T17:36:53.000+09:00
diff --git a/libraries/mbed/common/SPI.cpp b/libraries/mbed/common/SPI.cpp
@@ -124,10 +124,12 @@ int SPI::queue_transfer(const void *tx_buffer, int tx_length, void *rx_buffer, i
     if (_transaction_buffer.full()) {
         return -1; // the buffer is full
     } else {
+        __disable_irq();
         _transaction_buffer.push(transaction);
         if (!spi_active(&_spi)) {
             dequeue_transaction();
         }
+        __enable_irq();
         return 0;
     }
 #else

Original file line number	Diff line number	Diff line change
`@@ -124,10 +124,12 @@ int SPI::queue_transfer(const void tx_buffer, int tx_length, void rx_buffer, i`
`124`	`124`	`if (_transaction_buffer.full()) {`
`125`	`125`	`return -1; // the buffer is full`
`126`	`126`	`} else {`
	`127`	`+ __disable_irq();`
`127`	`128`	`_transaction_buffer.push(transaction);`
`128`	`129`	`if (!spi_active(&_spi)) {`
`129`	`130`	`dequeue_transaction();`
`130`	`131`	`}`
	`132`	`+ __enable_irq();`
`131`	`133`	`return 0;`
`132`	`134`	`}`
`133`	`135`	`#else`