Skip to content

Commit 59dd859

Browse files
authored
Merge pull request #4707 from LMESTM/stm32_serial_it_source
STM32: serial: use proper macro to check interrupt
2 parents 08dfc84 + be8024d commit 59dd859

File tree

5 files changed

+31
-31
lines changed

5 files changed

+31
-31
lines changed

targets/TARGET_STM/TARGET_STM32F0/serial_device.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -265,20 +265,20 @@ static void uart_irq(int id)
265265

266266
if (serial_irq_ids[id] != 0) {
267267
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_TC) != RESET) {
268-
if (__HAL_UART_GET_IT_SOURCE(huart, UART_IT_TC) != RESET) {
268+
if (__HAL_UART_GET_IT(huart, UART_IT_TC) != RESET) {
269269
irq_handler(serial_irq_ids[id], TxIrq);
270270
__HAL_UART_CLEAR_FLAG(huart, UART_CLEAR_TCF);
271271
}
272272
}
273273
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_RXNE) != RESET) {
274-
if (__HAL_UART_GET_IT_SOURCE(huart, UART_IT_RXNE) != RESET) {
274+
if (__HAL_UART_GET_IT(huart, UART_IT_RXNE) != RESET) {
275275
irq_handler(serial_irq_ids[id], RxIrq);
276276
volatile uint32_t tmpval = huart->Instance->RDR; // Clear RXNE flag
277277
UNUSED(tmpval);
278278
}
279279
}
280280
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_ORE) != RESET) {
281-
if (__HAL_UART_GET_IT_SOURCE(huart, UART_IT_ORE) != RESET) {
281+
if (__HAL_UART_GET_IT(huart, UART_IT_ORE) != RESET) {
282282
__HAL_UART_CLEAR_FLAG(huart, UART_CLEAR_OREF);
283283
}
284284
}
@@ -780,19 +780,19 @@ int serial_irq_handler_asynch(serial_t *obj)
780780

781781
// Handle error events
782782
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_PE) != RESET) {
783-
if (__HAL_UART_GET_IT_SOURCE(huart, USART_IT_ERR) != RESET) {
783+
if (__HAL_UART_GET_IT(huart, UART_IT_PE) != RESET) {
784784
return_event |= (SERIAL_EVENT_RX_PARITY_ERROR & obj_s->events);
785785
}
786786
}
787787

788788
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_FE) != RESET) {
789-
if (__HAL_UART_GET_IT_SOURCE(huart, USART_IT_ERR) != RESET) {
789+
if (__HAL_UART_GET_IT(huart, UART_IT_FE) != RESET) {
790790
return_event |= (SERIAL_EVENT_RX_FRAMING_ERROR & obj_s->events);
791791
}
792792
}
793793

794794
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_ORE) != RESET) {
795-
if (__HAL_UART_GET_IT_SOURCE(huart, USART_IT_ERR) != RESET) {
795+
if (__HAL_UART_GET_IT(huart, UART_IT_ORE) != RESET) {
796796
return_event |= (SERIAL_EVENT_RX_OVERRUN_ERROR & obj_s->events);
797797
}
798798
}

targets/TARGET_STM/TARGET_STM32F3/serial_device.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -211,20 +211,20 @@ static void uart_irq(int id)
211211

212212
if (serial_irq_ids[id] != 0) {
213213
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_TC) != RESET) {
214-
if (__HAL_UART_GET_IT_SOURCE(huart, UART_IT_TC) != RESET) {
214+
if (__HAL_UART_GET_IT(huart, UART_IT_TC) != RESET) {
215215
irq_handler(serial_irq_ids[id], TxIrq);
216216
__HAL_UART_CLEAR_FLAG(huart, UART_CLEAR_TCF);
217217
}
218218
}
219219
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_RXNE) != RESET) {
220-
if (__HAL_UART_GET_IT_SOURCE(huart, UART_IT_RXNE) != RESET) {
220+
if (__HAL_UART_GET_IT(huart, UART_IT_RXNE) != RESET) {
221221
irq_handler(serial_irq_ids[id], RxIrq);
222222
volatile uint32_t tmpval = huart->Instance->RDR; // Clear RXNE flag
223223
UNUSED(tmpval);
224224
}
225225
}
226226
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_ORE) != RESET) {
227-
if (__HAL_UART_GET_IT_SOURCE(huart, UART_IT_ORE) != RESET) {
227+
if (__HAL_UART_GET_IT(huart, UART_IT_ORE) != RESET) {
228228
__HAL_UART_CLEAR_FLAG(huart, UART_CLEAR_OREF);
229229
}
230230
}
@@ -679,19 +679,19 @@ int serial_irq_handler_asynch(serial_t *obj)
679679

680680
// Handle error events
681681
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_PE) != RESET) {
682-
if (__HAL_UART_GET_IT_SOURCE(huart, USART_IT_ERR) != RESET) {
682+
if (__HAL_UART_GET_IT(huart, UART_IT_PE) != RESET) {
683683
return_event |= (SERIAL_EVENT_RX_PARITY_ERROR & obj_s->events);
684684
}
685685
}
686686

687687
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_FE) != RESET) {
688-
if (__HAL_UART_GET_IT_SOURCE(huart, USART_IT_ERR) != RESET) {
688+
if (__HAL_UART_GET_IT(huart, UART_IT_FE) != RESET) {
689689
return_event |= (SERIAL_EVENT_RX_FRAMING_ERROR & obj_s->events);
690690
}
691691
}
692692

693693
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_ORE) != RESET) {
694-
if (__HAL_UART_GET_IT_SOURCE(huart, USART_IT_ERR) != RESET) {
694+
if (__HAL_UART_GET_IT(huart, UART_IT_ORE) != RESET) {
695695
return_event |= (SERIAL_EVENT_RX_OVERRUN_ERROR & obj_s->events);
696696
}
697697
}

targets/TARGET_STM/TARGET_STM32F7/serial_device.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -239,19 +239,19 @@ static void uart_irq(int id)
239239

240240
if (serial_irq_ids[id] != 0) {
241241
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_TC) != RESET) {
242-
if (__HAL_UART_GET_IT_SOURCE(huart, UART_IT_TC) != RESET) {
242+
if (__HAL_UART_GET_IT(huart, UART_IT_TC) != RESET) {
243243
irq_handler(serial_irq_ids[id], TxIrq);
244244
__HAL_UART_CLEAR_IT(huart, UART_CLEAR_TCF);
245245
}
246246
}
247247
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_RXNE) != RESET) {
248-
if (__HAL_UART_GET_IT_SOURCE(huart, UART_IT_RXNE) != RESET) {
248+
if (__HAL_UART_GET_IT(huart, UART_IT_RXNE) != RESET) {
249249
irq_handler(serial_irq_ids[id], RxIrq);
250250
volatile uint32_t tmpval = huart->Instance->RDR; // Clear RXNE
251251
}
252252
}
253253
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_ORE) != RESET) {
254-
if (__HAL_UART_GET_IT_SOURCE(huart, UART_IT_ORE) != RESET) {
254+
if (__HAL_UART_GET_IT(huart, UART_IT_ORE) != RESET) {
255255
__HAL_UART_CLEAR_IT(huart, UART_CLEAR_OREF);
256256
}
257257
}
@@ -744,19 +744,19 @@ int serial_irq_handler_asynch(serial_t *obj)
744744

745745
// Handle error events
746746
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_PE) != RESET) {
747-
if (__HAL_UART_GET_IT_SOURCE(huart, USART_IT_ERR) != RESET) {
747+
if (__HAL_UART_GET_IT(huart, UART_IT_PE) != RESET) {
748748
return_event |= (SERIAL_EVENT_RX_PARITY_ERROR & obj_s->events);
749749
}
750750
}
751751

752752
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_FE) != RESET) {
753-
if (__HAL_UART_GET_IT_SOURCE(huart, USART_IT_ERR) != RESET) {
753+
if (__HAL_UART_GET_IT(huart, UART_IT_FE) != RESET) {
754754
return_event |= (SERIAL_EVENT_RX_FRAMING_ERROR & obj_s->events);
755755
}
756756
}
757757

758758
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_ORE) != RESET) {
759-
if (__HAL_UART_GET_IT_SOURCE(huart, USART_IT_ERR) != RESET) {
759+
if (__HAL_UART_GET_IT(huart, UART_IT_ORE) != RESET) {
760760
return_event |= (SERIAL_EVENT_RX_OVERRUN_ERROR & obj_s->events);
761761
}
762762
}

targets/TARGET_STM/TARGET_STM32L0/serial_device.c

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -202,19 +202,19 @@ static void uart_irq(int id)
202202

203203
if (serial_irq_ids[id] != 0) {
204204
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_TC) != RESET) {
205-
if (__HAL_UART_GET_IT_SOURCE(huart, UART_IT_TC) != RESET) {
205+
if (__HAL_UART_GET_IT(huart, UART_IT_TC) != RESET) {
206206
irq_handler(serial_irq_ids[id], TxIrq);
207207
__HAL_UART_CLEAR_FLAG(huart, UART_CLEAR_TCF);
208208
}
209209
}
210210
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_RXNE) != RESET) {
211-
if (__HAL_UART_GET_IT_SOURCE(huart, UART_IT_RXNE) != RESET) {
211+
if (__HAL_UART_GET_IT(huart, UART_IT_RXNE) != RESET) {
212212
irq_handler(serial_irq_ids[id], RxIrq);
213213
volatile uint32_t tmpval = huart->Instance->RDR; // Clear RXNE flag
214214
}
215215
}
216216
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_ORE) != RESET) {
217-
if (__HAL_UART_GET_IT_SOURCE(huart, UART_IT_ORE) != RESET) {
217+
if (__HAL_UART_GET_IT(huart, UART_IT_ORE) != RESET) {
218218
__HAL_UART_CLEAR_FLAG(huart, UART_CLEAR_OREF);
219219
}
220220
}
@@ -645,27 +645,27 @@ int serial_irq_handler_asynch(serial_t *obj)
645645

646646
// Handle error events
647647
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_PE) != RESET) {
648-
if (__HAL_UART_GET_IT_SOURCE(huart, USART_IT_ERR) != RESET) {
649648
__HAL_UART_CLEAR_FLAG(huart, UART_CLEAR_PEF);
649+
if (__HAL_UART_GET_IT(huart, USART_IT_ERR) != RESET) {
650650
return_event |= (SERIAL_EVENT_RX_PARITY_ERROR & obj_s->events);
651651
}
652652
}
653653

654654
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_FE) != RESET) {
655-
if (__HAL_UART_GET_IT_SOURCE(huart, USART_IT_ERR) != RESET) {
655+
if (__HAL_UART_GET_IT(huart, UART_IT_FE) != RESET) {
656656
__HAL_UART_CLEAR_FLAG(huart, UART_CLEAR_FEF);
657657
return_event |= (SERIAL_EVENT_RX_FRAMING_ERROR & obj_s->events);
658658
}
659659
}
660660

661661
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_NE) != RESET) {
662-
if (__HAL_UART_GET_IT_SOURCE(huart, USART_IT_ERR) != RESET) {
662+
if (__HAL_UART_GET_IT(huart, UART_IT_NE) != RESET) {
663663
__HAL_UART_CLEAR_FLAG(huart, UART_CLEAR_NEF);
664664
}
665665
}
666666

667667
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_ORE) != RESET) {
668-
if (__HAL_UART_GET_IT_SOURCE(huart, USART_IT_ERR) != RESET) {
668+
if (__HAL_UART_GET_IT(huart, UART_IT_ORE) != RESET) {
669669
__HAL_UART_CLEAR_FLAG(huart, UART_CLEAR_OREF);
670670
return_event |= (SERIAL_EVENT_RX_OVERRUN_ERROR & obj_s->events);
671671
}

targets/TARGET_STM/TARGET_STM32L4/serial_device.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -218,19 +218,19 @@ static void uart_irq(int id)
218218

219219
if (serial_irq_ids[id] != 0) {
220220
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_TC) != RESET) {
221-
if (__HAL_UART_GET_IT_SOURCE(huart, UART_IT_TC) != RESET) {
221+
if (__HAL_UART_GET_IT(huart, UART_IT_TC) != RESET) {
222222
irq_handler(serial_irq_ids[id], TxIrq);
223223
__HAL_UART_CLEAR_FLAG(huart, UART_FLAG_TC);
224224
}
225225
}
226226
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_RXNE) != RESET) {
227-
if (__HAL_UART_GET_IT_SOURCE(huart, UART_IT_RXNE) != RESET) {
227+
if (__HAL_UART_GET_IT(huart, UART_IT_RXNE) != RESET) {
228228
irq_handler(serial_irq_ids[id], RxIrq);
229229
__HAL_UART_CLEAR_FLAG(huart, UART_FLAG_RXNE);
230230
}
231231
}
232232
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_ORE) != RESET) {
233-
if (__HAL_UART_GET_IT_SOURCE(huart, UART_IT_ERR) != RESET) {
233+
if (__HAL_UART_GET_IT(huart, UART_IT_ORE) != RESET) {
234234
volatile uint32_t tmpval = huart->Instance->RDR; // Clear ORE flag
235235
}
236236
}
@@ -697,19 +697,19 @@ int serial_irq_handler_asynch(serial_t *obj)
697697

698698
// Handle error events
699699
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_PE) != RESET) {
700-
if (__HAL_UART_GET_IT_SOURCE(huart, USART_IT_ERR) != RESET) {
700+
if (__HAL_UART_GET_IT(huart, UART_IT_PE) != RESET) {
701701
return_event |= (SERIAL_EVENT_RX_PARITY_ERROR & obj_s->events);
702702
}
703703
}
704704

705705
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_FE) != RESET) {
706-
if (__HAL_UART_GET_IT_SOURCE(huart, USART_IT_ERR) != RESET) {
706+
if (__HAL_UART_GET_IT(huart, UART_IT_FE) != RESET) {
707707
return_event |= (SERIAL_EVENT_RX_FRAMING_ERROR & obj_s->events);
708708
}
709709
}
710710

711711
if (__HAL_UART_GET_FLAG(huart, UART_FLAG_ORE) != RESET) {
712-
if (__HAL_UART_GET_IT_SOURCE(huart, USART_IT_ERR) != RESET) {
712+
if (__HAL_UART_GET_IT(huart, UART_IT_ORE) != RESET) {
713713
return_event |= (SERIAL_EVENT_RX_OVERRUN_ERROR & obj_s->events);
714714
}
715715
}

0 commit comments

Comments
 (0)