Skip to content

Commit 5bd19c4

Browse files
author
Jarkko Paso
committed
MAC: Do not update framecounter for fhss channel retry
- Unless something was already sent after failure
1 parent c3a2c5c commit 5bd19c4

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

source/MAC/IEEE802_15_4/mac_mcps_sap.c

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1520,13 +1520,16 @@ static int8_t mcps_generic_packet_build(protocol_interface_rf_mac_setup_s *rf_pt
15201520

15211521
if (buffer->fcf_dsn.securityEnabled) {
15221522
//Remember to update security counter here!
1523-
buffer->aux_header.frameCounter = mac_mlme_framecounter_get(rf_ptr);
1523+
uint32_t new_frameCounter = mac_mlme_framecounter_get(rf_ptr);
1524+
// If buffer frame counter is set, this is FHSS channel retry, update frame counter only if something was sent after failure
1525+
if (!buffer->aux_header.frameCounter || ((new_frameCounter - buffer->aux_header.frameCounter) > 1)) {
1526+
buffer->aux_header.frameCounter = new_frameCounter;
1527+
//Increment security counter
1528+
mac_mlme_framecounter_increment(rf_ptr);
1529+
}
15241530
if (!mac_frame_security_parameters_init(&ccm_ptr, rf_ptr, buffer)) {
15251531
return -2;
15261532
}
1527-
//Increment security counter
1528-
mac_mlme_framecounter_increment(rf_ptr);
1529-
15301533
}
15311534

15321535
//Calculate Payload length here with IE extension

0 commit comments

Comments
 (0)