Skip to content

Commit 5e8d8e1

Browse files
Hasnain Virktheotherjimmy
authored andcommitted
Bug fix in setting data rate
Setting up user defined data rate was found broken maybe because of some rebase issue. Code has been setting always the default data rate and ignoring used defined values.
1 parent f7c0ce6 commit 5e8d8e1

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

features/lorawan/LoRaWANStack.cpp

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -332,7 +332,7 @@ lora_mac_status_t LoRaWANStack::send_frame_to_mac()
332332
{
333333
lora_mac_mcps_req_t mcps_req;
334334
lora_mac_status_t status;
335-
// LoRaMacTxInfo_t txInfo;
335+
lora_mac_mib_request_confirm_t mib_get_params;
336336

337337
GetPhyParams_t phy_params;
338338
PhyParam_t default_datarate;
@@ -353,7 +353,14 @@ lora_mac_status_t LoRaWANStack::send_frame_to_mac()
353353
mcps_req.f_buffer = _tx_msg.f_buffer;
354354
mcps_req.f_buffer_size = _tx_msg.f_buffer_size;
355355
mcps_req.req.confirmed.nb_trials = _tx_msg.message_u.confirmed.nb_trials;
356-
mcps_req.req.confirmed.datarate = default_datarate.Value;
356+
357+
mib_get_params.type = LORA_MIB_CHANNELS_DATARATE;
358+
if(mib_get_request(&mib_get_params) != LORA_MAC_STATUS_OK) {
359+
tr_debug("Couldn't get MIB parameters: Using default data rate");
360+
mcps_req.req.confirmed.datarate = default_datarate.Value;
361+
} else {
362+
mcps_req.req.confirmed.datarate = mib_get_params.param.channels_datarate;
363+
}
357364

358365
} else if (LORA_MCPS_PROPRIETARY == mcps_req.type) {
359366
mcps_req.f_buffer = _tx_msg.f_buffer;

0 commit comments

Comments
 (0)