Skip to content

Commit 6ee4c7e

Browse files
author
Deepika
committed
Fix doxygen warnings in 'features/filesystem'
1 parent f05e498 commit 6ee4c7e

File tree

7 files changed

+30
-16
lines changed

7 files changed

+30
-16
lines changed

features/filesystem/Dir.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,13 +58,12 @@ class Dir : public DirHandle {
5858

5959
/** Close a directory
6060
*
61-
* return 0 on success, negative error code on failure
61+
* @return 0 on success, negative error code on failure
6262
*/
6363
virtual int close();
6464

6565
/** Read the next directory entry
6666
*
67-
* @param path The buffer to read the null terminated path name in to
6867
* @param ent The directory entry to fill out
6968
* @return 1 on reading a filename, 0 at end of directory, negative error on failure
7069
*/

features/filesystem/FileSystem.h

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,11 +44,13 @@ class File;
4444
* Implementations must provide at minimum file operations and mount
4545
* operations for block devices.
4646
*
47-
* @Note Synchronization level: Set by subclass
47+
* @note Synchronization level: Set by subclass
4848
*/
4949
class FileSystem : public FileSystemLike {
5050
public:
5151
/** FileSystem lifetime
52+
*
53+
* @param name Name to add filesystem to tree as
5254
*/
5355
FileSystem(const char *name = NULL);
5456
virtual ~FileSystem() {}
@@ -114,7 +116,7 @@ class FileSystem : public FileSystemLike {
114116
/** Close a file
115117
*
116118
* @param file File handle
117-
* return 0 on success, negative error code on failure
119+
* @return 0 on success, negative error code on failure
118120
*/
119121
virtual int file_close(fs_file_t file) = 0;
120122

@@ -195,7 +197,7 @@ class FileSystem : public FileSystemLike {
195197
/** Close a directory
196198
*
197199
* @param dir Dir handle
198-
* return 0 on success, negative error code on failure
200+
* @return 0 on success, negative error code on failure
199201
*/
200202
virtual int dir_close(fs_dir_t dir);
201203

features/filesystem/bd/ChainingBlockDevice.h

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -43,21 +43,22 @@
4343
* // contains 96 blocks of size 512 bytes
4444
* BlockDevice *bds[] = {&mem1, &mem2};
4545
* ChainingBlockDevice chainmem(bds);
46+
* @endcode
4647
*/
4748
class ChainingBlockDevice : public BlockDevice
4849
{
4950
public:
5051
/** Lifetime of the memory block device
5152
*
52-
* @param bds Array of block devices to chain with sequential block addresses
53-
* @param count Number of block devices to chain
53+
* @param bds Array of block devices to chain with sequential block addresses
54+
* @param bd_count Number of block devices to chain
5455
* @note All block devices must have the same block size
5556
*/
5657
ChainingBlockDevice(BlockDevice **bds, size_t bd_count);
5758

5859
/** Lifetime of the memory block device
5960
*
60-
* @param bds Array of block devices to chain with sequential block addresses
61+
* @param bds Array of block devices to chain with sequential block addresses
6162
* @note All block devices must have the same block size
6263
*/
6364
template <size_t Size>
@@ -69,8 +70,6 @@ class ChainingBlockDevice : public BlockDevice
6970

7071
/** Lifetime of the memory block device
7172
*
72-
* @param bds Array of block devices to chain with sequential block addresses
73-
* @note All block devices must have the same block size
7473
*/
7574
virtual ~ChainingBlockDevice() {}
7675

features/filesystem/bd/HeapBlockDevice.h

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,14 +44,25 @@
4444
* printf("%s", block);
4545
* bd.deinit();
4646
* }
47+
* @endcode
4748
*/
4849
class HeapBlockDevice : public BlockDevice
4950
{
5051
public:
5152

5253
/** Lifetime of the memory block device
54+
*
55+
* @param size Size of the Block Device in bytes
56+
* @param block Block size in bytes
5357
*/
5458
HeapBlockDevice(bd_size_t size, bd_size_t block=512);
59+
/** Lifetime of the memory block device
60+
*
61+
* @param size Size of the Block Device in bytes
62+
* @param read Minimum read size required in bytes
63+
* @param program Minimum program size required in bytes
64+
* @param erase Minimum erase size required in bytes
65+
*/
5566
HeapBlockDevice(bd_size_t size, bd_size_t read, bd_size_t program, bd_size_t erase);
5667
virtual ~HeapBlockDevice();
5768

features/filesystem/bd/SlicingBlockDevice.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@
4444
*
4545
* // Create a block device that maps to the middle 32 blocks
4646
* SlicingBlockDevice slice3(&mem, 16*512, -16*512);
47+
* @endcode
4748
*/
4849
class SlicingBlockDevice : public BlockDevice
4950
{
@@ -62,7 +63,7 @@ class SlicingBlockDevice : public BlockDevice
6263
* @param bd Block device to back the SlicingBlockDevice
6364
* @param start Start block address to map to block 0, negative addresses
6465
* are calculated from the end of the underlying block device
65-
* @param stop End block address to mark the end of the block device,
66+
* @param end End block address to mark the end of the block device,
6667
* this block is not mapped, negative addresses are
6768
* calculated from the end of the underlying block device
6869
*/

features/filesystem/fat/FATFileSystem.h

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,8 @@ class FATFileSystem : public FileSystem {
5757
* volume and upto 16MiB for exFAT volume. If zero is given,
5858
* the default allocation unit size is selected by the underlying
5959
* filesystem, which depends on the volume size.
60+
*
61+
* @return 0 on success, negative error code on failure
6062
*/
6163
static int format(BlockDevice *bd, int allocation_unit = 0);
6264

@@ -126,15 +128,15 @@ class FATFileSystem : public FileSystem {
126128
/** Close a file
127129
*
128130
* @param file File handle
129-
* return 0 on success, negative error code on failure
131+
* @return 0 on success, negative error code on failure
130132
*/
131133
virtual int file_close(fs_file_t file);
132134

133135
/** Read the contents of a file into a buffer
134136
*
135137
* @param file File handle
136138
* @param buffer The buffer to read in to
137-
* @param size The number of bytes to read
139+
* @param len The number of bytes to read
138140
* @return The number of bytes read, 0 at end of file, negative error on failure
139141
*/
140142
virtual ssize_t file_read(fs_file_t file, void *buffer, size_t len);
@@ -143,7 +145,7 @@ class FATFileSystem : public FileSystem {
143145
*
144146
* @param file File handle
145147
* @param buffer The buffer to write from
146-
* @param size The number of bytes to write
148+
* @param len The number of bytes to write
147149
* @return The number of bytes written, negative error on failure
148150
*/
149151
virtual ssize_t file_write(fs_file_t file, const void *buffer, size_t len);
@@ -192,7 +194,7 @@ class FATFileSystem : public FileSystem {
192194
/** Close a directory
193195
*
194196
* @param dir Dir handle
195-
* return 0 on success, negative error code on failure
197+
* @return 0 on success, negative error code on failure
196198
*/
197199
virtual int dir_close(fs_dir_t dir);
198200

platform/DirHandle.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ class DirHandle {
5454

5555
/** Close a directory
5656
*
57-
* return 0 on success, negative error code on failure
57+
* @return 0 on success, negative error code on failure
5858
*/
5959
virtual int close() = 0;
6060

0 commit comments

Comments
 (0)