Skip to content

Commit 6efa4f2

Browse files
0xc01700xc0170
committed
unittest: fix style for empty functions
1 parent e80f2ff commit 6efa4f2

File tree

12 files changed

+454
-151
lines changed

12 files changed

+454
-151
lines changed

‎UNITTESTS/features/lorawan/loramac/Test_LoRaMac.cpp

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,13 @@ using namespace events;
2727

2828
class my_phy : public LoRaPHY {
2929
public:
30-
my_phy() {};
30+
my_phy()
31+
{
32+
};
3133

32-
virtual ~my_phy() {};
34+
virtual ~my_phy()
35+
{
36+
};
3337
};
3438

3539
class Test_LoRaMac : public testing::Test {

‎UNITTESTS/features/lorawan/loramacchannelplan/Test_LoRaMacChannelPlan.cpp

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,13 @@
2222

2323
class my_LoRaPHY : public LoRaPHY {
2424
public:
25-
my_LoRaPHY() {};
25+
my_LoRaPHY()
26+
{
27+
};
2628

27-
virtual ~my_LoRaPHY() {};
29+
virtual ~my_LoRaPHY()
30+
{
31+
};
2832
};
2933

3034

‎UNITTESTS/features/lorawan/loramaccommand/Test_LoRaMacCommand.cpp

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,13 @@
2222

2323
class my_LoRaPHY : public LoRaPHY {
2424
public:
25-
my_LoRaPHY() {};
25+
my_LoRaPHY()
26+
{
27+
};
2628

27-
virtual ~my_LoRaPHY() {};
29+
virtual ~my_LoRaPHY()
30+
{
31+
};
2832
};
2933

3034
uint8_t my_cb()

‎UNITTESTS/features/lorawan/loraphy/Test_LoRaPHY.cpp

Lines changed: 54 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,9 @@ class my_LoRaPHY : public LoRaPHY {
2727
phy_params.adr_ack_delay = 1;
2828
}
2929

30-
virtual ~my_LoRaPHY() {}
30+
virtual ~my_LoRaPHY()
31+
{
32+
}
3133

3234
loraphy_params_t &get_phy_params()
3335
{
@@ -38,46 +40,72 @@ class my_LoRaPHY : public LoRaPHY {
3840
class my_radio : public LoRaRadio {
3941
public:
4042

41-
virtual void init_radio(radio_events_t *events) {};
43+
virtual void init_radio(radio_events_t *events)
44+
{
45+
};
4246

43-
virtual void radio_reset() {};
47+
virtual void radio_reset()
48+
{
49+
};
4450

45-
virtual void sleep(void) {};
51+
virtual void sleep(void)
52+
{
53+
};
4654

47-
virtual void standby(void) {};
55+
virtual void standby(void)
56+
{
57+
};
4858

4959
virtual void set_rx_config(radio_modems_t modem, uint32_t bandwidth,
5060
uint32_t datarate, uint8_t coderate,
5161
uint32_t bandwidth_afc, uint16_t preamble_len,
5262
uint16_t symb_timeout, bool fix_len,
5363
uint8_t payload_len,
5464
bool crc_on, bool freq_hop_on, uint8_t hop_period,
55-
bool iq_inverted, bool rx_continuous) {};
65+
bool iq_inverted, bool rx_continuous)
66+
{
67+
};
5668

5769
virtual void set_tx_config(radio_modems_t modem, int8_t power, uint32_t fdev,
5870
uint32_t bandwidth, uint32_t datarate,
5971
uint8_t coderate, uint16_t preamble_len,
6072
bool fix_len, bool crc_on, bool freq_hop_on,
61-
uint8_t hop_period, bool iq_inverted, uint32_t timeout) {};
73+
uint8_t hop_period, bool iq_inverted, uint32_t timeout)
74+
{
75+
};
6276

63-
virtual void send(uint8_t *buffer, uint8_t size) {};
77+
virtual void send(uint8_t *buffer, uint8_t size)
78+
{
79+
};
6480

65-
virtual void receive(void) {};
81+
virtual void receive(void)
82+
{
83+
};
6684

67-
virtual void set_channel(uint32_t freq) {};
85+
virtual void set_channel(uint32_t freq)
86+
{
87+
};
6888

69-
virtual uint32_t random(void) {};
89+
virtual uint32_t random(void)
90+
{
91+
};
7092

7193
virtual uint8_t get_status(void)
7294
{
7395
return uint8_value;
7496
};
7597

76-
virtual void set_max_payload_length(radio_modems_t modem, uint8_t max) {};
98+
virtual void set_max_payload_length(radio_modems_t modem, uint8_t max)
99+
{
100+
};
77101

78-
virtual void set_public_network(bool enable) {};
102+
virtual void set_public_network(bool enable)
103+
{
104+
};
79105

80-
virtual uint32_t time_on_air(radio_modems_t modem, uint8_t pkt_len) {};
106+
virtual uint32_t time_on_air(radio_modems_t modem, uint8_t pkt_len)
107+
{
108+
};
81109

82110
virtual bool perform_carrier_sense(radio_modems_t modem,
83111
uint32_t freq,
@@ -87,18 +115,26 @@ class my_radio : public LoRaRadio {
87115
return bool_value;
88116
};
89117

90-
virtual void start_cad(void) {};
118+
virtual void start_cad(void)
119+
{
120+
};
91121

92122
virtual bool check_rf_frequency(uint32_t frequency)
93123
{
94124
return bool_value;
95125
};
96126

97-
virtual void set_tx_continuous_wave(uint32_t freq, int8_t power, uint16_t time) {};
127+
virtual void set_tx_continuous_wave(uint32_t freq, int8_t power, uint16_t time)
128+
{
129+
};
98130

99-
virtual void lock(void) {};
131+
virtual void lock(void)
132+
{
133+
};
100134

101-
virtual void unlock(void) {};
135+
virtual void unlock(void)
136+
{
137+
};
102138

103139
bool bool_value;
104140
uint8_t uint8_value;

‎UNITTESTS/features/lorawan/loraphyas923/Test_LoRaPHYAS923.cpp

Lines changed: 51 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -23,46 +23,72 @@
2323
class my_radio : public LoRaRadio {
2424
public:
2525

26-
virtual void init_radio(radio_events_t *events) {};
26+
virtual void init_radio(radio_events_t *events)
27+
{
28+
};
2729

28-
virtual void radio_reset() {};
30+
virtual void radio_reset()
31+
{
32+
};
2933

30-
virtual void sleep(void) {};
34+
virtual void sleep(void)
35+
{
36+
};
3137

32-
virtual void standby(void) {};
38+
virtual void standby(void)
39+
{
40+
};
3341

3442
virtual void set_rx_config(radio_modems_t modem, uint32_t bandwidth,
3543
uint32_t datarate, uint8_t coderate,
3644
uint32_t bandwidth_afc, uint16_t preamble_len,
3745
uint16_t symb_timeout, bool fix_len,
3846
uint8_t payload_len,
3947
bool crc_on, bool freq_hop_on, uint8_t hop_period,
40-
bool iq_inverted, bool rx_continuous) {};
48+
bool iq_inverted, bool rx_continuous)
49+
{
50+
};
4151

4252
virtual void set_tx_config(radio_modems_t modem, int8_t power, uint32_t fdev,
4353
uint32_t bandwidth, uint32_t datarate,
4454
uint8_t coderate, uint16_t preamble_len,
4555
bool fix_len, bool crc_on, bool freq_hop_on,
46-
uint8_t hop_period, bool iq_inverted, uint32_t timeout) {};
56+
uint8_t hop_period, bool iq_inverted, uint32_t timeout)
57+
{
58+
};
4759

48-
virtual void send(uint8_t *buffer, uint8_t size) {};
60+
virtual void send(uint8_t *buffer, uint8_t size)
61+
{
62+
};
4963

50-
virtual void receive(void) {};
64+
virtual void receive(void)
65+
{
66+
};
5167

52-
virtual void set_channel(uint32_t freq) {};
68+
virtual void set_channel(uint32_t freq)
69+
{
70+
};
5371

54-
virtual uint32_t random(void) {};
72+
virtual uint32_t random(void)
73+
{
74+
};
5575

5676
virtual uint8_t get_status(void)
5777
{
5878
return uint8_value;
5979
};
6080

61-
virtual void set_max_payload_length(radio_modems_t modem, uint8_t max) {};
81+
virtual void set_max_payload_length(radio_modems_t modem, uint8_t max)
82+
{
83+
};
6284

63-
virtual void set_public_network(bool enable) {};
85+
virtual void set_public_network(bool enable)
86+
{
87+
};
6488

65-
virtual uint32_t time_on_air(radio_modems_t modem, uint8_t pkt_len) {};
89+
virtual uint32_t time_on_air(radio_modems_t modem, uint8_t pkt_len)
90+
{
91+
};
6692

6793
virtual bool perform_carrier_sense(radio_modems_t modem,
6894
uint32_t freq,
@@ -72,18 +98,26 @@ class my_radio : public LoRaRadio {
7298
return bool_value;
7399
};
74100

75-
virtual void start_cad(void) {};
101+
virtual void start_cad(void)
102+
{
103+
};
76104

77105
virtual bool check_rf_frequency(uint32_t frequency)
78106
{
79107
return bool_value;
80108
};
81109

82-
virtual void set_tx_continuous_wave(uint32_t freq, int8_t power, uint16_t time) {};
110+
virtual void set_tx_continuous_wave(uint32_t freq, int8_t power, uint16_t time)
111+
{
112+
};
83113

84-
virtual void lock(void) {};
114+
virtual void lock(void)
115+
{
116+
};
85117

86-
virtual void unlock(void) {};
118+
virtual void unlock(void)
119+
{
120+
};
87121

88122
bool bool_value;
89123
uint8_t uint8_value;

0 commit comments

Comments
 (0)