address error sent when matching entry found. (#1695)

Author: deepakvenugopal

source/6LoWPAN/Thread/thread_extension_bbr.c

@@ -468,7 +468,7 @@ static int thread_pbbr_bb_qry_cb(int8_t service_id, uint8_t source_address[16],
        rloc_ptr = &rloc;
     }
 
-    uint32_t last_transaction_time = this->mlr_timeout > route->lifetime? this->mlr_timeout - route->lifetime : 0;
+    uint32_t last_transaction_time = 30;
     uint8_t *ml_eid_ptr = &route->prefix[8];// TODO MLEID needs to be stored in own structure route->info.info and support for dealloc made
 
     // This address is valid in our MESH
@@ -500,7 +500,7 @@ static int thread_pbbr_dua_duplicate_address_detection(int8_t service_id, uint8_
     }
 
     // We have pending request and received answer
-    if (memcmp(ml_eid_ptr,tr_ptr->ml_eid, 8) != 0){
+    if (memcmp(ml_eid_ptr,tr_ptr->ml_eid, 8) == 0){
         // Different ml_eid but same address means duplicate address detected
         thread_resolution_client_address_error(this->interface_id, tr_ptr->source_address, tr_ptr->target_eid, tr_ptr->ml_eid);
         ipv6_neighbour_t *neighbour_entry;
@@ -1068,6 +1068,9 @@ bool thread_extension_bbr_nd_query_process(protocol_interface_info_entry_t *cur,
 
 static void thread_extension_bbr_dad_process(protocol_interface_info_entry_t *cur, thread_pbbr_t *this, uint32_t seconds)
 {
+    if (!this) {
+        return;
+    }
     ns_list_foreach_safe(duplicate_dua_tr_t, cur_dup_tr, &duplicate_dua_tr_list) {
         if (cur_dup_tr->interface_id != cur->id) {
             continue;
@@ -1080,7 +1083,6 @@ static void thread_extension_bbr_dad_process(protocol_interface_info_entry_t *cu
             if (cur_dup_tr->dua_dad_repeat > 0) {
                 cur_dup_tr->ttl = THREAD_BBR_DUA_DAD_QUERY_TIMEOUT;
                 thread_border_router_bb_qry_send(this,cur_dup_tr->target_eid,NULL);
-                return;
             } else {
                 // dad completed
                 // send PRO_BB.ntf and delete dad entry