review comments addressed

Author: paul-szczepanek-arm

features/FEATURE_BLE/targets/TARGET_CORDIO_LL/mbed_lib.json

@@ -5,6 +5,11 @@
             "help": "Handle VS HCI commands. Valid values are 0 (ignore) and 1 (handle).",
             "value": 0,
             "macro_name": "LHCI_ENABLE_VS"
+        },
+        "uart-hci": {
+            "help": "Does the board have a UART HCI. Valid values are 0 and 1 (must provide UART through PAL).",
+            "value": 0,
+            "macro_name": "CHCI_TR_UART"
         }
     }
 }

features/FEATURE_BLE/targets/TARGET_CORDIO_LL/stack_adaptation/fake_lhci_drv.cpp

@@ -69,7 +69,7 @@ uint16_t FakeChciTrWrite(uint8_t prot, uint8_t controller_type, uint16_t len, ui
         break;
     }
 
-    return controllerToHostWrite(prot, hci_type, len, pData);
+    return ControllerToHostWrite(prot, hci_type, len, pData);
 }
 
 #ifdef __cplusplus

features/FEATURE_BLE/targets/TARGET_CORDIO_LL/stack_adaptation/fake_lhci_drv.h

@@ -30,13 +30,13 @@ extern "C" {
  * @param pData Data to be sent.
  * @return Number of bytes processed.
  */
-uint16_t controllerToHostWrite(uint8_t prot, uint8_t hci_type, uint16_t len, uint8_t *pData);
+uint16_t ControllerToHostWrite(uint8_t prot, uint8_t hci_type, uint16_t len, uint8_t *pData);
 
 /**
  * Send bytes from host to controller.
  *
  * @param prot Protocol, must be CHCI_TR_PROT_BLE.
- * @param type HCI type, HCI_ACL_TYPE or HCI_CMD_TYPE.
+ * @param hci_type HCI type, HCI_ACL_TYPE or HCI_CMD_TYPE.
  * @param len Buffer length.
  * @param pData Data to be sent.
  * @return Number of bytes processed.
@@ -47,7 +47,7 @@ uint16_t FakeChciTrRead(uint8_t prot, uint8_t hci_type, uint16_t len, uint8_t *p
  * Send bytes from controller to host.
  *
  * @param prot Protocol, must be CHCI_TR_PROT_BLE.
- * @param type Controller type, CHCI_TR_TYPE_DATA or CHCI_TR_TYPE_EVT.
+ * @param controller_type Controller type, CHCI_TR_TYPE_DATA or CHCI_TR_TYPE_EVT.
  * @param len Buffer length.
  * @param pData Data to be sent.
  * @return Number of bytes processed.

features/FEATURE_BLE/targets/TARGET_NORDIC/TARGET_NORDIC_CORDIO/TARGET_NRF5x/NRFCordioHCIDriver.cpp

@@ -227,8 +227,6 @@ ble::vendor::cordio::buf_pool_desc_t NRFCordioHCIDriver::get_buffer_pool_descrip
     return buf_pool_desc_t(buffer, pool_desc);
 }
 
-void PlatformLoadBdAddress(uint8_t *pDevAddr);
-
 void NRFCordioHCIDriver::do_initialize()
 {
 	if(_is_init) {

features/FEATURE_BLE/targets/TARGET_NORDIC/TARGET_NORDIC_CORDIO/TARGET_NRF5x/NRFCordioHCITransportDriver.cpp

@@ -56,7 +56,7 @@ extern "C" void chciDrvInit(void)
 }
 
 // Callback from Cordio stack
-extern "C" uint16_t controllerToHostWrite(uint8_t prot, uint8_t hci_type, uint16_t len, uint8_t *pData)
+extern "C" uint16_t ControllerToHostWrite(uint8_t prot, uint8_t hci_type, uint16_t len, uint8_t *pData)
 {
     WSF_ASSERT(prot == CHCI_TR_PROT_BLE);
 

features/FEATURE_BLE/targets/TARGET_NORDIC/TARGET_NORDIC_CORDIO/TARGET_NRF5x/mbed_lib.json

@@ -1,12 +1,5 @@
 {
     "name": "cordio-nordic-ll",
-    "config": {
-        "uart-hci": {
-            "help": "Does the board have a UART HCI. Valid values are 0 and 1 (must provide UART through PAL).",
-            "value": 0,
-            "macro_name": "CHCI_TR_UART"
-        }
-    },
     "macros": [
         "INIT_BROADCASTER",
         "INIT_OBSERVER",