Code clean and Keep time update at 16-bit.

Change-Id: Ica2efa76f1beb9106695eb2c1776b1b1c3979e31

Author: Juha Heiskanen

source/Service_Libs/etx/etx.c

@@ -121,13 +121,13 @@ static void etx_cache_entry_init(uint8_t attribute_index)
     storage->sample_count = 0;
 }
 
-static bool etx_update_possible(etx_sample_storage_t *storage, etx_storage_t *entry, uint8_t time)
+static bool etx_update_possible(etx_sample_storage_t *storage, etx_storage_t *entry, uint16_t time_update)
 {
-    if (storage->etx_timer && time) {
-        if (time >= storage->etx_timer) {
+    if (storage->etx_timer && time_update) {
+        if (time_update >= storage->etx_timer) {
             storage->etx_timer = 0;
         } else {
-            storage->etx_timer -= time;
+            storage->etx_timer -= time_update;
         }
     }
 
@@ -797,19 +797,12 @@ void etx_cache_timer(int8_t interface_id, uint16_t seconds_update)
         return;
     }
 
-    mac_neighbor_table_t *table_class = mac_neighbor_info(interface);
-    if (!table_class) {
-        return;
-    }
 
-    uint8_t update_seconds;
-    if (seconds_update > 255) {
-        update_seconds = 255;
-    } else {
-        update_seconds = seconds_update;
+    if (!mac_neighbor_info(interface)) {
+        return;
     }
 
-    ns_list_foreach(mac_neighbor_table_entry_t, neighbour, &table_class->neighbour_list) {
+    ns_list_foreach(mac_neighbor_table_entry_t, neighbour, &mac_neighbor_info(interface)->neighbour_list) {
 
         etx_storage_t *etx_entry = etx_storage_entry_get(interface_id, neighbour->index);
 
@@ -818,7 +811,7 @@ void etx_cache_timer(int8_t interface_id, uint16_t seconds_update)
         }
         etx_sample_storage_t *storage = etx_info.etx_cache_storage_list + neighbour->index;
 
-        if (etx_update_possible(storage, etx_entry, update_seconds)) {
+        if (etx_update_possible(storage, etx_entry, seconds_update)) {
             etx_calculation(etx_entry, storage->attempts_count, storage->received_acks, neighbour->index);
         }
     }