Making sure that RX slots open after state change

Hasnain Virk · Hasnain Virk · commit 8d4cda11f740 · 2018-10-16T12:23:21.000+03:00
After transmission we should change the state before invoking opening of
slots as we may start receiving in the rx slots and the state would
suddenly change from SENDING to RECEIVING without going through the
ACK_WAIT state (in case of CONFIRMED messages). Tests show that after
this slight adjustment, our number of ack retries have significantly
reduced.
diff --git a/features/lorawan/LoRaWANStack.cpp b/features/lorawan/LoRaWANStack.cpp
@@ -576,7 +576,6 @@ void LoRaWANStack::process_transmission_timeout()
 void LoRaWANStack::process_transmission(void)
 {
     tr_debug("Transmission completed");
-    _loramac.on_radio_tx_done(_tx_timestamp);
 
     if (_device_current_state == DEVICE_STATE_JOINING) {
         _device_current_state = DEVICE_STATE_AWAITING_JOIN_ACCEPT;
@@ -588,6 +587,8 @@ void LoRaWANStack::process_transmission(void)
             _device_current_state = DEVICE_STATE_AWAITING_ACK;
         }
     }
+
+    _loramac.on_radio_tx_done(_tx_timestamp);
 }
 
 void LoRaWANStack::post_process_tx_with_reception()

Original file line number	Diff line number	Diff line change
`@@ -576,7 +576,6 @@ void LoRaWANStack::process_transmission_timeout()`
`576`	`576`	`void LoRaWANStack::process_transmission(void)`
`577`	`577`	`{`
`578`	`578`	`tr_debug("Transmission completed");`
`579`		`- _loramac.on_radio_tx_done(_tx_timestamp);`
`580`	`579`
`581`	`580`	`if (_device_current_state == DEVICE_STATE_JOINING) {`
`582`	`581`	`_device_current_state = DEVICE_STATE_AWAITING_JOIN_ACCEPT;`
`@@ -588,6 +587,8 @@ void LoRaWANStack::process_transmission(void)`
`588`	`587`	`_device_current_state = DEVICE_STATE_AWAITING_ACK;`
`589`	`588`	`}`
`590`	`589`	`}`
	`590`	`+`
	`591`	`+ _loramac.on_radio_tx_done(_tx_timestamp);`
`591`	`592`	`}`
`592`	`593`
`593`	`594`	`void LoRaWANStack::post_process_tx_with_reception()`