Skip to content

Commit 8db370c

Browse files
author
Mirela Chirica
committed
Cellular: Fix sim greentea tests for BC95 modem
1 parent c0b8a11 commit 8db370c

File tree

3 files changed

+16
-4
lines changed

3 files changed

+16
-4
lines changed

features/cellular/TESTS/api/cellular_sim/main.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -110,20 +110,20 @@ static void test_sim_interface()
110110
// change pin and change it back
111111
wait(1);
112112
err = sim->change_pin(MBED_CONF_APP_CELLULAR_SIM_PIN, pin);
113-
TEST_ASSERT(err == NSAPI_ERROR_OK);
113+
TEST_ASSERT(err == NSAPI_ERROR_OK || err == NSAPI_ERROR_UNSUPPORTED);
114114

115115
wait(1);
116116
err = sim->change_pin(pin, MBED_CONF_APP_CELLULAR_SIM_PIN);
117-
TEST_ASSERT(err == NSAPI_ERROR_OK);
117+
TEST_ASSERT(err == NSAPI_ERROR_OK || err == NSAPI_ERROR_UNSUPPORTED);
118118

119119
// 3. test set_pin_query
120120
wait(1);
121121
err = sim->set_pin_query(MBED_CONF_APP_CELLULAR_SIM_PIN, false);
122-
TEST_ASSERT(err == NSAPI_ERROR_OK);
122+
TEST_ASSERT(err == NSAPI_ERROR_OK || err == NSAPI_ERROR_UNSUPPORTED);
123123

124124
wait(1);
125125
err = sim->set_pin_query(MBED_CONF_APP_CELLULAR_SIM_PIN, true);
126-
TEST_ASSERT(err == NSAPI_ERROR_OK);
126+
TEST_ASSERT(err == NSAPI_ERROR_OK || err == NSAPI_ERROR_UNSUPPORTED);
127127

128128
wait(1);
129129
// 4. test get_sim_state

features/cellular/framework/targets/QUECTEL/BC95/QUECTEL_BC95_CellularSIM.cpp

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,3 +58,13 @@ nsapi_error_t QUECTEL_BC95_CellularSIM::get_iccid(char *buf, size_t buf_size)
5858
_at.resp_stop();
5959
return _at.unlock_return_error();
6060
}
61+
62+
nsapi_error_t QUECTEL_BC95_CellularSIM::change_pin(const char *sim_pin, const char *new_pin)
63+
{
64+
return NSAPI_ERROR_UNSUPPORTED;
65+
}
66+
67+
nsapi_error_t QUECTEL_BC95_CellularSIM::set_pin_query(const char *sim_pin, bool query_pin)
68+
{
69+
return NSAPI_ERROR_UNSUPPORTED;
70+
}

features/cellular/framework/targets/QUECTEL/BC95/QUECTEL_BC95_CellularSIM.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,8 @@ class QUECTEL_BC95_CellularSIM : public AT_CellularSIM {
3030
public: //from CellularSIM
3131
virtual nsapi_error_t get_sim_state(SimState &state);
3232
virtual nsapi_error_t get_iccid(char *buf, size_t buf_size);
33+
virtual nsapi_error_t change_pin(const char *sim_pin, const char *new_pin);
34+
virtual nsapi_error_t set_pin_query(const char *sim_pin, bool query_pin);
3335
};
3436

3537
} // namespace mbed

0 commit comments

Comments
 (0)