Skip to content

Commit 9204c6f

Browse files
committed
fix - added proper code of cmsis_nvic.c for regular nrf51 target
1 parent 8302ce0 commit 9204c6f

File tree

1 file changed

+7
-67
lines changed
  • targets/TARGET_NORDIC/TARGET_NRF5/TARGET_MCU_NRF51822_UNIFIED/device

1 file changed

+7
-67
lines changed

targets/TARGET_NORDIC/TARGET_NRF5/TARGET_MCU_NRF51822_UNIFIED/device/cmsis_nvic.c

Lines changed: 7 additions & 67 deletions
Original file line numberDiff line numberDiff line change
@@ -30,74 +30,14 @@
3030
*/
3131
#include "cmsis_nvic.h"
3232

33-
/* In the M0, there is no VTOR. In the LPC range such as the LPC11U,
34-
* whilst the vector table may only be something like 48 entries (192 bytes, 0xC0),
35-
* the SYSMEMREMAP register actually remaps the memory from 0x10000000-0x100001FF
36-
* to adress 0x0-0x1FF. In this case, RAM can be addressed at both 0x10000000 and 0x0
37-
*
38-
* If we just copy the vectors to RAM and switch the SYSMEMMAP, any accesses to FLASH
39-
* above the vector table before 0x200 will actually go to RAM. So we need to provide
40-
* a solution where the compiler gets the right results based on the memory map
41-
*
42-
* Option 1 - We allocate and copy 0x200 of RAM rather than just the table
43-
* - const data and instructions before 0x200 will be copied to and fetched/exec from RAM
44-
* - RAM overhead: 0x200 - 0xC0 = 320 bytes, FLASH overhead: 0
45-
*
46-
* Option 2 - We pad the flash to 0x200 to ensure the compiler doesn't allocate anything there
47-
* - No flash accesses will go to ram, as there will be nothing there
48-
* - RAM only needs to be allocated for the vectors, as all other ram addresses are normal
49-
* - RAM overhead: 0, FLASH overhead: 320 bytes
50-
*
51-
* Option 2 is the one to go for, as RAM is the most valuable resource
52-
*/
53-
54-
55-
#define NVIC_RAM_VECTOR_ADDRESS (0x10000000) // Location of vectors in RAM
56-
#define NVIC_FLASH_VECTOR_ADDRESS (0x0) // Initial vector position in flash
57-
/*
58-
void NVIC_SetVector(IRQn_Type IRQn, uint32_t vector) {
59-
uint32_t *vectors = (uint32_t*)SCB->VTOR;
60-
uint32_t i;
33+
extern uint32_t nrf_dispatch_vector[NVIC_NUM_VECTORS];
6134

62-
// Copy and switch to dynamic vectors if the first time called
63-
if (SCB->VTOR == NVIC_FLASH_VECTOR_ADDRESS) {
64-
uint32_t *old_vectors = vectors;
65-
vectors = (uint32_t*)NVIC_RAM_VECTOR_ADDRESS;
66-
for (i=0; i<NVIC_NUM_VECTORS; i++) {
67-
vectors[i] = old_vectors[i];
68-
}
69-
SCB->VTOR = (uint32_t)NVIC_RAM_VECTOR_ADDRESS;
70-
}
71-
vectors[IRQn + 16] = vector;
35+
void NVIC_SetVector(IRQn_Type IRQn, uint32_t vector)
36+
{
37+
nrf_dispatch_vector[IRQn + NVIC_USER_IRQ_OFFSET] = vector;
7238
}
7339

74-
uint32_t NVIC_GetVector(IRQn_Type IRQn) {
75-
uint32_t *vectors = (uint32_t*)SCB->VTOR;
76-
return vectors[IRQn + 16];
77-
}*/
78-
79-
void NVIC_SetVector(IRQn_Type IRQn, uint32_t vector) {
80-
// int i;
81-
// Space for dynamic vectors, initialised to allocate in R/W
82-
static volatile uint32_t* vectors = (uint32_t*)NVIC_RAM_VECTOR_ADDRESS;
83-
/*
84-
// Copy and switch to dynamic vectors if first time called
85-
if((LPC_SYSCON->SYSMEMREMAP & 0x3) != 0x1) {
86-
uint32_t *old_vectors = (uint32_t *)0; // FLASH vectors are at 0x0
87-
for(i = 0; i < NVIC_NUM_VECTORS; i++) {
88-
vectors[i] = old_vectors[i];
89-
}
90-
LPC_SYSCON->SYSMEMREMAP = 0x1; // Remaps 0x0-0x1FF FLASH block to RAM block
91-
}*/
92-
93-
// Set the vector
94-
vectors[IRQn + 16] = vector;
95-
}
96-
97-
uint32_t NVIC_GetVector(IRQn_Type IRQn) {
98-
// We can always read vectors at 0x0, as the addresses are remapped
99-
uint32_t *vectors = (uint32_t*)0;
100-
101-
// Return the vector
102-
return vectors[IRQn + 16];
40+
uint32_t NVIC_GetVector(IRQn_Type IRQn)
41+
{
42+
return nrf_dispatch_vector[IRQn + NVIC_USER_IRQ_OFFSET];
10343
}

0 commit comments

Comments
 (0)