Cellular: Add AT handler buffer size to configuration

boraozgen · boraozgen · commit 9795b39bb7da · 2021-06-09T13:58:43.000+02:00
diff --git a/UNITTESTS/stubs/connectivity/CMakeLists.txt b/UNITTESTS/stubs/connectivity/CMakeLists.txt
@@ -13,6 +13,7 @@ target_compile_definitions(mbed-stubs-connectivity
         MBED_CONF_LORA_OVER_THE_AIR_ACTIVATION=true
         MBED_CONF_LORA_AUTOMATIC_UPLINK_MESSAGE=true
         MBED_CONF_LORA_TX_MAX_SIZE=255
+        MBED_CONF_CELLULAR_AT_HANDLER_BUFFER_SIZE=32
         MDMTXD=NC
         MDMRXD=NC
 )
diff --git a/connectivity/cellular/include/cellular/framework/API/ATHandler.h b/connectivity/cellular/include/cellular/framework/API/ATHandler.h
@@ -50,8 +50,6 @@ class FileHandle;
 extern const char *OK;
 extern const char *CRLF;
 
-#define BUFF_SIZE 32
-
 /* AT Error types enumeration */
 enum DeviceErrorType {
     DeviceErrorTypeNoError = 0,
@@ -114,7 +112,7 @@ class ATHandler {
 
     /** Set callback function for URC
      *
-     *  @param prefix   URC text to look for, e.g. "+CMTI:". Maximum length is BUFF_SIZE.
+     *  @param prefix   URC text to look for, e.g. "+CMTI:". Maximum length is MBED_CONF_CELLULAR_AT_HANDLER_BUFFER_SIZE.
      *  @param callback function to call on prefix, or 0 to remove callback
      */
     void set_urc_handler(const char *prefix, Callback<void()> callback);
@@ -601,7 +599,7 @@ class ATHandler {
     bool _is_fh_usable;
 
     // should fit any prefix and int
-    char _recv_buff[BUFF_SIZE];
+    char _recv_buff[MBED_CONF_CELLULAR_AT_HANDLER_BUFFER_SIZE];
     // reading position
     size_t _recv_len;
     // reading length
@@ -630,7 +628,7 @@ class ATHandler {
     size_t _max_resp_length;
 
     // prefix set during resp_start and used to try matching possible information responses
-    char _info_resp_prefix[BUFF_SIZE];
+    char _info_resp_prefix[MBED_CONF_CELLULAR_AT_HANDLER_BUFFER_SIZE];
     bool _debug_on;
     bool _cmd_start;
     bool _use_delimiter;
@@ -640,7 +638,7 @@ class ATHandler {
     // eventqueue event id
     int _event_id;
 
-    char _cmd_buffer[BUFF_SIZE];
+    char _cmd_buffer[MBED_CONF_CELLULAR_AT_HANDLER_BUFFER_SIZE];
 };
 
 } // namespace mbed
diff --git a/connectivity/cellular/mbed_lib.json b/connectivity/cellular/mbed_lib.json
@@ -44,6 +44,10 @@
         "plmn-fallback-auto" : {
             "help": "If manual PLMN is selected, use mode 4 manual/automatic in AT+COPS to try automatic mode if manual selection fails. Set to null to disable",
             "value": null
+        },
+        "at-handler-buffer-size" : {
+            "help": "Size of the AT handler buffer",
+            "value": 32
         }
     }
 }
diff --git a/connectivity/cellular/source/framework/device/ATHandler.cpp b/connectivity/cellular/source/framework/device/ATHandler.cpp
@@ -683,7 +683,7 @@ int32_t ATHandler::read_int()
         return -1;
     }
 
-    char buff[BUFF_SIZE];
+    char buff[MBED_CONF_CELLULAR_AT_HANDLER_BUFFER_SIZE];
     if (read_string(buff, sizeof(buff)) == 0) {
         return -1;
     }
@@ -960,7 +960,7 @@ void ATHandler::resp_start(const char *prefix, bool stop)
     (void)fill_buffer(false);
 
     if (prefix) {
-        MBED_ASSERT(strlen(prefix) < BUFF_SIZE);
+        MBED_ASSERT(strlen(prefix) < MBED_CONF_CELLULAR_AT_HANDLER_BUFFER_SIZE);
         strcpy(_info_resp_prefix, prefix); // copy prefix so we can later use it without having to provide again for info_resp
     }
 
@@ -1225,7 +1225,7 @@ void ATHandler::handle_start(const char *cmd, const char *cmd_chr)
     if (cmd_chr) {
         cmd_char_len = strlen(cmd_chr);
     }
-    MBED_ASSERT((3 + strlen(cmd) + cmd_char_len) < BUFF_SIZE);
+    MBED_ASSERT((3 + strlen(cmd) + cmd_char_len) < MBED_CONF_CELLULAR_AT_HANDLER_BUFFER_SIZE);
 
     memcpy(_cmd_buffer + len, cmd, strlen(cmd));
     len += strlen(cmd);
@@ -1258,7 +1258,7 @@ void ATHandler::cmd_start_stop(const char *cmd, const char *cmd_chr, const char
 
 nsapi_error_t ATHandler::at_cmd_str(const char *cmd, const char *cmd_chr, char *resp_buf, size_t buf_size, const char *format, ...)
 {
-    MBED_ASSERT(strlen(cmd) < BUFF_SIZE);
+    MBED_ASSERT(strlen(cmd) < MBED_CONF_CELLULAR_AT_HANDLER_BUFFER_SIZE);
     lock();
 
     handle_start(cmd, cmd_chr);
diff --git a/connectivity/cellular/tests/UNITTESTS/framework/AT/at_cellularcontext/CMakeLists.txt b/connectivity/cellular/tests/UNITTESTS/framework/AT/at_cellularcontext/CMakeLists.txt
@@ -12,6 +12,7 @@ target_compile_definitions(${TEST_NAME}
         MBED_CONF_CELLULAR_USE_SMS=1
         MBED_CONF_NSAPI_DEFAULT_CELLULAR_APN=NULL
         MBED_CONF_PLATFORM_DEFAULT_SERIAL_BAUD_RATE=115200
+        MBED_CONF_CELLULAR_AT_HANDLER_BUFFER_SIZE=32
 )
 
 target_sources(${TEST_NAME}
diff --git a/connectivity/cellular/tests/UNITTESTS/framework/AT/at_cellulardevice/CMakeLists.txt b/connectivity/cellular/tests/UNITTESTS/framework/AT/at_cellulardevice/CMakeLists.txt
@@ -18,6 +18,7 @@ target_compile_definitions(${TEST_NAME}
         MDMRXD=NC
         MBED_CONF_PLATFORM_DEFAULT_SERIAL_BAUD_RATE=115200
         MBED_CONF_CELLULAR_USE_SMS=1
+        MBED_CONF_CELLULAR_AT_HANDLER_BUFFER_SIZE=32
 )
 
 target_sources(${TEST_NAME}
diff --git a/connectivity/cellular/tests/UNITTESTS/framework/AT/at_cellularinformation/CMakeLists.txt b/connectivity/cellular/tests/UNITTESTS/framework/AT/at_cellularinformation/CMakeLists.txt
@@ -10,6 +10,7 @@ target_compile_definitions(${TEST_NAME}
         DEVICE_SERIAL=1
         DEVICE_INTERRUPTIN=1
         MBED_CONF_PLATFORM_DEFAULT_SERIAL_BAUD_RATE=115200
+        MBED_CONF_CELLULAR_AT_HANDLER_BUFFER_SIZE=32
 )
 
 target_sources(${TEST_NAME}
diff --git a/connectivity/cellular/tests/UNITTESTS/framework/AT/at_cellularnetwork/CMakeLists.txt b/connectivity/cellular/tests/UNITTESTS/framework/AT/at_cellularnetwork/CMakeLists.txt
@@ -10,6 +10,7 @@ target_compile_definitions(${TEST_NAME}
         DEVICE_SERIAL=1
         DEVICE_INTERRUPTIN=1
         MBED_CONF_PLATFORM_DEFAULT_SERIAL_BAUD_RATE=115200
+        MBED_CONF_CELLULAR_AT_HANDLER_BUFFER_SIZE=32
 )
 
 target_sources(${TEST_NAME}
diff --git a/connectivity/cellular/tests/UNITTESTS/framework/AT/at_cellularsms/CMakeLists.txt b/connectivity/cellular/tests/UNITTESTS/framework/AT/at_cellularsms/CMakeLists.txt
@@ -11,6 +11,7 @@ target_compile_definitions(${TEST_NAME}
         DEVICE_INTERRUPTIN=1
         MBED_CONF_PLATFORM_DEFAULT_SERIAL_BAUD_RATE=115200
         MBED_CONF_CELLULAR_USE_SMS=1
+        MBED_CONF_CELLULAR_AT_HANDLER_BUFFER_SIZE=32
 )
 
 target_sources(${TEST_NAME}
diff --git a/connectivity/cellular/tests/UNITTESTS/framework/AT/at_cellularstack/CMakeLists.txt b/connectivity/cellular/tests/UNITTESTS/framework/AT/at_cellularstack/CMakeLists.txt
@@ -10,6 +10,7 @@ target_compile_definitions(${TEST_NAME}
         DEVICE_SERIAL=1
         DEVICE_INTERRUPTIN=1
         MBED_CONF_PLATFORM_DEFAULT_SERIAL_BAUD_RATE=115200
+        MBED_CONF_CELLULAR_AT_HANDLER_BUFFER_SIZE=32
 )
 
 target_sources(${TEST_NAME}
diff --git a/connectivity/cellular/tests/UNITTESTS/framework/device/athandler/CMakeLists.txt b/connectivity/cellular/tests/UNITTESTS/framework/device/athandler/CMakeLists.txt
@@ -12,6 +12,7 @@ target_compile_definitions(${TEST_NAME}
         DEVICE_SERIAL=1
         DEVICE_INTERRUPTIN=1
         MBED_CONF_PLATFORM_DEFAULT_SERIAL_BAUD_RATE=115200
+        MBED_CONF_CELLULAR_AT_HANDLER_BUFFER_SIZE=32
 )
 
 target_sources(${TEST_NAME}
diff --git a/connectivity/cellular/tests/UNITTESTS/framework/device/cellularcontext/CMakeLists.txt b/connectivity/cellular/tests/UNITTESTS/framework/device/cellularcontext/CMakeLists.txt
@@ -18,6 +18,7 @@ target_compile_definitions(${TEST_NAME}
         DEVICE_SERIAL=1
         DEVICE_INTERRUPTIN=1
         MBED_CONF_PLATFORM_DEFAULT_SERIAL_BAUD_RATE=115200
+        MBED_CONF_CELLULAR_AT_HANDLER_BUFFER_SIZE=32
 )
 
 target_sources(${TEST_NAME}
diff --git a/connectivity/cellular/tests/UNITTESTS/framework/device/cellulardevice/CMakeLists.txt b/connectivity/cellular/tests/UNITTESTS/framework/device/cellulardevice/CMakeLists.txt
@@ -16,6 +16,7 @@ target_compile_definitions(${TEST_NAME}
         DEVICE_SERIAL=1
         DEVICE_INTERRUPTIN=1
         MBED_CONF_PLATFORM_DEFAULT_SERIAL_BAUD_RATE=115200
+        MBED_CONF_CELLULAR_AT_HANDLER_BUFFER_SIZE=32
 )
 
 target_sources(${TEST_NAME}
diff --git a/connectivity/cellular/tests/UNITTESTS/framework/device/cellularstatemachine/CMakeLists.txt b/connectivity/cellular/tests/UNITTESTS/framework/device/cellularstatemachine/CMakeLists.txt
@@ -17,6 +17,7 @@ target_compile_definitions(${TEST_NAME}
         DEVICE_SERIAL=1
         DEVICE_INTERRUPTIN=1
         MBED_CONF_PLATFORM_DEFAULT_SERIAL_BAUD_RATE=115200
+        MBED_CONF_CELLULAR_AT_HANDLER_BUFFER_SIZE=32
 )
 
 target_sources(${TEST_NAME}

Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,7 @@ target_compile_definitions(mbed-stubs-connectivity`
`13`	`13`	`MBED_CONF_LORA_OVER_THE_AIR_ACTIVATION=true`
`14`	`14`	`MBED_CONF_LORA_AUTOMATIC_UPLINK_MESSAGE=true`
`15`	`15`	`MBED_CONF_LORA_TX_MAX_SIZE=255`
	`16`	`+ MBED_CONF_CELLULAR_AT_HANDLER_BUFFER_SIZE=32`
`16`	`17`	`MDMTXD=NC`
`17`	`18`	`MDMRXD=NC`
`18`	`19`	`)`
Original file line number	Diff line number	Diff line change
`@@ -44,6 +44,10 @@`
`44`	`44`	`"plmn-fallback-auto" : {`
`45`	`45`	`"help": "If manual PLMN is selected, use mode 4 manual/automatic in AT+COPS to try automatic mode if manual selection fails. Set to null to disable",`
`46`	`46`	`"value": null`
	`47`	`+ },`
	`48`	`+ "at-handler-buffer-size" : {`
	`49`	`+ "help": "Size of the AT handler buffer",`
	`50`	`+ "value": 32`
`47`	`51`	`}`
`48`	`52`	`}`
`49`	`53`	`}`
Original file line number	Diff line number	Diff line change
`@@ -683,7 +683,7 @@ int32_t ATHandler::read_int()`
`683`	`683`	`return -1;`
`684`	`684`	`}`
`685`	`685`
`686`		`- char buff[BUFF_SIZE];`
	`686`	`+ char buff[MBED_CONF_CELLULAR_AT_HANDLER_BUFFER_SIZE];`
`687`	`687`	`if (read_string(buff, sizeof(buff)) == 0) {`
`688`	`688`	`return -1;`
`689`	`689`	`}`
`@@ -960,7 +960,7 @@ void ATHandler::resp_start(const char *prefix, bool stop)`
`960`	`960`	`(void)fill_buffer(false);`
`961`	`961`
`962`	`962`	`if (prefix) {`
`963`		`- MBED_ASSERT(strlen(prefix) < BUFF_SIZE);`
	`963`	`+ MBED_ASSERT(strlen(prefix) < MBED_CONF_CELLULAR_AT_HANDLER_BUFFER_SIZE);`
`964`	`964`	`strcpy(_info_resp_prefix, prefix); // copy prefix so we can later use it without having to provide again for info_resp`
`965`	`965`	`}`
`966`	`966`
`@@ -1225,7 +1225,7 @@ void ATHandler::handle_start(const char cmd, const char cmd_chr)`
`1225`	`1225`	`if (cmd_chr) {`
`1226`	`1226`	`cmd_char_len = strlen(cmd_chr);`
`1227`	`1227`	`}`
`1228`		`- MBED_ASSERT((3 + strlen(cmd) + cmd_char_len) < BUFF_SIZE);`
	`1228`	`+ MBED_ASSERT((3 + strlen(cmd) + cmd_char_len) < MBED_CONF_CELLULAR_AT_HANDLER_BUFFER_SIZE);`
`1229`	`1229`
`1230`	`1230`	`memcpy(_cmd_buffer + len, cmd, strlen(cmd));`
`1231`	`1231`	`len += strlen(cmd);`
`@@ -1258,7 +1258,7 @@ void ATHandler::cmd_start_stop(const char cmd, const char cmd_chr, const char`
`1258`	`1258`
`1259`	`1259`	`nsapi_error_t ATHandler::at_cmd_str(const char cmd, const char cmd_chr, char resp_buf, size_t buf_size, const char format, ...)`
`1260`	`1260`	`{`
`1261`		`- MBED_ASSERT(strlen(cmd) < BUFF_SIZE);`
	`1261`	`+ MBED_ASSERT(strlen(cmd) < MBED_CONF_CELLULAR_AT_HANDLER_BUFFER_SIZE);`
`1262`	`1262`	`lock();`
`1263`	`1263`
`1264`	`1264`	`handle_start(cmd, cmd_chr);`
Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,7 @@ target_compile_definitions(${TEST_NAME}`
`12`	`12`	`MBED_CONF_CELLULAR_USE_SMS=1`
`13`	`13`	`MBED_CONF_NSAPI_DEFAULT_CELLULAR_APN=NULL`
`14`	`14`	`MBED_CONF_PLATFORM_DEFAULT_SERIAL_BAUD_RATE=115200`
	`15`	`+ MBED_CONF_CELLULAR_AT_HANDLER_BUFFER_SIZE=32`
`15`	`16`	`)`
`16`	`17`
`17`	`18`	`target_sources(${TEST_NAME}`
Original file line number	Diff line number	Diff line change
`@@ -18,6 +18,7 @@ target_compile_definitions(${TEST_NAME}`
`18`	`18`	`MDMRXD=NC`
`19`	`19`	`MBED_CONF_PLATFORM_DEFAULT_SERIAL_BAUD_RATE=115200`
`20`	`20`	`MBED_CONF_CELLULAR_USE_SMS=1`
	`21`	`+ MBED_CONF_CELLULAR_AT_HANDLER_BUFFER_SIZE=32`
`21`	`22`	`)`
`22`	`23`
`23`	`24`	`target_sources(${TEST_NAME}`
Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,7 @@ target_compile_definitions(${TEST_NAME}`
`10`	`10`	`DEVICE_SERIAL=1`
`11`	`11`	`DEVICE_INTERRUPTIN=1`
`12`	`12`	`MBED_CONF_PLATFORM_DEFAULT_SERIAL_BAUD_RATE=115200`
	`13`	`+ MBED_CONF_CELLULAR_AT_HANDLER_BUFFER_SIZE=32`
`13`	`14`	`)`
`14`	`15`
`15`	`16`	`target_sources(${TEST_NAME}`
Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,7 @@ target_compile_definitions(${TEST_NAME}`
`11`	`11`	`DEVICE_INTERRUPTIN=1`
`12`	`12`	`MBED_CONF_PLATFORM_DEFAULT_SERIAL_BAUD_RATE=115200`
`13`	`13`	`MBED_CONF_CELLULAR_USE_SMS=1`
	`14`	`+ MBED_CONF_CELLULAR_AT_HANDLER_BUFFER_SIZE=32`
`14`	`15`	`)`
`15`	`16`
`16`	`17`	`target_sources(${TEST_NAME}`
Original file line number	Diff line number	Diff line change
`@@ -16,6 +16,7 @@ target_compile_definitions(${TEST_NAME}`
`16`	`16`	`DEVICE_SERIAL=1`
`17`	`17`	`DEVICE_INTERRUPTIN=1`
`18`	`18`	`MBED_CONF_PLATFORM_DEFAULT_SERIAL_BAUD_RATE=115200`
	`19`	`+ MBED_CONF_CELLULAR_AT_HANDLER_BUFFER_SIZE=32`
`19`	`20`	`)`
`20`	`21`
`21`	`22`	`target_sources(${TEST_NAME}`
Original file line number	Diff line number	Diff line change
`@@ -17,6 +17,7 @@ target_compile_definitions(${TEST_NAME}`
`17`	`17`	`DEVICE_SERIAL=1`
`18`	`18`	`DEVICE_INTERRUPTIN=1`
`19`	`19`	`MBED_CONF_PLATFORM_DEFAULT_SERIAL_BAUD_RATE=115200`
	`20`	`+ MBED_CONF_CELLULAR_AT_HANDLER_BUFFER_SIZE=32`
`20`	`21`	`)`
`21`	`22`
`22`	`23`	`target_sources(${TEST_NAME}`