Skip to content

Commit a484f51

Browse files
committed
STM32xx - Change how the ADC internal pins are checked before pinmap_pinout
1 parent 1ba3499 commit a484f51

File tree

9 files changed

+27
-18
lines changed

9 files changed

+27
-18
lines changed

targets/TARGET_STM/TARGET_STM32F0/analogin_api.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,9 @@ void analogin_init(analogin_t *obj, PinName pin) {
5050
MBED_ASSERT(function != (uint32_t)NC);
5151
obj->channel = STM_PIN_CHANNEL(function);
5252

53-
// Configure GPIO excepted for internal channels (Temperature, Vref, Vbat)
54-
if ((obj->channel != 16) && (obj->channel != 17) && (obj->channel != 18)) {
53+
// Configure GPIO excepted for internal channels (Temperature, Vref, Vbat, ...)
54+
// ADC Internal Channels "pins" are described in PinNames.h and must have a value >= 0xF0
55+
if (pin < 0xF0) {
5556
pinmap_pinout(pin, PinMap_ADC);
5657
}
5758

targets/TARGET_STM/TARGET_STM32F1/analogin_api.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,9 @@ void analogin_init(analogin_t *obj, PinName pin)
5252
MBED_ASSERT(function != (uint32_t)NC);
5353
obj->channel = STM_PIN_CHANNEL(function);
5454

55-
// Configure GPIO excepted for internal channels (Temperature, Vref)
56-
if ((obj->channel != 16) && (obj->channel != 17)) {
55+
// Configure GPIO excepted for internal channels (Temperature, Vref, Vbat, ...)
56+
// ADC Internal Channels "pins" are described in PinNames.h and must have a value >= 0xF0
57+
if (pin < 0xF0) {
5758
pinmap_pinout(pin, PinMap_ADC);
5859
}
5960

targets/TARGET_STM/TARGET_STM32F2/analogin_api.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,9 @@ void analogin_init(analogin_t *obj, PinName pin)
5858
MBED_ASSERT(function != (uint32_t)NC);
5959
obj->channel = STM_PIN_CHANNEL(function);
6060

61-
// Configure GPIO excepted for internal channels (Temperature, Vref, Vbat)
62-
if ((obj->channel != 16) && (obj->channel != 17) && (obj->channel != 18)) {
61+
// Configure GPIO excepted for internal channels (Temperature, Vref, Vbat, ...)
62+
// ADC Internal Channels "pins" are described in PinNames.h and must have a value >= 0xF0
63+
if (pin < 0xF0) {
6364
pinmap_pinout(pin, PinMap_ADC);
6465
}
6566

targets/TARGET_STM/TARGET_STM32F3/analogin_api.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,9 @@ void analogin_init(analogin_t *obj, PinName pin)
6262
MBED_ASSERT(function != (uint32_t)NC);
6363
obj->channel = STM_PIN_CHANNEL(function);
6464

65-
// Configure GPIO excepted for internal channels (Temperature, Vref, Vbat)
66-
if ((obj->channel != 16) && (obj->channel != 17) && (obj->channel != 18)) {
65+
// Configure GPIO excepted for internal channels (Temperature, Vref, Vbat, ...)
66+
// ADC Internal Channels "pins" are described in PinNames.h and must have a value >= 0xF0
67+
if (pin < 0xF0) {
6768
pinmap_pinout(pin, PinMap_ADC);
6869
}
6970

targets/TARGET_STM/TARGET_STM32F4/analogin_api.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,9 @@ void analogin_init(analogin_t *obj, PinName pin)
5858
MBED_ASSERT(function != (uint32_t)NC);
5959
obj->channel = STM_PIN_CHANNEL(function);
6060

61-
// Configure GPIO excepted for internal channels (Temperature, Vref, Vbat)
62-
if ((obj->channel != 16) && (obj->channel != 17) && (obj->channel != 18)) {
61+
// Configure GPIO excepted for internal channels (Temperature, Vref, Vbat, ...)
62+
// ADC Internal Channels "pins" are described in PinNames.h and must have a value >= 0xF0
63+
if (pin < 0xF0) {
6364
pinmap_pinout(pin, PinMap_ADC);
6465
}
6566

targets/TARGET_STM/TARGET_STM32F7/analogin_api.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,9 @@ void analogin_init(analogin_t *obj, PinName pin)
5959
MBED_ASSERT(function != (uint32_t)NC);
6060
obj->channel = STM_PIN_CHANNEL(function);
6161

62-
// Configure GPIO excepted for internal channels (Temperature, Vref, Vbat)
63-
if ((obj->channel != 16) && (obj->channel != 17) && (obj->channel != 18)) {
62+
// Configure GPIO excepted for internal channels (Temperature, Vref, Vbat, ...)
63+
// ADC Internal Channels "pins" are described in PinNames.h and must have a value >= 0xF0
64+
if (pin < 0xF0) {
6465
pinmap_pinout(pin, PinMap_ADC);
6566
}
6667

targets/TARGET_STM/TARGET_STM32L0/analogin_api.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,9 @@ void analogin_init(analogin_t *obj, PinName pin)
5151
MBED_ASSERT(function != (uint32_t)NC);
5252
obj->channel = STM_PIN_CHANNEL(function);
5353

54-
// Configure GPIO excepted for internal channels (Temperature, Vref, Vlcd)
55-
if ((obj->channel != 16) && (obj->channel != 17) && (obj->channel != 18)) {
54+
// Configure GPIO excepted for internal channels (Temperature, Vref, Vbat, ...)
55+
// ADC Internal Channels "pins" are described in PinNames.h and must have a value >= 0xF0
56+
if (pin < 0xF0) {
5657
pinmap_pinout(pin, PinMap_ADC);
5758
}
5859

targets/TARGET_STM/TARGET_STM32L1/analogin_api.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,9 @@ void analogin_init(analogin_t *obj, PinName pin)
5353
MBED_ASSERT(function != (uint32_t)NC);
5454
obj->channel = STM_PIN_CHANNEL(function);
5555

56-
// Configure GPIO excepted for internal channels (Temperature, Vref)
57-
if ((obj->channel != 16) && (obj->channel != 17)) {
56+
// Configure GPIO excepted for internal channels (Temperature, Vref, Vbat, ...)
57+
// ADC Internal Channels "pins" are described in PinNames.h and must have a value >= 0xF0
58+
if (pin < 0xF0) {
5859
pinmap_pinout(pin, PinMap_ADC);
5960
}
6061

targets/TARGET_STM/TARGET_STM32L4/analogin_api.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,9 @@ void analogin_init(analogin_t *obj, PinName pin)
5151
MBED_ASSERT(function != (uint32_t)NC);
5252
obj->channel = STM_PIN_CHANNEL(function);
5353

54-
// Configure GPIO excepted for internal channels (Temperature, Vref, Vbat)
55-
if ((obj->channel != 0) && (obj->channel != 17) && (obj->channel != 18)) {
54+
// Configure GPIO excepted for internal channels (Temperature, Vref, Vbat, ...)
55+
// ADC Internal Channels "pins" are described in PinNames.h and must have a value >= 0xF0
56+
if (pin < 0xF0) {
5657
pinmap_pinout(pin, PinMap_ADC);
5758
}
5859

0 commit comments

Comments
 (0)