Old Cellular UNITTESTS removed

Author: Antti Kauppila

UNITTESTS/features/cellular/framework/AT/at_cellulardevice/at_cellulardevicetest.cpp

@@ -120,6 +120,7 @@ TEST_F(TestAT_CellularDevice, test_AT_CellularDevice_close_network)
     ATHandler_stub::ref_count = 0;
 
     EXPECT_TRUE(dev.open_network(&fh1));
+    AT_CellularBase_stub::handler_value = AT_CellularBase_stub::handler_at_constructor_value;
     EXPECT_TRUE(ATHandler_stub::ref_count == 1);
 
     dev.close_network();
@@ -134,6 +135,7 @@ TEST_F(TestAT_CellularDevice, test_AT_CellularDevice_close_sms)
     ATHandler_stub::ref_count = 0;
 
     EXPECT_TRUE(dev.open_sms(&fh1));
+    AT_CellularBase_stub::handler_value = AT_CellularBase_stub::handler_at_constructor_value;
     EXPECT_TRUE(ATHandler_stub::ref_count == 1);
 
     dev.close_sms();
@@ -148,6 +150,7 @@ TEST_F(TestAT_CellularDevice, test_AT_CellularDevice_close_power)
     ATHandler_stub::ref_count = 0;
 
     EXPECT_TRUE(dev.open_power(&fh1));
+    AT_CellularBase_stub::handler_value = AT_CellularBase_stub::handler_at_constructor_value;
     EXPECT_TRUE(ATHandler_stub::ref_count == 1);
 
     dev.close_power();
@@ -163,6 +166,8 @@ TEST_F(TestAT_CellularDevice, test_AT_CellularDevice_close_sim)
 
 
     EXPECT_TRUE(dev.open_sim(&fh1));
+    AT_CellularBase_stub::handler_value = AT_CellularBase_stub::handler_at_constructor_value;
+
     dev.close_sms(); // this should not affect to refcount as it's not opened
     EXPECT_TRUE(ATHandler_stub::ref_count == 1);
 
@@ -191,6 +196,7 @@ TEST_F(TestAT_CellularDevice, test_AT_CellularDevice_close_information)
     AT_CellularBase_stub::handler_value = AT_CellularBase_stub::handler_at_constructor_value;
 
     dev.close_information();
+    EXPECT_TRUE(ATHandler_stub::ref_count == 1);
 
     ATHandler_stub::fh_value = NULL;
 }

UNITTESTS/stubs/ATHandler_stub.cpp

@@ -68,7 +68,7 @@ void ATHandler::set_debug(bool debug_on)
 
 ATHandler::~ATHandler()
 {
-    ATHandler_stub::ref_count = -909;
+    ATHandler_stub::ref_count = kATHandler_destructor_ref_ount;
 }
 
 void ATHandler::inc_ref_count()

UNITTESTS/stubs/ATHandler_stub.h

@@ -29,6 +29,8 @@
 static const int kRead_string_table_size = 100;
 static const int kRead_int_table_size = 100;
 static const int kResp_stop_count_default = 100;
+// set reference count to -909 to separate it from zero so we can test that ATHandler is really deleted.
+static const int kATHandler_destructor_ref_ount = -909;
 
 namespace ATHandler_stub {
 extern nsapi_error_t nsapi_error_value;

UNITTESTS/stubs/SocketAddress_stub.cpp

@@ -22,40 +22,16 @@
 #include "mbed.h"
 
 
-static bool ipv4_is_valid(const char *addr)
-{
-    return false;
-}
-
 static bool ipv6_is_valid(const char *addr)
 {
     return false;
 }
 
-static void ipv4_from_address(uint8_t *bytes, const char *addr)
-{
-
-}
-
 static int ipv6_scan_chunk(uint16_t *shorts, const char *chunk)
 {
     return 0;
 }
 
-static void ipv6_from_address(uint8_t *bytes, const char *addr)
-{
-
-}
-
-static void ipv4_to_address(char *addr, const uint8_t *bytes)
-{
-
-}
-
-static void ipv6_to_address(char *addr, const uint8_t *bytes)
-{
-}
-
 
 SocketAddress::SocketAddress(nsapi_addr_t addr, uint16_t port)
 {